* [PATCH] kvm, svm: Cleanup error statements
@ 2012-10-20 18:20 Borislav Petkov
2012-10-22 14:05 ` Avi Kivity
0 siblings, 1 reply; 2+ messages in thread
From: Borislav Petkov @ 2012-10-20 18:20 UTC (permalink / raw)
To: LKML; +Cc: Borislav Petkov, Joerg Roedel, Avi Kivity
Use __func__ instead of the function name in svm_hardware_enable since
those things tend to get out of sync. This also slims down printk line
length in conjunction with using pr_err.
No functionality change.
Cc: Joerg Roedel <joro@8bytes.org>
Cc: Avi Kivity <avi@redhat.com>
Signed-off-by: Borislav Petkov <bp@alien8.de>
---
arch/x86/kvm/svm.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c
index d017df3899ef..e93908fabf46 100644
--- a/arch/x86/kvm/svm.c
+++ b/arch/x86/kvm/svm.c
@@ -630,15 +630,12 @@ static int svm_hardware_enable(void *garbage)
return -EBUSY;
if (!has_svm()) {
- printk(KERN_ERR "svm_hardware_enable: err EOPNOTSUPP on %d\n",
- me);
+ pr_err("%s: err EOPNOTSUPP on %d\n", __func__, me);
return -EINVAL;
}
sd = per_cpu(svm_data, me);
-
if (!sd) {
- printk(KERN_ERR "svm_hardware_enable: svm_data is NULL on %d\n",
- me);
+ pr_err("%s: svm_data is NULL on %d\n", __func__, me);
return -EINVAL;
}
--
1.8.0.rc2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] kvm, svm: Cleanup error statements
2012-10-20 18:20 [PATCH] kvm, svm: Cleanup error statements Borislav Petkov
@ 2012-10-22 14:05 ` Avi Kivity
0 siblings, 0 replies; 2+ messages in thread
From: Avi Kivity @ 2012-10-22 14:05 UTC (permalink / raw)
To: Borislav Petkov; +Cc: LKML, Joerg Roedel
On 10/20/2012 08:20 PM, Borislav Petkov wrote:
> Use __func__ instead of the function name in svm_hardware_enable since
> those things tend to get out of sync. This also slims down printk line
> length in conjunction with using pr_err.
>
> No functionality change.
>
Applied, thanks.
--
error compiling committee.c: too many arguments to function
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-10-22 14:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-20 18:20 [PATCH] kvm, svm: Cleanup error statements Borislav Petkov
2012-10-22 14:05 ` Avi Kivity
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.