From: Rich Johnston <rjohnston@sgi.com>
To: Dave Chinner <david@fromorbit.com>
Cc: Lukas Czerner <lczerner@redhat.com>, xfs@oss.sgi.com
Subject: Re: [PATCH 2/2] 251: Do not allow step to be zero
Date: Wed, 24 Oct 2012 15:43:04 -0500 [thread overview]
Message-ID: <508852D8.6060100@sgi.com> (raw)
In-Reply-To: <20121016201829.GK2739@dastard>
Lukas,
On 10/16/2012 03:18 PM, Dave Chinner wrote:
> On Tue, Oct 16, 2012 at 11:41:34AM +0200, Lukas Czerner wrote:
>> Currently 'step' variable which is used as length of the range to
>> discard can be zero. However it would result in error returned by the
>> fstrim.
>>
>> Fix this by forcing 'step' to be at least 4KB.
>>
>> Signed-off-by: Lukas Czerner <lczerner@redhat.com>
>
> Looks fine. It may not be perfect for large block filesystems (e.g.
> on ppc or ia64) but it's better than nothing right now.
>
> Reviewed-by: Dave Chinner <dchinner@redhat.com>
>
This has been committed to git://oss.sgi.com/xfs/cmds/xfstests, master
and for-next branches.
Regards
--Rich
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-10-24 20:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-16 9:41 [PATCH 1/2] 286: Test FITRIM where length is smaller than FSB Lukas Czerner
2012-10-16 9:41 ` [PATCH 2/2] 251: Do not allow step to be zero Lukas Czerner
2012-10-16 20:18 ` Dave Chinner
2012-10-24 20:43 ` Rich Johnston [this message]
2012-10-16 20:16 ` [PATCH 1/2] 286: Test FITRIM where length is smaller than FSB Dave Chinner
2012-10-16 20:48 ` Ben Myers
2012-10-24 20:39 ` Rich Johnston
2012-10-24 20:44 ` Rich Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=508852D8.6060100@sgi.com \
--to=rjohnston@sgi.com \
--cc=david@fromorbit.com \
--cc=lczerner@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.