All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rich Johnston <rjohnston@sgi.com>
To: Dave Chinner <david@fromorbit.com>
Cc: Lukas Czerner <lczerner@redhat.com>, xfs@oss.sgi.com
Subject: Re: [PATCH 1/2] 286: Test FITRIM where length is smaller than FSB
Date: Wed, 24 Oct 2012 15:44:25 -0500	[thread overview]
Message-ID: <50885329.40408@sgi.com> (raw)
In-Reply-To: <50885216.1020201@sgi.com>

On 10/24/2012 03:39 PM, Rich Johnston wrote:
> Lukas,
>
> On 10/16/2012 03:16 PM, Dave Chinner wrote:
>> On Tue, Oct 16, 2012 at 11:41:33AM +0200, Lukas Czerner wrote:
>>> This tests corner case in FITRIM implementation where range size is
>>> smaller than file system block or zero. In this case FITRIM should fail
>>> with EINVAL.
>>>
>>> The problem was spotted in xfs and ext4 where in case of length = 0 the
>>> 'end' variable underflowed. In case of length smaller than 1 FSB FITRIM
>>> finished successfully, but we really should rather return EINVAL in both
>>> cases.
>>>
>>> (This patch has to be applied after 'Use upstream version of fstrim
>>> instead of the local one')
>>>
>>> Signed-off-by: Lukas Czerner <lczerner@redhat.com>
>>> ---
>>>   286     |   58
>>> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>>>   286.out |    6 ++++++
>>
>> We've already got 286 (and 287), so this should probably be 288...
>>
>> Otherwise, it looks good.
>>
>> Reviewed-by: Dave Chinner <dchinner@redhat.com>
>>
>
> This has been committed to git://oss.sgi.com/xfs/xfs.git, master and
> for-next branches.
>
> Regards
> --Rich
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs

My apologies, this has been committed to 
git://oss.sgi.com/xfs/cmds/xfstests, master and for-next branches.

Regards
--Rich

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      reply	other threads:[~2012-10-24 20:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-16  9:41 [PATCH 1/2] 286: Test FITRIM where length is smaller than FSB Lukas Czerner
2012-10-16  9:41 ` [PATCH 2/2] 251: Do not allow step to be zero Lukas Czerner
2012-10-16 20:18   ` Dave Chinner
2012-10-24 20:43     ` Rich Johnston
2012-10-16 20:16 ` [PATCH 1/2] 286: Test FITRIM where length is smaller than FSB Dave Chinner
2012-10-16 20:48   ` Ben Myers
2012-10-24 20:39   ` Rich Johnston
2012-10-24 20:44     ` Rich Johnston [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50885329.40408@sgi.com \
    --to=rjohnston@sgi.com \
    --cc=david@fromorbit.com \
    --cc=lczerner@redhat.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.