From: Dan Mick <dan.mick@inktank.com>
To: Joe Buck <jbbuck@gmail.com>
Cc: "ceph-devel@vger.kernel.org" <ceph-devel@vger.kernel.org>
Subject: Re: Seeking review of a pull request in teuthology
Date: Wed, 24 Oct 2012 21:01:25 -0700 [thread overview]
Message-ID: <5088B995.7030008@inktank.com> (raw)
In-Reply-To: <508893F7.4070502@gmail.com>
LGTM. I might emphasize "user" rather than "owner", but that's clearly
a nit. Also, does this now obviate the #TODO?
On 10/24/2012 06:20 PM, Joe Buck wrote:
> I submitted a pull request for teuthology/task/workunit.py that uses the
> configured owner rather than using the hard-coded "ubuntu" username when
> creating a scratch directory in /tmp.
>
> -Joe Buck
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-10-25 4:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-25 1:20 Seeking review of a pull request in teuthology Joe Buck
2012-10-25 4:01 ` Dan Mick [this message]
2012-10-26 0:52 ` Joe Buck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5088B995.7030008@inktank.com \
--to=dan.mick@inktank.com \
--cc=ceph-devel@vger.kernel.org \
--cc=jbbuck@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.