* Seeking review of a pull request in teuthology @ 2012-10-25 1:20 Joe Buck 2012-10-25 4:01 ` Dan Mick 2012-10-26 0:52 ` Joe Buck 0 siblings, 2 replies; 3+ messages in thread From: Joe Buck @ 2012-10-25 1:20 UTC (permalink / raw) To: ceph-devel@vger.kernel.org I submitted a pull request for teuthology/task/workunit.py that uses the configured owner rather than using the hard-coded "ubuntu" username when creating a scratch directory in /tmp. -Joe Buck ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Seeking review of a pull request in teuthology 2012-10-25 1:20 Seeking review of a pull request in teuthology Joe Buck @ 2012-10-25 4:01 ` Dan Mick 2012-10-26 0:52 ` Joe Buck 1 sibling, 0 replies; 3+ messages in thread From: Dan Mick @ 2012-10-25 4:01 UTC (permalink / raw) To: Joe Buck; +Cc: ceph-devel@vger.kernel.org LGTM. I might emphasize "user" rather than "owner", but that's clearly a nit. Also, does this now obviate the #TODO? On 10/24/2012 06:20 PM, Joe Buck wrote: > I submitted a pull request for teuthology/task/workunit.py that uses the > configured owner rather than using the hard-coded "ubuntu" username when > creating a scratch directory in /tmp. > > -Joe Buck > -- > To unsubscribe from this list: send the line "unsubscribe ceph-devel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Seeking review of a pull request in teuthology 2012-10-25 1:20 Seeking review of a pull request in teuthology Joe Buck 2012-10-25 4:01 ` Dan Mick @ 2012-10-26 0:52 ` Joe Buck 1 sibling, 0 replies; 3+ messages in thread From: Joe Buck @ 2012-10-26 0:52 UTC (permalink / raw) To: ceph-devel@vger.kernel.org Based on the feedback I received, I changed this patch to use the username in the remote object. I've also updated the commit comment to reference a user and not an owner. The pull request is in teuthology branch wip-buck if someone could take another look at it. Best, -Joe Buck On 10/24/2012 06:20 PM, Joe Buck wrote: > I submitted a pull request for teuthology/task/workunit.py that uses > the configured owner rather than using the hard-coded "ubuntu" > username when creating a scratch directory in /tmp. > > -Joe Buck ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-10-26 0:52 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-10-25 1:20 Seeking review of a pull request in teuthology Joe Buck 2012-10-25 4:01 ` Dan Mick 2012-10-26 0:52 ` Joe Buck
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.