From: Shubhrajyoti <shubhrajyoti@ti.com>
To: balbi@ti.com
Cc: linux-omap@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, ben-linux@fluff.org,
tony@atomide.com, w.sang@pengutronix.de
Subject: Re: [PATCH] i2c: omap: re-factor omap_i2c_init function
Date: Thu, 25 Oct 2012 11:02:38 +0530 [thread overview]
Message-ID: <5088CEF6.5000606@ti.com> (raw)
In-Reply-To: <20121023191124.GB853@arwen.pp.htv.fi>
On 10/24/2012 12:41 AM, Felipe Balbi wrote:
>>
>> > return 0;
>> > }
> another thing, the few places in omap_i2c_xfer_msg() which are currently
> calling omap_i2c_init() should also be converted to call the newly added
> __omap_i2c_init(). We don't need to recalculate any of those clock
> dividers and whatnot.
Yes in fact omap_i2c_init() can be reset - calculate - and __omap_i2c_init.
Then in those places the recalculate can be optimised.
WARNING: multiple messages have this Message-ID (diff)
From: shubhrajyoti@ti.com (Shubhrajyoti)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] i2c: omap: re-factor omap_i2c_init function
Date: Thu, 25 Oct 2012 11:02:38 +0530 [thread overview]
Message-ID: <5088CEF6.5000606@ti.com> (raw)
In-Reply-To: <20121023191124.GB853@arwen.pp.htv.fi>
On 10/24/2012 12:41 AM, Felipe Balbi wrote:
>>
>> > return 0;
>> > }
> another thing, the few places in omap_i2c_xfer_msg() which are currently
> calling omap_i2c_init() should also be converted to call the newly added
> __omap_i2c_init(). We don't need to recalculate any of those clock
> dividers and whatnot.
Yes in fact omap_i2c_init() can be reset - calculate - and __omap_i2c_init.
Then in those places the recalculate can be optimised.
next prev parent reply other threads:[~2012-10-25 5:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-23 15:27 [PATCH] i2c: omap: re-factor omap_i2c_init function Shubhrajyoti D
2012-10-23 15:27 ` Shubhrajyoti D
2012-10-23 17:18 ` Felipe Balbi
2012-10-23 17:18 ` Felipe Balbi
2012-10-23 17:56 ` Shubhrajyoti Datta
2012-10-23 17:56 ` Shubhrajyoti Datta
[not found] ` <CAM=Q2cs-+O_BFrZFX4fuBooogEZiQO2Zxbm8W40vN9hmampLCA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-10-23 17:57 ` Felipe Balbi
2012-10-23 17:57 ` Felipe Balbi
[not found] ` <20121023175706.GC32517-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2012-10-23 18:04 ` Shubhrajyoti Datta
2012-10-23 18:04 ` Shubhrajyoti Datta
2012-10-25 5:57 ` Shubhrajyoti Datta
2012-10-25 5:57 ` Shubhrajyoti Datta
[not found] ` <1351006039-24332-1-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
2012-10-23 19:11 ` Felipe Balbi
2012-10-23 19:11 ` Felipe Balbi
2012-10-25 5:32 ` Shubhrajyoti [this message]
2012-10-25 5:32 ` Shubhrajyoti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5088CEF6.5000606@ti.com \
--to=shubhrajyoti@ti.com \
--cc=balbi@ti.com \
--cc=ben-linux@fluff.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.