All of lore.kernel.org
 help / color / mirror / Atom feed
From: zhangyanfei <zhangyanfei@cn.fujitsu.com>
To: x86@kernel.org, kexec@lists.infradead.org,
	Avi Kivity <avi@redhat.com>,
	mtosatti@redhat.com
Cc: linux-kernel@vger.kernel.org,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [PATCH v2 0/2] x86: clear vmcss on all cpus when doing kdump if necessary
Date: Thu, 25 Oct 2012 18:47:27 +0800	[thread overview]
Message-ID: <508918BF.8040500@cn.fujitsu.com> (raw)
In-Reply-To: <5080E813.7030302@cn.fujitsu.com>

Would anyone help review the patch, and give some comments, please ? 

Avi?

于 2012年10月19日 13:41, Zhang Yanfei 写道:
> Currently, kdump just makes all the logical processors leave VMX operation by
> executing VMXOFF instruction, so any VMCSs active on the logical processors may
> be corrupted. But, sometimes, we need the VMCSs to debug guest images contained
> in the host vmcore. To prevent the corruption, we should VMCLEAR the VMCSs before
> executing the VMXOFF instruction.
> 
> The patch set provides a way to VMCLEAR vmcss related to guests on all cpus before
> executing the VMXOFF when doing kdump. This is used to ensure the VMCSs in the
> vmcore updated and non-corrupted.
> 
> Changelog from v1 to v2:
> 1. remove the sysctl and clear VMCSs unconditionally.
> 
> zhangyanfei (2):
>   x86/kexec: VMCLEAR vmcss on all cpus if necessary
>   KVM: make crash_clear_loaded_vmcss valid when loading kvm_intel
>     module
> 
>  arch/x86/include/asm/kexec.h |    2 ++
>  arch/x86/kernel/crash.c      |   27 +++++++++++++++++++++++++++
>  arch/x86/kvm/vmx.c           |    9 +++++++++
>  3 files changed, 38 insertions(+), 0 deletions(-)
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: zhangyanfei <zhangyanfei@cn.fujitsu.com>
To: x86@kernel.org, kexec@lists.infradead.org,
	Avi Kivity <avi@redhat.com>,
	mtosatti@redhat.com
Cc: linux-kernel@vger.kernel.org,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [PATCH v2 0/2] x86: clear vmcss on all cpus when doing kdump if necessary
Date: Thu, 25 Oct 2012 18:47:27 +0800	[thread overview]
Message-ID: <508918BF.8040500@cn.fujitsu.com> (raw)
In-Reply-To: <5080E813.7030302@cn.fujitsu.com>

Would anyone help review the patch, and give some comments, please ? 

Avi?

于 2012年10月19日 13:41, Zhang Yanfei 写道:
> Currently, kdump just makes all the logical processors leave VMX operation by
> executing VMXOFF instruction, so any VMCSs active on the logical processors may
> be corrupted. But, sometimes, we need the VMCSs to debug guest images contained
> in the host vmcore. To prevent the corruption, we should VMCLEAR the VMCSs before
> executing the VMXOFF instruction.
> 
> The patch set provides a way to VMCLEAR vmcss related to guests on all cpus before
> executing the VMXOFF when doing kdump. This is used to ensure the VMCSs in the
> vmcore updated and non-corrupted.
> 
> Changelog from v1 to v2:
> 1. remove the sysctl and clear VMCSs unconditionally.
> 
> zhangyanfei (2):
>   x86/kexec: VMCLEAR vmcss on all cpus if necessary
>   KVM: make crash_clear_loaded_vmcss valid when loading kvm_intel
>     module
> 
>  arch/x86/include/asm/kexec.h |    2 ++
>  arch/x86/kernel/crash.c      |   27 +++++++++++++++++++++++++++
>  arch/x86/kvm/vmx.c           |    9 +++++++++
>  3 files changed, 38 insertions(+), 0 deletions(-)
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 

  parent reply	other threads:[~2012-10-25 10:48 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-19  5:41 [PATCH v2 0/2] x86: clear vmcss on all cpus when doing kdump if necessary Zhang Yanfei
2012-10-19  5:41 ` Zhang Yanfei
2012-10-19  5:44 ` [PATCH 1/2] x86/kexec: VMCLEAR vmcss on all cpus " Zhang Yanfei
2012-10-19  5:44   ` Zhang Yanfei
2012-10-19  5:44   ` Zhang Yanfei
2012-10-31  0:18   ` Marcelo Tosatti
2012-10-31  0:18     ` Marcelo Tosatti
2012-10-31  0:18     ` Marcelo Tosatti
2012-10-31  1:52     ` zhangyanfei
2012-10-31  1:52       ` zhangyanfei
2012-10-19  5:46 ` [PATCH 2/2] KVM: make crash_clear_loaded_vmcss valid when loading kvm_intel module Zhang Yanfei
2012-10-19  5:46   ` Zhang Yanfei
2012-10-19  5:46   ` Zhang Yanfei
2012-10-25 10:47 ` zhangyanfei [this message]
2012-10-25 10:47   ` [PATCH v2 0/2] x86: clear vmcss on all cpus when doing kdump if necessary zhangyanfei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=508918BF.8040500@cn.fujitsu.com \
    --to=zhangyanfei@cn.fujitsu.com \
    --cc=avi@redhat.com \
    --cc=kexec@lists.infradead.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.