* [patch] staging: r8712u: cleanup pointer type in r8712_setassocsta_cmd()
@ 2012-10-25 12:30 Dan Carpenter
2012-10-25 14:58 ` Larry Finger
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2012-10-25 12:30 UTC (permalink / raw)
To: kernel-janitors
This seems like a cut and paste bug. Smatch complains that we don't
allocate enough memory for a set_stakey_rsp struct. In fact this is
used as a set_assocsta_rsp struct throughout and that also matches the
name of the function.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
index 659683e..31f31dbf 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.c
+++ b/drivers/staging/rtl8712/rtl871x_cmd.c
@@ -814,7 +814,7 @@ u8 r8712_setassocsta_cmd(struct _adapter *padapter, u8 *mac_addr)
struct cmd_priv *pcmdpriv = &padapter->cmdpriv;
struct cmd_obj *ph2c;
struct set_assocsta_parm *psetassocsta_para;
- struct set_stakey_rsp *psetassocsta_rsp = NULL;
+ struct set_assocsta_rsp *psetassocsta_rsp = NULL;
ph2c = (struct cmd_obj *)_malloc(sizeof(struct cmd_obj));
if (ph2c = NULL)
@@ -825,7 +825,7 @@ u8 r8712_setassocsta_cmd(struct _adapter *padapter, u8 *mac_addr)
kfree((u8 *) ph2c);
return _FAIL;
}
- psetassocsta_rsp = (struct set_stakey_rsp *)_malloc(
+ psetassocsta_rsp = (struct set_assocsta_rsp *)_malloc(
sizeof(struct set_assocsta_rsp));
if (psetassocsta_rsp = NULL) {
kfree((u8 *)ph2c);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] staging: r8712u: cleanup pointer type in r8712_setassocsta_cmd()
2012-10-25 12:30 [patch] staging: r8712u: cleanup pointer type in r8712_setassocsta_cmd() Dan Carpenter
@ 2012-10-25 14:58 ` Larry Finger
0 siblings, 0 replies; 2+ messages in thread
From: Larry Finger @ 2012-10-25 14:58 UTC (permalink / raw)
To: kernel-janitors
On 10/25/2012 07:30 AM, Dan Carpenter wrote:
> This seems like a cut and paste bug. Smatch complains that we don't
> allocate enough memory for a set_stakey_rsp struct. In fact this is
> used as a set_assocsta_rsp struct throughout and that also matches the
> name of the function.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Thanks,
Larry
>
> diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
> index 659683e..31f31dbf 100644
> --- a/drivers/staging/rtl8712/rtl871x_cmd.c
> +++ b/drivers/staging/rtl8712/rtl871x_cmd.c
> @@ -814,7 +814,7 @@ u8 r8712_setassocsta_cmd(struct _adapter *padapter, u8 *mac_addr)
> struct cmd_priv *pcmdpriv = &padapter->cmdpriv;
> struct cmd_obj *ph2c;
> struct set_assocsta_parm *psetassocsta_para;
> - struct set_stakey_rsp *psetassocsta_rsp = NULL;
> + struct set_assocsta_rsp *psetassocsta_rsp = NULL;
>
> ph2c = (struct cmd_obj *)_malloc(sizeof(struct cmd_obj));
> if (ph2c = NULL)
> @@ -825,7 +825,7 @@ u8 r8712_setassocsta_cmd(struct _adapter *padapter, u8 *mac_addr)
> kfree((u8 *) ph2c);
> return _FAIL;
> }
> - psetassocsta_rsp = (struct set_stakey_rsp *)_malloc(
> + psetassocsta_rsp = (struct set_assocsta_rsp *)_malloc(
> sizeof(struct set_assocsta_rsp));
> if (psetassocsta_rsp = NULL) {
> kfree((u8 *)ph2c);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-10-25 14:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-25 12:30 [patch] staging: r8712u: cleanup pointer type in r8712_setassocsta_cmd() Dan Carpenter
2012-10-25 14:58 ` Larry Finger
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.