From: stigge@antcom.de (Roland Stigge)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: mach-imx: CAN clock fix for i.MX53
Date: Fri, 26 Oct 2012 13:05:54 +0200 [thread overview]
Message-ID: <508A6E92.1000107@antcom.de> (raw)
In-Reply-To: <508A665C.80107@pengutronix.de>
On 10/26/2012 12:30 PM, Marc Kleine-Budde wrote:
>>>> + clk[can1_serial_gate] = imx_clk_gate2("can1_serial_gate",
>>>> "can_sel", MXC_CCM_CCGR4, 6); + clk[can1_ipg_gate] =
>>>> imx_clk_gate2("can1_ipg_gate", "ipg", MXC_CCM_CCGR4, 8); +
>>>> clk[can2_serial_gate] = imx_clk_gate2("can2_serial_gate",
>>>> "can_sel", MXC_CCM_CCGR4, 6); + clk[can2_ipg_gate] =
>>>> imx_clk_gate2("can2_ipg_gate", "ipg", MXC_CCM_CCGR4, 8);
>>>
>>> This doesn't.
>>
>> This may be right, but unfortunately, since the introduction of
>> your can1 + can2 clocking change, the first block stopped working
>> for me.
>
> You are effectively using can2's clock for can1. Are you sure you
> haven't mixed up can1 and can2?
Just using the above patch and patch 1/2 from this series (missing can
pinmuxing), doing like this in custom .dts:
+ can1: can at 53fc8000 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_can1_1>;
+ clock-frequency = <66500000>;
+ status = "okay";
+ };
Then, the can0 interface appears which can be upped as network interface.
Quite straightforward, isn't it?
Roland
WARNING: multiple messages have this Message-ID (diff)
From: Roland Stigge <stigge@antcom.de>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: Sascha Hauer <s.hauer@pengutronix.de>,
kernel@pengutronix.de, linux@arm.linux.org.uk,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
"tru@work-microwave.de" <tru@work-microwave.de>
Subject: Re: [PATCH 2/2] ARM: mach-imx: CAN clock fix for i.MX53
Date: Fri, 26 Oct 2012 13:05:54 +0200 [thread overview]
Message-ID: <508A6E92.1000107@antcom.de> (raw)
In-Reply-To: <508A665C.80107@pengutronix.de>
On 10/26/2012 12:30 PM, Marc Kleine-Budde wrote:
>>>> + clk[can1_serial_gate] = imx_clk_gate2("can1_serial_gate",
>>>> "can_sel", MXC_CCM_CCGR4, 6); + clk[can1_ipg_gate] =
>>>> imx_clk_gate2("can1_ipg_gate", "ipg", MXC_CCM_CCGR4, 8); +
>>>> clk[can2_serial_gate] = imx_clk_gate2("can2_serial_gate",
>>>> "can_sel", MXC_CCM_CCGR4, 6); + clk[can2_ipg_gate] =
>>>> imx_clk_gate2("can2_ipg_gate", "ipg", MXC_CCM_CCGR4, 8);
>>>
>>> This doesn't.
>>
>> This may be right, but unfortunately, since the introduction of
>> your can1 + can2 clocking change, the first block stopped working
>> for me.
>
> You are effectively using can2's clock for can1. Are you sure you
> haven't mixed up can1 and can2?
Just using the above patch and patch 1/2 from this series (missing can
pinmuxing), doing like this in custom .dts:
+ can1: can@53fc8000 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_can1_1>;
+ clock-frequency = <66500000>;
+ status = "okay";
+ };
Then, the can0 interface appears which can be upped as network interface.
Quite straightforward, isn't it?
Roland
next prev parent reply other threads:[~2012-10-26 11:05 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-25 11:26 [PATCH 1/2] ARM: mach-imx: imx53.dtsi: pinctl update Roland Stigge
2012-10-25 11:26 ` Roland Stigge
2012-10-25 11:26 ` [PATCH 2/2] ARM: mach-imx: CAN clock fix for i.MX53 Roland Stigge
2012-10-25 11:26 ` Roland Stigge
2012-10-26 8:59 ` Sascha Hauer
2012-10-26 8:59 ` Sascha Hauer
2012-10-26 9:16 ` Roland Stigge
2012-10-26 9:16 ` Roland Stigge
2012-10-26 10:30 ` Marc Kleine-Budde
2012-10-26 10:30 ` Marc Kleine-Budde
2012-10-26 11:05 ` Roland Stigge [this message]
2012-10-26 11:05 ` Roland Stigge
2012-10-26 13:52 ` Roland Stigge
2012-10-26 13:52 ` Roland Stigge
2012-10-26 14:05 ` Marc Kleine-Budde
2012-10-26 14:05 ` Marc Kleine-Budde
2012-10-29 21:20 ` Sascha Hauer
2012-10-29 21:20 ` Sascha Hauer
2012-10-29 21:31 ` Roland Stigge
2012-10-29 21:31 ` Roland Stigge
2012-10-29 21:13 ` [PATCH 1/2] ARM: mach-imx: imx53.dtsi: pinctl update Sascha Hauer
2012-10-29 21:13 ` Sascha Hauer
2012-10-30 2:46 ` Shawn Guo
2012-10-30 2:46 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=508A6E92.1000107@antcom.de \
--to=stigge@antcom.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.