From: Venkatraman S <svenkatr@ti.com>
To: balbi@ti.com
Cc: Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
linux-mmc@vger.kernel.org, cjb@laptop.org,
Tony Lindgren <tony@atomide.com>, Balaji T K <balajitk@ti.com>,
Linux ARM Kernel Mailing List
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [RFC/PATCH] mmc: omap_hsmmc: introduce omap_hsmmc_prepare/complete
Date: Fri, 26 Oct 2012 16:45:17 +0530 [thread overview]
Message-ID: <508A70C5.1000407@ti.com> (raw)
In-Reply-To: <20121025180418.GB18046@arwen.pp.htv.fi>
On Thursday 25 October 2012 11:34 PM, Felipe Balbi wrote:
> Hi,
>
> On Mon, Oct 22, 2012 at 04:27:08PM +0300, Felipe Balbi wrote:
>> On Mon, Oct 22, 2012 at 03:59:28PM +0300, Felipe Balbi wrote:
>>> prepare() is supposed to prevent new children from
>>> being registered. On the MMC subsystem, children
>>> (new cards) registration starts with the card
>>> detect IRQ.
>>>
>>> Move card detect IRQ disabling to prepare() so that
>>> no new cards will be registered while we're trying
>>> to suspend.
>>>
>>> Likewise, move card detect IRQ enabling to complete()
>>> so we only try to register new children after our MMC
>>> IP is back up.
>>>
>>> Signed-off-by: Felipe Balbi <balbi@ti.com>
>>> ---
>>>
>>> Venkat, do you think the patch below makes sense ?
>> btw, just checked suspend to ram with beagle and panda. We still have
>> our filesystem after waking up.
>>
>> ps: you will [1] to test it:
>>
>> [1] http://marc.info/?l=linux-arm-kernel&m=135090724817604&w=2
> ping
>
I've been off for the past 3 days. Will test this on Monday once I'm
back in office.
WARNING: multiple messages have this Message-ID (diff)
From: svenkatr@ti.com (Venkatraman S)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC/PATCH] mmc: omap_hsmmc: introduce omap_hsmmc_prepare/complete
Date: Fri, 26 Oct 2012 16:45:17 +0530 [thread overview]
Message-ID: <508A70C5.1000407@ti.com> (raw)
In-Reply-To: <20121025180418.GB18046@arwen.pp.htv.fi>
On Thursday 25 October 2012 11:34 PM, Felipe Balbi wrote:
> Hi,
>
> On Mon, Oct 22, 2012 at 04:27:08PM +0300, Felipe Balbi wrote:
>> On Mon, Oct 22, 2012 at 03:59:28PM +0300, Felipe Balbi wrote:
>>> prepare() is supposed to prevent new children from
>>> being registered. On the MMC subsystem, children
>>> (new cards) registration starts with the card
>>> detect IRQ.
>>>
>>> Move card detect IRQ disabling to prepare() so that
>>> no new cards will be registered while we're trying
>>> to suspend.
>>>
>>> Likewise, move card detect IRQ enabling to complete()
>>> so we only try to register new children after our MMC
>>> IP is back up.
>>>
>>> Signed-off-by: Felipe Balbi <balbi@ti.com>
>>> ---
>>>
>>> Venkat, do you think the patch below makes sense ?
>> btw, just checked suspend to ram with beagle and panda. We still have
>> our filesystem after waking up.
>>
>> ps: you will [1] to test it:
>>
>> [1] http://marc.info/?l=linux-arm-kernel&m=135090724817604&w=2
> ping
>
I've been off for the past 3 days. Will test this on Monday once I'm
back in office.
next prev parent reply other threads:[~2012-10-26 11:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-22 12:59 [RFC/PATCH] mmc: omap_hsmmc: introduce omap_hsmmc_prepare/complete Felipe Balbi
2012-10-22 12:59 ` Felipe Balbi
2012-10-22 13:27 ` Felipe Balbi
2012-10-22 13:27 ` Felipe Balbi
2012-10-25 18:04 ` Felipe Balbi
2012-10-25 18:04 ` Felipe Balbi
2012-10-26 11:15 ` Venkatraman S [this message]
2012-10-26 11:15 ` Venkatraman S
2012-11-06 15:50 ` Venkatraman S
2012-11-06 15:50 ` Venkatraman S
2012-11-06 16:34 ` [PATCH v2] " Felipe Balbi
2012-11-06 16:34 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=508A70C5.1000407@ti.com \
--to=svenkatr@ti.com \
--cc=balajitk@ti.com \
--cc=balbi@ti.com \
--cc=cjb@laptop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.