From: gregory.clement@free-electrons.com (Gregory CLEMENT)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 2/4] arm: mvebu: adding SATA support: dt binding for Armada 370/XP
Date: Fri, 26 Oct 2012 17:06:29 +0200 [thread overview]
Message-ID: <508AA6F5.7050806@free-electrons.com> (raw)
In-Reply-To: <20121026150206.GQ18811@titan.lakedaemon.net>
On 10/26/2012 05:02 PM, Jason Cooper wrote:
> On Fri, Oct 26, 2012 at 04:57:59PM +0200, Thomas Petazzoni wrote:
>>
>> On Fri, 26 Oct 2012 15:52:25 +0200, Andrew Lunn wrote:
>>>> Now, about white spaces vs tab, I don't know what is the rule
>>>> for .dts file.
>>>
>>> I personally use tabs, but i don't see anything in the
>>> Documentation/CodingStyle.
>>>
>>> Maybe ask on the device tree mailing list?
>>
>> Yes, it would be good to know and document what is the rule for .dts
>> files, and possibly extend checkpatch to cover those special rules
>> for .dts files.
>
> until that is resolved, can we make this patch conform to what is in the
> file currently? Once the dt folks clarify, we can run through all the
> dts's and submit one cleanup series.
>
> If there are no other comments on this series, I'm fine taking it as is
> and doing the fixup on my end. No need to do a version bump just for
> this.
OK then you will just have to replace my tabs by whitespace.
Thanks,
Gregory
WARNING: multiple messages have this Message-ID (diff)
From: Gregory CLEMENT <gregory.clement@free-electrons.com>
To: Jason Cooper <jason@lakedaemon.net>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Andrew Lunn <andrew@lunn.ch>,
linux-arm-kernel@lists.infradead.org,
Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
Ben Dooks <ben-linux@fluff.org>,
Ian Molton <ian.molton@codethink.co.uk>,
Nicolas Pitre <nico@fluxnic.net>,
Lior Amsalem <alior@marvell.com>,
Maen Suleiman <maen@marvell.com>,
Tawfik Bayouk <tawfik@marvell.com>,
Shadi Ammouri <shadi@marvell.com>,
Eran Ben-Avi <benavi@marvell.com>,
Yehuda Yitschak <yehuday@marvell.com>,
Nadav Haklai <nadavh@marvell.com>,
Ike Pan <ike.pan@canonical.com>,
Jani Monoses <jani.monoses@canonical.com>,
Chris Van Hoof <vanhoof@canonical.com>,
Dan Frazier <dann.frazier@canonical.com>,
Leif Lindholm <leif.lindholm@arm.com>,
Jon Masters <jcm@redhat.com>, David Marlin <dmarlin@redhat.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 2/4] arm: mvebu: adding SATA support: dt binding for Armada 370/XP
Date: Fri, 26 Oct 2012 17:06:29 +0200 [thread overview]
Message-ID: <508AA6F5.7050806@free-electrons.com> (raw)
In-Reply-To: <20121026150206.GQ18811@titan.lakedaemon.net>
On 10/26/2012 05:02 PM, Jason Cooper wrote:
> On Fri, Oct 26, 2012 at 04:57:59PM +0200, Thomas Petazzoni wrote:
>>
>> On Fri, 26 Oct 2012 15:52:25 +0200, Andrew Lunn wrote:
>>>> Now, about white spaces vs tab, I don't know what is the rule
>>>> for .dts file.
>>>
>>> I personally use tabs, but i don't see anything in the
>>> Documentation/CodingStyle.
>>>
>>> Maybe ask on the device tree mailing list?
>>
>> Yes, it would be good to know and document what is the rule for .dts
>> files, and possibly extend checkpatch to cover those special rules
>> for .dts files.
>
> until that is resolved, can we make this patch conform to what is in the
> file currently? Once the dt folks clarify, we can run through all the
> dts's and submit one cleanup series.
>
> If there are no other comments on this series, I'm fine taking it as is
> and doing the fixup on my end. No need to do a version bump just for
> this.
OK then you will just have to replace my tabs by whitespace.
Thanks,
Gregory
next prev parent reply other threads:[~2012-10-26 15:06 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-26 12:30 [PATCH V2 0/4] Adding SATA support for Armada 370/XP Gregory CLEMENT
2012-10-26 12:30 ` Gregory CLEMENT
2012-10-26 12:30 ` [PATCH V2 1/4] arm: mvebu: increase atomic coherent pool size for armada 370/XP Gregory CLEMENT
2012-10-26 12:30 ` Gregory CLEMENT
2012-10-26 12:30 ` [PATCH V2 2/4] arm: mvebu: adding SATA support: dt binding for Armada 370/XP Gregory CLEMENT
2012-10-26 12:30 ` Gregory CLEMENT
2012-10-26 13:31 ` Jason Cooper
2012-10-26 13:31 ` Jason Cooper
2012-10-26 13:34 ` Andrew Lunn
2012-10-26 13:34 ` Andrew Lunn
2012-10-26 13:47 ` Gregory CLEMENT
2012-10-26 13:47 ` Gregory CLEMENT
2012-10-26 13:52 ` Andrew Lunn
2012-10-26 13:52 ` Andrew Lunn
2012-10-26 14:57 ` Thomas Petazzoni
2012-10-26 14:57 ` Thomas Petazzoni
2012-10-26 15:02 ` Jason Cooper
2012-10-26 15:02 ` Jason Cooper
2012-10-26 15:06 ` Gregory CLEMENT [this message]
2012-10-26 15:06 ` Gregory CLEMENT
2012-10-26 12:30 ` [PATCH V2 3/4] arm: mvebu: adding SATA support: configs update Gregory CLEMENT
2012-10-26 12:30 ` Gregory CLEMENT
2012-10-26 12:30 ` [PATCH V2 4/4] arm: mvebu: adding SATA support: dt binding for Armada 370/XP boards Gregory CLEMENT
2012-10-26 12:30 ` Gregory CLEMENT
2012-10-26 12:39 ` [PATCH V2 0/4] Adding SATA support for Armada 370/XP Andrew Lunn
2012-10-26 12:39 ` Andrew Lunn
2012-10-26 12:48 ` Thomas Petazzoni
2012-10-26 12:48 ` Thomas Petazzoni
2012-10-26 12:54 ` Andrew Lunn
2012-10-26 12:54 ` Andrew Lunn
2012-10-26 12:55 ` Gregory CLEMENT
2012-10-26 12:55 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=508AA6F5.7050806@free-electrons.com \
--to=gregory.clement@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.