From: Vineet Gupta <Vineet.Gupta1@synopsys.com>
To: balbi@ti.com
Cc: gregkh@linuxfoundation.org, alan@linux.intel.com,
arc-linux-dev@synopsys.com, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] serial/arc-uart: Add new driver
Date: Sat, 27 Oct 2012 12:24:46 +0530 [thread overview]
Message-ID: <508B8536.1080303@synopsys.com> (raw)
In-Reply-To: <20121026121032.GD26342@arwen.pp.htv.fi>
On Friday 26 October 2012 05:40 PM, Felipe Balbi wrote:
> On Fri, Oct 26, 2012 at 05:33:16PM +0530, Vineet.Gupta1@synopsys.com wrote:
>> +/*
>> + * Release the memory region(s) being used by 'port'.
>> + */
>> +static void arc_serial_release_port(struct uart_port *port)
>> +{
>> +}
>> +
>> +/*
>> + * Request the memory region(s) being used by 'port'.
>> + */
>> +static int arc_serial_request_port(struct uart_port *port)
>> +{
>> + return 0;
>> +}
>> +
>> +/*
>> + * Verify the new serial_struct (for TIOCSSERIAL).
>> + */
>> +static int
>> +arc_serial_verify_port(struct uart_port *port, struct serial_struct *ser)
>> +{
>> + return 0;
>> +}
> why all these empty functions with wrong comments above them ??
Actually serial_core.c invokes the reqest/release callbacks w/o
verifying for a NULL pointer check. Thus they need to be in there even
if empty. I've removed the offending comments though !
-Vineet
WARNING: multiple messages have this Message-ID (diff)
From: Vineet Gupta <Vineet.Gupta1@synopsys.com>
To: <balbi@ti.com>
Cc: <gregkh@linuxfoundation.org>, <alan@linux.intel.com>,
<arc-linux-dev@synopsys.com>, <linux-serial@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5] serial/arc-uart: Add new driver
Date: Sat, 27 Oct 2012 12:24:46 +0530 [thread overview]
Message-ID: <508B8536.1080303@synopsys.com> (raw)
In-Reply-To: <20121026121032.GD26342@arwen.pp.htv.fi>
On Friday 26 October 2012 05:40 PM, Felipe Balbi wrote:
> On Fri, Oct 26, 2012 at 05:33:16PM +0530, Vineet.Gupta1@synopsys.com wrote:
>> +/*
>> + * Release the memory region(s) being used by 'port'.
>> + */
>> +static void arc_serial_release_port(struct uart_port *port)
>> +{
>> +}
>> +
>> +/*
>> + * Request the memory region(s) being used by 'port'.
>> + */
>> +static int arc_serial_request_port(struct uart_port *port)
>> +{
>> + return 0;
>> +}
>> +
>> +/*
>> + * Verify the new serial_struct (for TIOCSSERIAL).
>> + */
>> +static int
>> +arc_serial_verify_port(struct uart_port *port, struct serial_struct *ser)
>> +{
>> + return 0;
>> +}
> why all these empty functions with wrong comments above them ??
Actually serial_core.c invokes the reqest/release callbacks w/o
verifying for a NULL pointer check. Thus they need to be in there even
if empty. I've removed the offending comments though !
-Vineet
next prev parent reply other threads:[~2012-10-27 6:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-26 12:03 [PATCH v5] serial/arc-uart: Add new driver Vineet.Gupta1
2012-10-26 12:03 ` Vineet.Gupta1
2012-10-26 12:03 ` Vineet.Gupta1
2012-10-26 12:03 ` Vineet.Gupta1
2012-10-26 12:10 ` Felipe Balbi
2012-10-26 12:10 ` Felipe Balbi
2012-10-26 12:47 ` Vineet Gupta
2012-10-26 12:47 ` Vineet Gupta
2012-10-26 13:54 ` Felipe Balbi
2012-10-26 13:54 ` Felipe Balbi
2012-10-27 6:54 ` Vineet Gupta [this message]
2012-10-27 6:54 ` Vineet Gupta
2012-10-29 11:06 ` Felipe Balbi
2012-10-29 11:06 ` Felipe Balbi
2012-10-29 11:18 ` Vineet Gupta
2012-10-29 11:18 ` Vineet Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=508B8536.1080303@synopsys.com \
--to=vineet.gupta1@synopsys.com \
--cc=alan@linux.intel.com \
--cc=arc-linux-dev@synopsys.com \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.