From: kishon <kishon@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Felipe Balbi <balbi@ti.com>, Arnd Bergmann <arnd@arndb.de>,
linux@arm.linux.org.uk, b-cousson@ti.com, olof@lixom.net,
rdunlap@xenotime.net, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] ARM: OMAP: ocp2scp: create omap device for ocp2scp
Date: Sat, 27 Oct 2012 17:59:51 +0530 [thread overview]
Message-ID: <508BD3BF.1080409@ti.com> (raw)
In-Reply-To: <20121026201631.GR11908@atomide.com>
On Saturday 27 October 2012 01:46 AM, Tony Lindgren wrote:
> * Felipe Balbi <balbi@ti.com> [121026 13:07]:
>> On Fri, Oct 26, 2012 at 10:21:41AM -0700, Tony Lindgren wrote:
>>> * Arnd Bergmann <arnd@arndb.de> [121026 00:48]:
>>>> On Friday 26 October 2012, Felipe Balbi wrote:
>>>>>> +static void omap_init_ocp2scp(void)
>>>>>> +{
>>>>>> + struct omap_hwmod *oh;
>>>>>> + struct platform_device *pdev;
>>>>>> + int bus_id = -1, dev_cnt = 0, i;
>>>>>> + struct omap_ocp2scp_dev *ocp2scp_dev;
>>>>>> + const char *oh_name, *name;
>>>>>> + struct omap_ocp2scp_platform_data *pdata;
>>>>>> +
>>>>>> + oh_name = "ocp2scp_usb_phy";
>>>>>> + name = "omap-ocp2scp";
>>>>>
>>>>> how about adding checks here to return early case we're not running on
>>>>> OMAP4 or OMAP5 ??
>>>>>
>>>>
>>>> I suppose even OMAP4-only, since OMAP5 always has DT enabled.
>>>
>>> Hmm yes, currently omap_hwmod_lookup(oh_name) produces
>>> bogus errors for other omaps as the hwmod data is only
>>> there for omap4.
>>
>> shouldn't that be fixed too ? I mean, if data isn't just return -ENODEV
>> or something similar.
>
> Yes some kind of checking is needed here.
Ok. I'll fix and send.
Thanks
Kishon
WARNING: multiple messages have this Message-ID (diff)
From: kishon@ti.com (kishon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/3] ARM: OMAP: ocp2scp: create omap device for ocp2scp
Date: Sat, 27 Oct 2012 17:59:51 +0530 [thread overview]
Message-ID: <508BD3BF.1080409@ti.com> (raw)
In-Reply-To: <20121026201631.GR11908@atomide.com>
On Saturday 27 October 2012 01:46 AM, Tony Lindgren wrote:
> * Felipe Balbi <balbi@ti.com> [121026 13:07]:
>> On Fri, Oct 26, 2012 at 10:21:41AM -0700, Tony Lindgren wrote:
>>> * Arnd Bergmann <arnd@arndb.de> [121026 00:48]:
>>>> On Friday 26 October 2012, Felipe Balbi wrote:
>>>>>> +static void omap_init_ocp2scp(void)
>>>>>> +{
>>>>>> + struct omap_hwmod *oh;
>>>>>> + struct platform_device *pdev;
>>>>>> + int bus_id = -1, dev_cnt = 0, i;
>>>>>> + struct omap_ocp2scp_dev *ocp2scp_dev;
>>>>>> + const char *oh_name, *name;
>>>>>> + struct omap_ocp2scp_platform_data *pdata;
>>>>>> +
>>>>>> + oh_name = "ocp2scp_usb_phy";
>>>>>> + name = "omap-ocp2scp";
>>>>>
>>>>> how about adding checks here to return early case we're not running on
>>>>> OMAP4 or OMAP5 ??
>>>>>
>>>>
>>>> I suppose even OMAP4-only, since OMAP5 always has DT enabled.
>>>
>>> Hmm yes, currently omap_hwmod_lookup(oh_name) produces
>>> bogus errors for other omaps as the hwmod data is only
>>> there for omap4.
>>
>> shouldn't that be fixed too ? I mean, if data isn't just return -ENODEV
>> or something similar.
>
> Yes some kind of checking is needed here.
Ok. I'll fix and send.
Thanks
Kishon
WARNING: multiple messages have this Message-ID (diff)
From: kishon <kishon@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Felipe Balbi <balbi@ti.com>, Arnd Bergmann <arnd@arndb.de>,
<linux@arm.linux.org.uk>, <b-cousson@ti.com>, <olof@lixom.net>,
<rdunlap@xenotime.net>, <linux-omap@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 3/3] ARM: OMAP: ocp2scp: create omap device for ocp2scp
Date: Sat, 27 Oct 2012 17:59:51 +0530 [thread overview]
Message-ID: <508BD3BF.1080409@ti.com> (raw)
In-Reply-To: <20121026201631.GR11908@atomide.com>
On Saturday 27 October 2012 01:46 AM, Tony Lindgren wrote:
> * Felipe Balbi <balbi@ti.com> [121026 13:07]:
>> On Fri, Oct 26, 2012 at 10:21:41AM -0700, Tony Lindgren wrote:
>>> * Arnd Bergmann <arnd@arndb.de> [121026 00:48]:
>>>> On Friday 26 October 2012, Felipe Balbi wrote:
>>>>>> +static void omap_init_ocp2scp(void)
>>>>>> +{
>>>>>> + struct omap_hwmod *oh;
>>>>>> + struct platform_device *pdev;
>>>>>> + int bus_id = -1, dev_cnt = 0, i;
>>>>>> + struct omap_ocp2scp_dev *ocp2scp_dev;
>>>>>> + const char *oh_name, *name;
>>>>>> + struct omap_ocp2scp_platform_data *pdata;
>>>>>> +
>>>>>> + oh_name = "ocp2scp_usb_phy";
>>>>>> + name = "omap-ocp2scp";
>>>>>
>>>>> how about adding checks here to return early case we're not running on
>>>>> OMAP4 or OMAP5 ??
>>>>>
>>>>
>>>> I suppose even OMAP4-only, since OMAP5 always has DT enabled.
>>>
>>> Hmm yes, currently omap_hwmod_lookup(oh_name) produces
>>> bogus errors for other omaps as the hwmod data is only
>>> there for omap4.
>>
>> shouldn't that be fixed too ? I mean, if data isn't just return -ENODEV
>> or something similar.
>
> Yes some kind of checking is needed here.
Ok. I'll fix and send.
Thanks
Kishon
next prev parent reply other threads:[~2012-10-27 12:29 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-08 5:59 [PATCH v2 0/3] ocp2scp: add non-dt support Kishon Vijay Abraham I
2012-10-08 5:59 ` Kishon Vijay Abraham I
2012-10-08 5:59 ` Kishon Vijay Abraham I
2012-10-08 5:59 ` [PATCH v2 1/3] drivers: bus: ocp2scp: add pdata support Kishon Vijay Abraham I
2012-10-08 5:59 ` Kishon Vijay Abraham I
2012-10-08 5:59 ` Kishon Vijay Abraham I
2012-10-16 16:50 ` Tony Lindgren
2012-10-16 16:50 ` Tony Lindgren
2012-10-25 0:48 ` Tony Lindgren
2012-10-25 0:48 ` Tony Lindgren
2012-10-25 6:17 ` Felipe Balbi
2012-10-25 6:17 ` Felipe Balbi
2012-10-25 6:17 ` Felipe Balbi
2012-10-25 17:44 ` Tony Lindgren
2012-10-25 17:44 ` Tony Lindgren
2012-10-26 6:47 ` Felipe Balbi
2012-10-26 6:47 ` Felipe Balbi
2012-10-26 6:47 ` Felipe Balbi
2012-10-26 17:16 ` Tony Lindgren
2012-10-26 17:16 ` Tony Lindgren
2012-10-26 19:59 ` Felipe Balbi
2012-10-26 19:59 ` Felipe Balbi
2012-10-26 19:59 ` Felipe Balbi
2012-10-27 12:27 ` kishon
2012-10-27 12:27 ` kishon
2012-10-27 12:27 ` kishon
2012-10-29 6:10 ` Felipe Balbi
2012-10-29 6:10 ` Felipe Balbi
2012-10-29 6:10 ` Felipe Balbi
2012-10-29 6:23 ` kishon
2012-10-29 6:23 ` kishon
2012-10-29 6:23 ` kishon
2012-10-26 6:48 ` Felipe Balbi
2012-10-26 6:48 ` Felipe Balbi
2012-10-26 6:48 ` Felipe Balbi
2012-10-08 5:59 ` [PATCH v2 2/3] ARM: OMAP4: add _dev_attr_ to ocp2scp for representing usb_phy Kishon Vijay Abraham I
2012-10-08 5:59 ` Kishon Vijay Abraham I
2012-10-08 5:59 ` Kishon Vijay Abraham I
2012-10-11 0:44 ` Tony Lindgren
2012-10-11 0:44 ` Tony Lindgren
2012-10-16 16:49 ` Tony Lindgren
2012-10-16 16:49 ` Tony Lindgren
2012-10-08 5:59 ` [PATCH v2 3/3] ARM: OMAP: ocp2scp: create omap device for ocp2scp Kishon Vijay Abraham I
2012-10-08 5:59 ` Kishon Vijay Abraham I
2012-10-08 5:59 ` Kishon Vijay Abraham I
2012-10-26 6:50 ` Felipe Balbi
2012-10-26 6:50 ` Felipe Balbi
2012-10-26 6:50 ` Felipe Balbi
2012-10-26 7:47 ` Arnd Bergmann
2012-10-26 7:47 ` Arnd Bergmann
2012-10-26 17:21 ` Tony Lindgren
2012-10-26 17:21 ` Tony Lindgren
2012-10-26 19:59 ` Felipe Balbi
2012-10-26 19:59 ` Felipe Balbi
2012-10-26 19:59 ` Felipe Balbi
2012-10-26 20:16 ` Tony Lindgren
2012-10-26 20:16 ` Tony Lindgren
2012-10-27 12:29 ` kishon [this message]
2012-10-27 12:29 ` kishon
2012-10-27 12:29 ` kishon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=508BD3BF.1080409@ti.com \
--to=kishon@ti.com \
--cc=arnd@arndb.de \
--cc=b-cousson@ti.com \
--cc=balbi@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=olof@lixom.net \
--cc=rdunlap@xenotime.net \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.