Regarding compat_autoconf.h generation

Regarding compat_autoconf.h generation

[Ozan Çağlayan]

Hi,

In the nouveau DRM driver there is a CONFIG_NOUVEAU_DEBUG which has to
be an integer between 0 and 7 with the default as 3.
Currently gen-compat-autoconf.sh defines this as a string by default:

           *) # Assume string
 61                 # XXX: add better checks to make sure what was on
 62                 # the right was indeed a string
 63                 echo "#ifndef $VAR"
 64                 echo "#define $VAR \"$VALUE\""
 65                 echo "#endif /* $VAR */ "
 66                 ;;

Is it OK to modify the script to allow defining integers? Also, it
seems that there is no difference with =m and =y:

              y)
 51                 echo "#ifndef $VAR"
 52                 echo "#define $VAR 1"
 53                 echo "#endif /* $VAR */ "
 54                 ;;
 55         m)
 56                 echo "#ifndef $VAR"
 57                 echo "#define $VAR 1"
 58                 echo "#endif /* $VAR */ "
 59                 ;;

How come this doesn't break things? Both =y and =m exist in config.mk.

Thanks!

-- 
Ozan Çağlayan
Research Assistant
Galatasaray University - Computer Engineering Dept.
http://www.ozancaglayan.com

Re: Regarding compat_autoconf.h generation

[Luis R. Rodriguez]

On Sat, Oct 27, 2012 at 7:25 AM, Ozan =C3=87a=C4=9Flayan <ozancag@gmail.com=
> wrote:
> Hi,
>
> In the nouveau DRM driver there is a CONFIG_NOUVEAU_DEBUG which has to
> be an integer between 0 and 7 with the default as 3.
> Currently gen-compat-autoconf.sh defines this as a string by default:
>
>            *) # Assume string
>  61                 # XXX: add better checks to make sure what was on
>  62                 # the right was indeed a string
>  63                 echo "#ifndef $VAR"
>  64                 echo "#define $VAR \"$VALUE\""
>  65                 echo "#endif /* $VAR */ "
>  66                 ;;
>
> Is it OK to modify the script to allow defining integers?

Sure :)

> Also, it
> seems that there is no difference with =3Dm and =3Dy:
>
>               y)
>  51                 echo "#ifndef $VAR"
>  52                 echo "#define $VAR 1"
>  53                 echo "#endif /* $VAR */ "
>  54                 ;;
>  55         m)
>  56                 echo "#ifndef $VAR"
>  57                 echo "#define $VAR 1"
>  58                 echo "#endif /* $VAR */ "
>  59                 ;;
>
> How come this doesn't break things?

The real magic for "y" or "m" happens via Kconfig and Makefiles, the
header file is just at compile time of C code.

> Both =3Dy and =3Dm exist in config.mk.

We try to replicate what the kernel does, but m should always be used
for modules otherwise they won't build. For an example fix see
f456f3e174c65a6f5c8e34693b7f89ad52d9b072.

  Luis

Re: Regarding compat_autoconf.h generation

[Hauke Mehrtens]

On 10/27/2012 04:25 PM, Ozan Çağlayan wrote:
> Hi,
>
> In the nouveau DRM driver there is a CONFIG_NOUVEAU_DEBUG which has to
> be an integer between 0 and 7 with the default as 3.
> Currently gen-compat-autoconf.sh defines this as a string by default:
>
>             *) # Assume string
>   61                 # XXX: add better checks to make sure what was on
>   62                 # the right was indeed a string
>   63                 echo "#ifndef $VAR"
>   64                 echo "#define $VAR \"$VALUE\""
>   65                 echo "#endif /* $VAR */ "
>   66                 ;;
>
> Is it OK to modify the script to allow defining integers? Also, it
> seems that there is no difference with =m and =y:
>
>                y)
>   51                 echo "#ifndef $VAR"
>   52                 echo "#define $VAR 1"
>   53                 echo "#endif /* $VAR */ "
>   54                 ;;
>   55         m)
>   56                 echo "#ifndef $VAR"
>   57                 echo "#define $VAR 1"
>   58                 echo "#endif /* $VAR */ "
>   59                 ;;
>
> How come this doesn't break things? Both =y and =m exist in config.mk.
>
> Thanks!
>

Hi,

are you working o making nouveau work with compat-drivers? I just 
noticed that i915 is only activated driver and I have some problems with 
my nvidia card running nouveau and wanted to try out a new version.

Hauke

Re: Regarding compat_autoconf.h generation

[Ozan Çağlayan]

> Hi,
>
> are you working o making nouveau work with compat-drivers? I just noticed
> that i915 is only activated driver and I have some problems with my nvidia
> card running nouveau and wanted to try out a new version.
>
> Hauke

Yep actually I got hit by this while trying to build nouveau. Now I
can succesfully build it but I broke up grub.cfg while adding a new
boot entry for compat-drivers trials and have to find out how to use
the uber-complicated grub2 command line...


-- 
Ozan Çağlayan
Research Assistant
Galatasaray University - Computer Engineering Dept.
http://www.ozancaglayan.com