From: Archit Taneja <archit@ti.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 19/20] OMAPDSS: DISPC: remove dssdev depependency from error handler
Date: Mon, 29 Oct 2012 10:30:30 +0000 [thread overview]
Message-ID: <508E57F6.4070207@ti.com> (raw)
In-Reply-To: <508E389C.8080503@ti.com>
On Monday 29 October 2012 01:34 PM, Tomi Valkeinen wrote:
> On 2012-10-29 09:12, Archit Taneja wrote:
>> Hi,
>>
>> On Wednesday 24 October 2012 02:59 PM, Tomi Valkeinen wrote:
>>> The dispc error handler tries to "fix" issues by disabling and enabling
>>> panel. This is problematic, as we're trying to remove the dependency
>>> from omapdss to the omap_dss_devices. It's also racy, and doesn't really
>>> fix anything.
>>>
>>> This patch removes the use of omap_dss_device from the error handler,
>>> and just disables and enables the associated overlay manager. This
>>> should produce similar results as the previous solution, without using
>>> dssdev.
>>
>> Calling APPLY functions from the DISPC driver seems a bit incorrect.
>> Instead of disabling/enabling the panel, can't we disable/enable the
>> manger by just using DISPC funcs?
>
> I agree, but if we don't call apply functions, we're bypassing the
> locks/etc from apply, and we could end up messing up what apply.c thinks
> is going on.
>
> With my omapdss+omapdrm compatibility patch series I'm moving the error
> handler to the apply mechanism, so it becomes a bit saner.
Okay. Having the error handler in apply would make things better.
Archit
WARNING: multiple messages have this Message-ID (diff)
From: Archit Taneja <archit@ti.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 19/20] OMAPDSS: DISPC: remove dssdev depependency from error handler
Date: Mon, 29 Oct 2012 15:48:30 +0530 [thread overview]
Message-ID: <508E57F6.4070207@ti.com> (raw)
In-Reply-To: <508E389C.8080503@ti.com>
On Monday 29 October 2012 01:34 PM, Tomi Valkeinen wrote:
> On 2012-10-29 09:12, Archit Taneja wrote:
>> Hi,
>>
>> On Wednesday 24 October 2012 02:59 PM, Tomi Valkeinen wrote:
>>> The dispc error handler tries to "fix" issues by disabling and enabling
>>> panel. This is problematic, as we're trying to remove the dependency
>>> from omapdss to the omap_dss_devices. It's also racy, and doesn't really
>>> fix anything.
>>>
>>> This patch removes the use of omap_dss_device from the error handler,
>>> and just disables and enables the associated overlay manager. This
>>> should produce similar results as the previous solution, without using
>>> dssdev.
>>
>> Calling APPLY functions from the DISPC driver seems a bit incorrect.
>> Instead of disabling/enabling the panel, can't we disable/enable the
>> manger by just using DISPC funcs?
>
> I agree, but if we don't call apply functions, we're bypassing the
> locks/etc from apply, and we could end up messing up what apply.c thinks
> is going on.
>
> With my omapdss+omapdrm compatibility patch series I'm moving the error
> handler to the apply mechanism, so it becomes a bit saner.
Okay. Having the error handler in apply would make things better.
Archit
next prev parent reply other threads:[~2012-10-29 10:30 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-24 9:28 [PATCH 00/20] OMAPDSS: Misc cleanups/fixes Tomi Valkeinen
2012-10-24 9:28 ` Tomi Valkeinen
2012-10-24 9:28 ` [PATCH 01/20] OMAPDSS: remove omap_dss_device's suspend/resume Tomi Valkeinen
2012-10-24 9:28 ` Tomi Valkeinen
2012-10-24 9:28 ` [PATCH 02/20] OMAPDSS: get the dss version from core pdev Tomi Valkeinen
2012-10-24 9:28 ` Tomi Valkeinen
2012-10-24 9:28 ` [PATCH 03/20] OMAPDSS: remove dispc_irq_handler declaration Tomi Valkeinen
2012-10-24 9:28 ` Tomi Valkeinen
2012-10-24 9:28 ` [PATCH 04/20] OMAPDSS: DISPC: fix dispc_mgr_lclk_rate for DIGIT output Tomi Valkeinen
2012-10-24 9:28 ` Tomi Valkeinen
2012-10-29 9:50 ` Archit Taneja
2012-10-29 9:50 ` Archit Taneja
2012-10-29 9:56 ` Tomi Valkeinen
2012-10-29 9:56 ` Tomi Valkeinen
2012-10-24 9:28 ` [PATCH 05/20] OMAPDSS: remove initial display code from omapdss Tomi Valkeinen
2012-10-24 9:28 ` Tomi Valkeinen
2012-10-29 10:04 ` Archit Taneja
2012-10-29 10:16 ` Archit Taneja
2012-10-29 10:25 ` Tomi Valkeinen
2012-10-29 10:25 ` Tomi Valkeinen
2012-10-29 10:36 ` Archit Taneja
2012-10-29 10:48 ` Archit Taneja
2012-10-24 9:28 ` [PATCH 06/20] OMAPDSS: DISPC: use dss_feat_get_num_ovls() Tomi Valkeinen
2012-10-24 9:28 ` Tomi Valkeinen
2012-10-24 9:28 ` [PATCH 07/20] OMAPDSS: DISPC: rename dispc_mgr_enable/disable to _sync Tomi Valkeinen
2012-10-24 9:28 ` Tomi Valkeinen
2012-10-24 9:28 ` [PATCH 08/20] OMAPDSS: DISPC: make _enable_mgr_out public as "dispc_mgr_enable" Tomi Valkeinen
2012-10-24 9:28 ` Tomi Valkeinen
2012-10-24 9:29 ` [PATCH 09/20] OMAPDSS: add dispc_ovl_enabled() Tomi Valkeinen
2012-10-24 9:29 ` Tomi Valkeinen
2012-10-29 10:09 ` Archit Taneja
2012-10-29 10:21 ` Archit Taneja
2012-10-29 10:28 ` Tomi Valkeinen
2012-10-29 10:28 ` Tomi Valkeinen
2012-10-24 9:29 ` [PATCH 10/20] OMAPDSS: DISPC: Add IRQ enable/status helpers Tomi Valkeinen
2012-10-24 9:29 ` Tomi Valkeinen
2012-10-24 9:29 ` [PATCH 11/20] OMAPDSS: HDMI: split power_on/off to two parts Tomi Valkeinen
2012-10-24 9:29 ` Tomi Valkeinen
2012-10-29 10:14 ` Archit Taneja
2012-10-29 10:26 ` Archit Taneja
2012-10-29 10:30 ` Tomi Valkeinen
2012-10-29 10:30 ` Tomi Valkeinen
2012-10-24 9:29 ` [PATCH 12/20] OMAPDSS: HDMI: use core power on/off with edid & detect Tomi Valkeinen
2012-10-24 9:29 ` Tomi Valkeinen
2012-10-24 9:29 ` [PATCH 13/20] OMAPDSS: HDMI: add 1920x1200 video mode Tomi Valkeinen
2012-10-24 9:29 ` Tomi Valkeinen
2012-10-24 9:29 ` [PATCH 14/20] OMAPDSS: HDMI: make hdmi pclk check more permissive Tomi Valkeinen
2012-10-24 9:29 ` Tomi Valkeinen
2012-10-24 9:29 ` [PATCH 15/20] OMAPFB: remove use of extended edid block Tomi Valkeinen
2012-10-24 9:29 ` Tomi Valkeinen
2012-10-24 9:29 ` [PATCH 16/20] OMAPFB: improve mode selection from EDID Tomi Valkeinen
2012-10-24 9:29 ` Tomi Valkeinen
2012-10-24 9:29 ` [PATCH 17/20] OMAPDSS: fix DSI2 PLL clk names Tomi Valkeinen
2012-10-24 9:29 ` Tomi Valkeinen
2012-10-24 9:29 ` [PATCH 18/20] OMAPDSS: DISPC: fix loop in error handler Tomi Valkeinen
2012-10-24 9:29 ` Tomi Valkeinen
2012-10-24 9:29 ` [PATCH 19/20] OMAPDSS: DISPC: remove dssdev depependency from " Tomi Valkeinen
2012-10-24 9:29 ` Tomi Valkeinen
2012-10-29 7:12 ` Archit Taneja
2012-10-29 7:24 ` Archit Taneja
2012-10-29 8:04 ` Tomi Valkeinen
2012-10-29 8:04 ` Tomi Valkeinen
2012-10-29 10:18 ` Archit Taneja [this message]
2012-10-29 10:30 ` Archit Taneja
2012-10-24 9:29 ` [PATCH 20/20] OMAPDSS: split hdmi muxing function Tomi Valkeinen
2012-10-24 9:29 ` Tomi Valkeinen
2012-10-24 16:23 ` Tony Lindgren
2012-10-24 16:23 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=508E57F6.4070207@ti.com \
--to=archit@ti.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.