From: Kukjin Kim <kgene.kim@samsung.com>
To: Amit Daniel Kachhap <amit.daniel@samsung.com>
Cc: kgene.kim@samsung.com, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, amit.kachhap@linaro.org
Subject: Re: [PATCH v2 1/2] ARM: exynos4: Add devicetree node for TMU driver
Date: Mon, 29 Oct 2012 21:22:22 +0900 [thread overview]
Message-ID: <508E74FE.7090900@samsung.com> (raw)
In-Reply-To: <1351243746-4173-2-git-send-email-amit.daniel@samsung.com>
On 10/26/12 18:29, Amit Daniel Kachhap wrote:
> From: Amit Daniel Kachhap<amit.daniel@samsung.com>
>
> This patch adds necessary source definations needed for TMU driver and
> adds devicetree node for exynos4210.
>
> Signed-off-by: Amit Daniel Kachhap<amit.daniel@samsung.com>
> ---
[...]
> + .name = "tmu_apbif",
> + .enable = exynos4_clk_ip_perir_ctrl,
> + .ctrlbit = (1<< 17),
tab instead of white spaces?
I fixed them when I applied.
[...]
> +#define EXYNOS4_IRQ_TMU_TRIG0 COMBINER_IRQ(2, 4)
> +#define EXYNOS4_IRQ_TMU_TRIG1 COMBINER_IRQ(3, 4)
BTW, where are above definitions used?
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
WARNING: multiple messages have this Message-ID (diff)
From: kgene.kim@samsung.com (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/2] ARM: exynos4: Add devicetree node for TMU driver
Date: Mon, 29 Oct 2012 21:22:22 +0900 [thread overview]
Message-ID: <508E74FE.7090900@samsung.com> (raw)
In-Reply-To: <1351243746-4173-2-git-send-email-amit.daniel@samsung.com>
On 10/26/12 18:29, Amit Daniel Kachhap wrote:
> From: Amit Daniel Kachhap<amit.daniel@samsung.com>
>
> This patch adds necessary source definations needed for TMU driver and
> adds devicetree node for exynos4210.
>
> Signed-off-by: Amit Daniel Kachhap<amit.daniel@samsung.com>
> ---
[...]
> + .name = "tmu_apbif",
> + .enable = exynos4_clk_ip_perir_ctrl,
> + .ctrlbit = (1<< 17),
tab instead of white spaces?
I fixed them when I applied.
[...]
> +#define EXYNOS4_IRQ_TMU_TRIG0 COMBINER_IRQ(2, 4)
> +#define EXYNOS4_IRQ_TMU_TRIG1 COMBINER_IRQ(3, 4)
BTW, where are above definitions used?
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
next prev parent reply other threads:[~2012-10-29 15:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-26 9:29 [PATCH v2 0/2] ARM: exynos: Enable TMU support in exynos platforms Amit Daniel Kachhap
2012-10-26 9:29 ` Amit Daniel Kachhap
2012-10-26 9:29 ` [PATCH v2 1/2] ARM: exynos4: Add devicetree node for TMU driver Amit Daniel Kachhap
2012-10-26 9:29 ` Amit Daniel Kachhap
2012-10-26 9:29 ` [PATCH v2 2/2] ARM: exynos5: " Amit Daniel Kachhap
2012-10-26 9:29 ` Amit Daniel Kachhap
2012-10-29 12:22 ` Kukjin Kim [this message]
2012-10-29 12:22 ` [PATCH v2 1/2] ARM: exynos4: " Kukjin Kim
2012-10-30 5:53 ` Amit Daniel Kachhap
2012-10-30 5:53 ` Amit Daniel Kachhap
2012-10-29 12:14 ` [PATCH v2 0/2] ARM: exynos: Enable TMU support in exynos platforms Kukjin Kim
2012-10-29 12:14 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=508E74FE.7090900@samsung.com \
--to=kgene.kim@samsung.com \
--cc=amit.daniel@samsung.com \
--cc=amit.kachhap@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.