From: Jan Kiszka <jan.kiszka@siemens.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 3/3] slirp: remove unused function u_sleep
Date: Tue, 30 Oct 2012 09:31:54 +0100 [thread overview]
Message-ID: <508F907A.2080107@siemens.com> (raw)
In-Reply-To: <20646c072ced410321c404397f1ff8afb8051930.1351427134.git.blauwirbel@gmail.com>
On 2012-10-28 13:26, Blue Swirl wrote:
> Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
> ---
> slirp/misc.c | 14 --------------
> slirp/misc.h | 1 -
> 2 files changed, 0 insertions(+), 15 deletions(-)
>
> diff --git a/slirp/misc.c b/slirp/misc.c
> index 0bee864..664532a 100644
> --- a/slirp/misc.c
> +++ b/slirp/misc.c
> @@ -253,20 +253,6 @@ void lprint(const char *format, ...)
> va_end(args);
> }
>
> -void
> -u_sleep(int usec)
> -{
> - struct timeval t;
> - fd_set fdset;
> -
> - FD_ZERO(&fdset);
> -
> - t.tv_sec = 0;
> - t.tv_usec = usec * 1000;
> -
> - select(0, &fdset, &fdset, &fdset, &t);
> -}
> -
> void slirp_connection_info(Slirp *slirp, Monitor *mon)
> {
> const char * const tcpstates[] = {
> diff --git a/slirp/misc.h b/slirp/misc.h
> index ed40a10..cc36aeb 100644
> --- a/slirp/misc.h
> +++ b/slirp/misc.h
> @@ -64,7 +64,6 @@ void snooze_hup(int);
> void snooze(void);
> void relay(int);
> void add_emu(char *);
> -void u_sleep(int);
> void fd_nonblock(int);
> void fd_block(int);
> int rsh_exec(struct socket *, struct socket *, char *, char *, char *);
>
It's obviously fine. But wasn't it already merged or accepted for
trivial? Of course, I can take it otherwise.
Jan
--
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2012-10-30 8:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-28 12:26 [Qemu-devel] [PATCH 0/3] remove unused functions Blue Swirl
2012-10-28 12:26 ` [Qemu-devel] [PATCH 1/3] m48t59: remove unused m48t59_set_addr Blue Swirl
2012-10-28 12:26 ` [Qemu-devel] [PATCH 2/3] sun4c: remove unused functions Blue Swirl
2012-10-28 12:26 ` [Qemu-devel] [PATCH 3/3] slirp: remove unused function u_sleep Blue Swirl
2012-10-30 8:31 ` Jan Kiszka [this message]
2012-10-30 19:03 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=508F907A.2080107@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.