From: Glauber Costa <glommer@parallels.com>
To: Christoph Lameter <cl@linux.com>
Cc: andi@firstfloor.org, Pekka Enberg <penberg@kernel.org>,
linux-mm@kvack.org, JoonSoo Kim <js1304@gmail.com>,
linux-kernel@vger.kernel.org,
David Rientjes <rientjes@google.com>
Subject: Re: [PATCH v2 1/2] kmem_cache: include allocators code directly into slab_common
Date: Tue, 30 Oct 2012 19:35:36 +0400 [thread overview]
Message-ID: <508FF3C8.3070305@parallels.com> (raw)
In-Reply-To: <0000013ab24cd7ac-1c5345d6-5fea-4459-942e-b6deccd1a6f1-000000@email.amazonses.com>
On 10/30/2012 07:31 PM, Christoph Lameter wrote:
> On Fri, 26 Oct 2012, JoonSoo Kim wrote:
>
>> 2012/10/25 Christoph Lameter <cl@linux.com>:
>>> On Wed, 24 Oct 2012, Pekka Enberg wrote:
>>>
>>>> So I hate this patch with a passion. We don't have any fastpaths in
>>>> mm/slab_common.c nor should we. Those should be allocator specific.
>>>
>>> I have similar thoughts on the issue. Lets keep the fast paths allocator
>>> specific until we find a better way to handle this issue.
>>
>> Okay. I see.
>> How about applying LTO not to the whole kernel code, but just to
>> slab_common.o + sl[aou]b.o?
>> I think that it may be possible, isn't it?
>
> Well.... Andi: Is that possible?
>
FYI: In the next version of my series, there is a patch that puts
the common code in an inline function in mm/slab.h. Then the allocators
just call that function.
I think it is the best we can do for now, given all the constraints.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Glauber Costa <glommer@parallels.com>
To: Christoph Lameter <cl@linux.com>
Cc: <andi@firstfloor.org>, Pekka Enberg <penberg@kernel.org>,
<linux-mm@kvack.org>, JoonSoo Kim <js1304@gmail.com>,
<linux-kernel@vger.kernel.org>,
David Rientjes <rientjes@google.com>
Subject: Re: [PATCH v2 1/2] kmem_cache: include allocators code directly into slab_common
Date: Tue, 30 Oct 2012 19:35:36 +0400 [thread overview]
Message-ID: <508FF3C8.3070305@parallels.com> (raw)
In-Reply-To: <0000013ab24cd7ac-1c5345d6-5fea-4459-942e-b6deccd1a6f1-000000@email.amazonses.com>
On 10/30/2012 07:31 PM, Christoph Lameter wrote:
> On Fri, 26 Oct 2012, JoonSoo Kim wrote:
>
>> 2012/10/25 Christoph Lameter <cl@linux.com>:
>>> On Wed, 24 Oct 2012, Pekka Enberg wrote:
>>>
>>>> So I hate this patch with a passion. We don't have any fastpaths in
>>>> mm/slab_common.c nor should we. Those should be allocator specific.
>>>
>>> I have similar thoughts on the issue. Lets keep the fast paths allocator
>>> specific until we find a better way to handle this issue.
>>
>> Okay. I see.
>> How about applying LTO not to the whole kernel code, but just to
>> slab_common.o + sl[aou]b.o?
>> I think that it may be possible, isn't it?
>
> Well.... Andi: Is that possible?
>
FYI: In the next version of my series, there is a patch that puts
the common code in an inline function in mm/slab.h. Then the allocators
just call that function.
I think it is the best we can do for now, given all the constraints.
next prev parent reply other threads:[~2012-10-30 15:35 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-24 13:59 [PATCH v2 0/2] common entry point for kmem_cache_free Glauber Costa
2012-10-24 13:59 ` Glauber Costa
2012-10-24 13:59 ` [PATCH v2 1/2] kmem_cache: include allocators code directly into slab_common Glauber Costa
2012-10-24 13:59 ` Glauber Costa
2012-10-24 14:29 ` Christoph Lameter
2012-10-24 14:29 ` Christoph Lameter
2012-10-24 14:35 ` Glauber Costa
2012-10-24 14:35 ` Glauber Costa
2012-10-24 17:29 ` JoonSoo Kim
2012-10-24 17:29 ` JoonSoo Kim
2012-10-24 15:33 ` Andi Kleen
2012-10-24 15:33 ` Andi Kleen
2012-10-24 18:02 ` Pekka Enberg
2012-10-24 18:02 ` Pekka Enberg
2012-10-24 19:34 ` Christoph Lameter
2012-10-24 19:34 ` Christoph Lameter
2012-10-26 14:15 ` JoonSoo Kim
2012-10-26 14:15 ` JoonSoo Kim
2012-10-30 15:31 ` Christoph Lameter
2012-10-30 15:31 ` Christoph Lameter
2012-10-30 15:35 ` Glauber Costa [this message]
2012-10-30 15:35 ` Glauber Costa
2012-10-30 20:27 ` Andi Kleen
2012-10-30 20:27 ` Andi Kleen
2012-10-24 13:59 ` [PATCH v2 2/2] slab: move kmem_cache_free to common code Glauber Costa
2012-10-24 13:59 ` Glauber Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=508FF3C8.3070305@parallels.com \
--to=glommer@parallels.com \
--cc=andi@firstfloor.org \
--cc=cl@linux.com \
--cc=js1304@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.