From: Jan Kiszka <jan.kiszka@web.de>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, Marcelo Tosatti <mtosatti@redhat.com>,
Avi Kivity <avi@redhat.com>,
kvm@vger.kernel.org, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH] update-linux-headers.sh: Handle new kernel uapi/ directories
Date: Tue, 30 Oct 2012 19:33:16 +0100 [thread overview]
Message-ID: <50901D6C.4010109@web.de> (raw)
In-Reply-To: <CAFEAcA_ULJ-pA9qGe4VKkfrBF-AyOG8Sj_P6-jjOGRGmfr8zTw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1527 bytes --]
On 2012-10-30 10:48, Peter Maydell wrote:
> Ping?
>
> (patchwork url http://patchwork.ozlabs.org/patch/193125/)
Should obviously go in soon.
Jan
>
> thanks
> -- PMM
>
> On 22 October 2012 13:54, Peter Maydell <peter.maydell@linaro.org> wrote:
>> Recent kernels have moved to keeping the userspace headers
>> in uapi/ subdirectories. This breaks the detection of whether an
>> architecture has KVM support in the kernel because kvm.h has
>> moved in the kernel source tree. Update the check to support
>> both the old and new locations.
>>
>> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>> ---
>> This would otherwise cause us to ignore the architectures which
>> have moved over to uapi/ (which for QEMU's purposes means "everything
>> but x86"...)
>>
>> scripts/update-linux-headers.sh | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/scripts/update-linux-headers.sh b/scripts/update-linux-headers.sh
>> index 67be2ef..4c7b566 100755
>> --- a/scripts/update-linux-headers.sh
>> +++ b/scripts/update-linux-headers.sh
>> @@ -34,7 +34,8 @@ ARCHLIST=$(cd "$linux/arch" && echo *)
>>
>> for arch in $ARCHLIST; do
>> # Discard anything which isn't a KVM-supporting architecture
>> - if ! [ -e "$linux/arch/$arch/include/asm/kvm.h" ]; then
>> + if ! [ -e "$linux/arch/$arch/include/asm/kvm.h" ] &&
>> + ! [ -e "$linux/arch/$arch/include/uapi/asm/kvm.h" ] ; then
>> continue
>> fi
>>
>> --
>> 1.7.9.5
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Jan Kiszka <jan.kiszka@web.de>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: patches@linaro.org, Marcelo Tosatti <mtosatti@redhat.com>,
qemu-devel@nongnu.org, kvm@vger.kernel.org,
Avi Kivity <avi@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] update-linux-headers.sh: Handle new kernel uapi/ directories
Date: Tue, 30 Oct 2012 19:33:16 +0100 [thread overview]
Message-ID: <50901D6C.4010109@web.de> (raw)
In-Reply-To: <CAFEAcA_ULJ-pA9qGe4VKkfrBF-AyOG8Sj_P6-jjOGRGmfr8zTw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1527 bytes --]
On 2012-10-30 10:48, Peter Maydell wrote:
> Ping?
>
> (patchwork url http://patchwork.ozlabs.org/patch/193125/)
Should obviously go in soon.
Jan
>
> thanks
> -- PMM
>
> On 22 October 2012 13:54, Peter Maydell <peter.maydell@linaro.org> wrote:
>> Recent kernels have moved to keeping the userspace headers
>> in uapi/ subdirectories. This breaks the detection of whether an
>> architecture has KVM support in the kernel because kvm.h has
>> moved in the kernel source tree. Update the check to support
>> both the old and new locations.
>>
>> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>> ---
>> This would otherwise cause us to ignore the architectures which
>> have moved over to uapi/ (which for QEMU's purposes means "everything
>> but x86"...)
>>
>> scripts/update-linux-headers.sh | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/scripts/update-linux-headers.sh b/scripts/update-linux-headers.sh
>> index 67be2ef..4c7b566 100755
>> --- a/scripts/update-linux-headers.sh
>> +++ b/scripts/update-linux-headers.sh
>> @@ -34,7 +34,8 @@ ARCHLIST=$(cd "$linux/arch" && echo *)
>>
>> for arch in $ARCHLIST; do
>> # Discard anything which isn't a KVM-supporting architecture
>> - if ! [ -e "$linux/arch/$arch/include/asm/kvm.h" ]; then
>> + if ! [ -e "$linux/arch/$arch/include/asm/kvm.h" ] &&
>> + ! [ -e "$linux/arch/$arch/include/uapi/asm/kvm.h" ] ; then
>> continue
>> fi
>>
>> --
>> 1.7.9.5
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
next prev parent reply other threads:[~2012-10-30 18:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-22 11:54 [PATCH] update-linux-headers.sh: Handle new kernel uapi/ directories Peter Maydell
2012-10-22 11:54 ` [Qemu-devel] " Peter Maydell
2012-10-30 9:48 ` Peter Maydell
2012-10-30 18:33 ` Jan Kiszka [this message]
2012-10-30 18:33 ` Jan Kiszka
2012-10-31 0:49 ` Marcelo Tosatti
2012-10-31 0:49 ` [Qemu-devel] " Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50901D6C.4010109@web.de \
--to=jan.kiszka@web.de \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.