From: David Daney <ddaney.cavm@gmail.com>
To: Sanjay Lal <sanjayl@kymasys.com>
Cc: kvm@vger.kernel.org, linux-mips@linux-mips.org
Subject: Re: [PATCH 12/20] KVM/MIPS32: Routines to handle specific traps/exceptions while executing the guest.
Date: Wed, 31 Oct 2012 11:16:27 -0700 [thread overview]
Message-ID: <50916AFB.1040903@gmail.com> (raw)
In-Reply-To: <DD56E216-2017-45D0-9623-62E27F56CA58@kymasys.com>
On 10/31/2012 08:20 AM, Sanjay Lal wrote:
> Signed-off-by: Sanjay Lal <sanjayl@kymasys.com>
> ---
> arch/mips/kvm/kvm_cb.c | 16 ++
> arch/mips/kvm/kvm_trap_emul.c | 446 ++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 462 insertions(+)
> create mode 100644 arch/mips/kvm/kvm_cb.c
> create mode 100644 arch/mips/kvm/kvm_trap_emul.c
>
At a minimum you should probably follow Documentation/CodingStyle
Running checkpatch.pl on all the patches and fixing obvious problems is
always a good idea.
> diff --git a/arch/mips/kvm/kvm_cb.c b/arch/mips/kvm/kvm_cb.c
> new file mode 100644
> index 0000000..768198e
> --- /dev/null
> +++ b/arch/mips/kvm/kvm_cb.c
> @@ -0,0 +1,16 @@
> +/*
> +* This file is subject to the terms and conditions of the GNU General Public
> +* License. See the file "COPYING" in the main directory of this archive
> +* for more details.
> +*
> +* PUT YOUR TITLE AND/OR INFORMATION FOR THE FILE HERE
That line can probably be safely removed.
> +*
> +* Copyright (C) 2012 MIPS Technologies, Inc. All rights reserved.
> +* Authors: Yann Le Du <ledu@kymasys.com>
> +*/
.
.
.
David Daney
prev parent reply other threads:[~2012-10-31 18:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-31 15:20 [PATCH 12/20] KVM/MIPS32: Routines to handle specific traps/exceptions while executing the guest Sanjay Lal
2012-10-31 18:16 ` David Daney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50916AFB.1040903@gmail.com \
--to=ddaney.cavm@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=sanjayl@kymasys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.