* PATCH: Remove redundant #ifdef check in arch/x86/kernel/apic/bigsmp_32.c
@ 2012-11-01 18:06 Sarah Nadi
0 siblings, 0 replies; only message in thread
From: Sarah Nadi @ 2012-11-01 18:06 UTC (permalink / raw)
To: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, x86
Cc: mst, daniel, sp, linux-kernel
From: Sarah Nadi <snadi@uwaterloo.ca>
Based on v3.5-rc1, #ifdef check in arch/x86/kernel/apic/bigsmp_32.c is
redundant as SMP will always be selected for the file to compile any
ways (file compiles when X86_BIGSMP is selected, and X86_BIGSMP depends
on SMP). The first block is always selected, and #else code block is
therefore always dead. See patch below.
--- linux/arch/x86/kernel/apic/bigsmp_32.c.orig 2012-11-01
13:53:24.781158327 -0400
+++ linux/arch/x86/kernel/apic/bigsmp_32.c 2012-11-01
13:54:39.501438248 -0400
@@ -28,11 +28,7 @@ static int bigsmp_apic_id_registered(voi
static const struct cpumask *bigsmp_target_cpus(void)
{
-#ifdef CONFIG_SMP
return cpu_online_mask;
-#else
- return cpumask_of(0);
-#endif
}
static unsigned long bigsmp_check_apicid_used(physid_mask_t *map, int
apicid)
Signed-off-by: Sarah Nadi <snadi@uwaterloo.ca>
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2012-11-01 18:20 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-01 18:06 PATCH: Remove redundant #ifdef check in arch/x86/kernel/apic/bigsmp_32.c Sarah Nadi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.