Re: [RFC PATCH 4/6] ARM: OMAP: SmartReflex: provide SoC integration API for VP

[Kevin Hilman <khilman@deeprootsystems.com>]

On 10/23/2012 10:43 PM, Nishanth Menon wrote:
> SoC integration of SmartReflex AVS block is varied. Some use
> Voltage Processor for a hardware loop in certain OMAP SoC (called
> hardware loop), while others have just the AVS block without
> hardware loop automatic calibration mechanism for AVS block
> to talk through. So provide the Voltage Processor API
> to allow for SmartReflex class drivers to use the same.
>
> NOTE: SmartReflex class 3 mode of operation mandates VP APIs
> so, refuse to enable AVS driver if corresponding APIs are
> not available.
>
> As part of this change, remove the inclusion of voltage.h
> which is no longer needed as smartreflex.h includes
> linux/platform_data/voltage-omap.h which contain relevant
> definitions used here.
>
> Signed-off-by: Nishanth Menon <nm@ti.com>

[...]

> @@ -23,15 +22,26 @@ static int sr_class3_enable(struct omap_sr *sr)
>   				__func__, sr->name);
>   		return -ENODATA;
>   	}
> +	if (!sr->soc_ops.vp_enable) {
> +		pr_warn("%s: no VP enable available.Cannot enable %s!!\n",

nit: add space after '.'

There's a couple of these in the patch.

Kevin