From: Kevin Hilman <khilman@deeprootsystems.com>
To: Nishanth Menon <nm@ti.com>
Cc: Jean Pihet <jean.pihet@newoldbits.com>,
l-o <linux-omap@vger.kernel.org>, Jean Pihet <j-pihet@ti.com>,
J Keerthy <j-keerthy@ti.com>
Subject: Re: [RFC PATCH 0/6] ARM: OMAP3+: move smartreflex-class3.c to drivers/power/avs
Date: Sat, 03 Nov 2012 13:14:41 +0000 [thread overview]
Message-ID: <509518C1.5090204@deeprootsystems.com> (raw)
In-Reply-To: <CAORVsuV9tLQCf+higF4kj4dz==T5Ja6Z++s2byDmUjdNsZTC5A@mail.gmail.com>
Hi Nishanth,
On 10/25/2012 09:21 AM, Jean Pihet wrote:
> Hi Nishant,
>
> On Tue, Oct 23, 2012 at 11:43 PM, Nishanth Menon <nm@ti.com> wrote:
>> smartreflex.c now resides in drivers/power/avs directory, but class driver
>> is in mach-omap2. High time we move it off to drivers/power/avs.
> Great to see the SR fully moved to drivers/.
>
> After review of the code I am OK with the changes besides remarks sent
> on the patches:
> Acked-by: Jean Pihet <j-pihet@ti.com>
>
> I let Kevin comment on the VC/VP aspect though.
>
This move looks good to me. Thanks!
Just had one nit, but after that. Feel free to post without the RFC,
and be sure to
include Rafael and linux-pm since it's moving to drivers/power. I'll
then queue it
up for Rafael for v3.8.
Thanks,
Kevin
next prev parent reply other threads:[~2012-11-03 13:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-23 21:43 [RFC PATCH 0/6] ARM: OMAP3+: move smartreflex-class3.c to drivers/power/avs Nishanth Menon
2012-10-23 21:43 ` [RFC PATCH 1/6] PM / AVS / OMAP: move Kconfig definition of smartreflex to avs directory Nishanth Menon
2012-10-23 21:43 ` [RFC PATCH 2/6] ARM: OMAP: voltage: remove duplicate header definitions Nishanth Menon
2012-10-23 21:43 ` [RFC PATCH 3/6] ARM: OMAP: voltage: move voltdm_reset to platform_data header Nishanth Menon
2012-10-23 21:43 ` [RFC PATCH 4/6] ARM: OMAP: SmartReflex: provide SoC integration API for VP Nishanth Menon
2012-10-25 8:27 ` Jean Pihet
2012-10-25 12:55 ` Nishanth Menon
2012-11-03 13:10 ` Kevin Hilman
2012-10-23 21:44 ` [RFC PATCH 5/6] ARM: OMAP: SmartReflex: use pr_warn instead of pr_warning Nishanth Menon
2012-10-23 21:44 ` [RFC PATCH 6/6] PM / AVS / OMAP: move Smartreflex-class3 driver to power/avs Nishanth Menon
2012-10-25 8:21 ` [RFC PATCH 0/6] ARM: OMAP3+: move smartreflex-class3.c to drivers/power/avs Jean Pihet
2012-11-03 13:14 ` Kevin Hilman [this message]
2012-11-03 14:44 ` Jean Pihet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=509518C1.5090204@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=j-keerthy@ti.com \
--cc=j-pihet@ti.com \
--cc=jean.pihet@newoldbits.com \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.