From: Tamizh chelvam <tamizhchelvam@codeaurora.org>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: c_traja@qti.qualcomm.com, linux-wireless@vger.kernel.org,
kbuild-all@01.org, ath10k@lists.infradead.org
Subject: Re: [PATCH 2/4] ath10k: Add support to update btcoex priority value via nl80211
Date: Thu, 10 Nov 2016 11:57:54 +0530 [thread overview]
Message-ID: <5099054e6f8d4ea605d4af2f303ed31d@codeaurora.org> (raw)
In-Reply-To: <alpine.DEB.2.20.1611092149120.2206@hadrien>
On 2016-11-10 02:20, Julia Lawall wrote:
> It seems possible that one might like to release the mutex lock before
> the
> return on line 7556.
>
yes mutex lock needs to release. I will send a v2 patch with the change.
> julia
>
>
>
> On Wed, 9 Nov 2016, kbuild test robot wrote:
>
>> Hi Tamizh,
>>
>> [auto build test WARNING on ath6kl/ath-next]
>> [cannot apply to v4.9-rc4 next-20161108]
>> [if your patch is applied to the wrong git tree, please drop us a note
>> to help improve the system]
>>
>> url:
>> https://github.com/0day-ci/linux/commits/c_traja-qti-qualcomm-com/ath10k-Add-support-for-BTCOEX-feature/20161109-043718
>> base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git
>> ath-next
>> :::::: branch date: 2 hours ago
>> :::::: commit date: 2 hours ago
>>
>> >> drivers/net/wireless/ath/ath10k/mac.c:7556:2-8: preceding lock on line 7545
>>
>> git remote add linux-review https://github.com/0day-ci/linux
>> git remote update linux-review
>> git checkout 2fc922b27f111b9e8089a3e94a17ee827e769c55
>> vim +7556 drivers/net/wireless/ath/ath10k/mac.c
>>
>> 2fc922b2 Tamizh chelvam 2016-11-08 7539
>> 2fc922b2 Tamizh chelvam 2016-11-08 7540 if
>> (!(test_bit(ATH10K_FLAG_BTCOEX, &ar->dev_flags))) {
>> 2fc922b2 Tamizh chelvam 2016-11-08 7541 ret = -EINVAL;
>> 2fc922b2 Tamizh chelvam 2016-11-08 7542 goto exit;
>> 2fc922b2 Tamizh chelvam 2016-11-08 7543 }
>> 2fc922b2 Tamizh chelvam 2016-11-08 7544
>> 2fc922b2 Tamizh chelvam 2016-11-08 @7545
>> mutex_lock(&ar->conf_mutex);
>> 2fc922b2 Tamizh chelvam 2016-11-08 7546
>> 2fc922b2 Tamizh chelvam 2016-11-08 7547 if (ar->state !=
>> ATH10K_STATE_ON &&
>> 2fc922b2 Tamizh chelvam 2016-11-08 7548 ar->state !=
>> ATH10K_STATE_RESTARTED) {
>> 2fc922b2 Tamizh chelvam 2016-11-08 7549 ret = -ENETDOWN;
>> 2fc922b2 Tamizh chelvam 2016-11-08 7550 goto exit;
>> 2fc922b2 Tamizh chelvam 2016-11-08 7551 }
>> 2fc922b2 Tamizh chelvam 2016-11-08 7552
>> 2fc922b2 Tamizh chelvam 2016-11-08 7553 btcoex_prio =
>> ath10k_mac_get_btcoex_prio(btcoex_priority);
>> 2fc922b2 Tamizh chelvam 2016-11-08 7554
>> 2fc922b2 Tamizh chelvam 2016-11-08 7555 if (btcoex_prio > 0x3f)
>> 2fc922b2 Tamizh chelvam 2016-11-08 @7556 return -E2BIG;
>> 2fc922b2 Tamizh chelvam 2016-11-08 7557
>> 2fc922b2 Tamizh chelvam 2016-11-08 7558 ret =
>> ath10k_wmi_set_coex_param(ar, btcoex_prio);
>> 2fc922b2 Tamizh chelvam 2016-11-08 7559
>>
>> ---
>> 0-DAY kernel test infrastructure Open Source Technology
>> Center
>> https://lists.01.org/pipermail/kbuild-all Intel
>> Corporation
>>
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Tamizh chelvam <tamizhchelvam@codeaurora.org>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: c_traja@qti.qualcomm.com, ath10k@lists.infradead.org,
linux-wireless@vger.kernel.org, kbuild-all@01.org
Subject: Re: [PATCH 2/4] ath10k: Add support to update btcoex priority value via nl80211
Date: Thu, 10 Nov 2016 11:57:54 +0530 [thread overview]
Message-ID: <5099054e6f8d4ea605d4af2f303ed31d@codeaurora.org> (raw)
In-Reply-To: <alpine.DEB.2.20.1611092149120.2206@hadrien>
On 2016-11-10 02:20, Julia Lawall wrote:
> It seems possible that one might like to release the mutex lock before
> the
> return on line 7556.
>
yes mutex lock needs to release. I will send a v2 patch with the change.
> julia
>
>
>
> On Wed, 9 Nov 2016, kbuild test robot wrote:
>
>> Hi Tamizh,
>>
>> [auto build test WARNING on ath6kl/ath-next]
>> [cannot apply to v4.9-rc4 next-20161108]
>> [if your patch is applied to the wrong git tree, please drop us a note
>> to help improve the system]
>>
>> url:
>> https://github.com/0day-ci/linux/commits/c_traja-qti-qualcomm-com/ath10k-Add-support-for-BTCOEX-feature/20161109-043718
>> base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git
>> ath-next
>> :::::: branch date: 2 hours ago
>> :::::: commit date: 2 hours ago
>>
>> >> drivers/net/wireless/ath/ath10k/mac.c:7556:2-8: preceding lock on line 7545
>>
>> git remote add linux-review https://github.com/0day-ci/linux
>> git remote update linux-review
>> git checkout 2fc922b27f111b9e8089a3e94a17ee827e769c55
>> vim +7556 drivers/net/wireless/ath/ath10k/mac.c
>>
>> 2fc922b2 Tamizh chelvam 2016-11-08 7539
>> 2fc922b2 Tamizh chelvam 2016-11-08 7540 if
>> (!(test_bit(ATH10K_FLAG_BTCOEX, &ar->dev_flags))) {
>> 2fc922b2 Tamizh chelvam 2016-11-08 7541 ret = -EINVAL;
>> 2fc922b2 Tamizh chelvam 2016-11-08 7542 goto exit;
>> 2fc922b2 Tamizh chelvam 2016-11-08 7543 }
>> 2fc922b2 Tamizh chelvam 2016-11-08 7544
>> 2fc922b2 Tamizh chelvam 2016-11-08 @7545
>> mutex_lock(&ar->conf_mutex);
>> 2fc922b2 Tamizh chelvam 2016-11-08 7546
>> 2fc922b2 Tamizh chelvam 2016-11-08 7547 if (ar->state !=
>> ATH10K_STATE_ON &&
>> 2fc922b2 Tamizh chelvam 2016-11-08 7548 ar->state !=
>> ATH10K_STATE_RESTARTED) {
>> 2fc922b2 Tamizh chelvam 2016-11-08 7549 ret = -ENETDOWN;
>> 2fc922b2 Tamizh chelvam 2016-11-08 7550 goto exit;
>> 2fc922b2 Tamizh chelvam 2016-11-08 7551 }
>> 2fc922b2 Tamizh chelvam 2016-11-08 7552
>> 2fc922b2 Tamizh chelvam 2016-11-08 7553 btcoex_prio =
>> ath10k_mac_get_btcoex_prio(btcoex_priority);
>> 2fc922b2 Tamizh chelvam 2016-11-08 7554
>> 2fc922b2 Tamizh chelvam 2016-11-08 7555 if (btcoex_prio > 0x3f)
>> 2fc922b2 Tamizh chelvam 2016-11-08 @7556 return -E2BIG;
>> 2fc922b2 Tamizh chelvam 2016-11-08 7557
>> 2fc922b2 Tamizh chelvam 2016-11-08 7558 ret =
>> ath10k_wmi_set_coex_param(ar, btcoex_prio);
>> 2fc922b2 Tamizh chelvam 2016-11-08 7559
>>
>> ---
>> 0-DAY kernel test infrastructure Open Source Technology
>> Center
>> https://lists.01.org/pipermail/kbuild-all Intel
>> Corporation
>>
next prev parent reply other threads:[~2016-11-10 6:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201611090629.9JO64IrN%fengguang.wu@intel.com>
2016-11-09 20:50 ` [PATCH 2/4] ath10k: Add support to update btcoex priority value via nl80211 Julia Lawall
2016-11-09 20:50 ` Julia Lawall
2016-11-10 6:27 ` Tamizh chelvam [this message]
2016-11-10 6:27 ` Tamizh chelvam
2016-11-08 15:02 [PATCH 0/4] ath10k: Add support for BTCOEX feature c_traja
2016-11-08 15:02 ` [PATCH 2/4] ath10k: Add support to update btcoex priority value via nl80211 c_traja
2016-11-08 15:02 ` c_traja
2016-11-08 22:54 ` kbuild test robot
2016-11-08 22:54 ` kbuild test robot
2016-11-08 23:49 ` kbuild test robot
2016-11-08 23:49 ` kbuild test robot
2016-11-09 10:46 ` Tamizh chelvam
2016-11-09 10:46 ` Tamizh chelvam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5099054e6f8d4ea605d4af2f303ed31d@codeaurora.org \
--to=tamizhchelvam@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=c_traja@qti.qualcomm.com \
--cc=julia.lawall@lip6.fr \
--cc=kbuild-all@01.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.