All of lore.kernel.org
 help / color / mirror / Atom feed
From: York Sun <yorksun@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [u-boot-release] [PATCH] powerpc/mpc8xxx: Fix compiling error caused in DDR driver
Date: Wed, 7 Nov 2012 16:08:15 -0800	[thread overview]
Message-ID: <509AF7EF.9020301@freescale.com> (raw)
In-Reply-To: <CC6546B78A5F204290BB35835D3E85812785A1@039-SN2MPN1-012.039d.mgd.msft.net>

On 11/07/2012 03:57 PM, Fleming Andy-AFLEMING wrote:
>
> On Nov 7, 2012, at 5:47 PM, York Sun wrote:
>
>> mpc86xx platforms should use CONFIG_SYS_MPC86xx_DDR2_ADDR in utils.c
>> if applicable.
>>
>> Signed-off-by: York Sun <yorksun@freescale.com>
>> ---
>> arch/powerpc/cpu/mpc8xxx/ddr/util.c |    4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/arch/powerpc/cpu/mpc8xxx/ddr/util.c b/arch/powerpc/cpu/mpc8xxx/ddr/util.c
>> index 940ffff..9a07d9d 100644
>> --- a/arch/powerpc/cpu/mpc8xxx/ddr/util.c
>> +++ b/arch/powerpc/cpu/mpc8xxx/ddr/util.c
>> @@ -152,7 +152,11 @@ void board_add_ram_info(int use_default)
>>
>> #if CONFIG_NUM_DDR_CONTROLLERS >= 2
>> 	if (!(sdram_cfg & SDRAM_CFG_MEM_EN)) {
>> +#ifdef CONFIG_MPC86xx
>> +		ddr = (void __iomem *)CONFIG_SYS_MPC86xx_DDR2_ADDR;
>> +#else
>> 		ddr = (void __iomem *)CONFIG_SYS_MPC85xx_DDR2_ADDR;
>> +#endif
>
>
> Argh, I submitted a patch to fix this more completely, but haven't applied it, yet. See: http://patchwork.ozlabs.org/patch/193611/
>
>
Thanks. You may want to add #else clause to catch errors. I'd rather see 
compiling error than debugging run time error.

York

      reply	other threads:[~2012-11-08  0:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-07 23:47 [U-Boot] [PATCH] powerpc/mpc8xxx: Fix compiling error caused in DDR driver York Sun
2012-11-07 23:57 ` [U-Boot] [u-boot-release] " Fleming Andy-AFLEMING
2012-11-08  0:08   ` York Sun [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=509AF7EF.9020301@freescale.com \
    --to=yorksun@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.