* [U-Boot] [PATCH] powerpc/mpc8xxx: Fix compiling error caused in DDR driver
@ 2012-11-07 23:47 York Sun
2012-11-07 23:57 ` [U-Boot] [u-boot-release] " Fleming Andy-AFLEMING
0 siblings, 1 reply; 3+ messages in thread
From: York Sun @ 2012-11-07 23:47 UTC (permalink / raw)
To: u-boot
mpc86xx platforms should use CONFIG_SYS_MPC86xx_DDR2_ADDR in utils.c
if applicable.
Signed-off-by: York Sun <yorksun@freescale.com>
---
arch/powerpc/cpu/mpc8xxx/ddr/util.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/powerpc/cpu/mpc8xxx/ddr/util.c b/arch/powerpc/cpu/mpc8xxx/ddr/util.c
index 940ffff..9a07d9d 100644
--- a/arch/powerpc/cpu/mpc8xxx/ddr/util.c
+++ b/arch/powerpc/cpu/mpc8xxx/ddr/util.c
@@ -152,7 +152,11 @@ void board_add_ram_info(int use_default)
#if CONFIG_NUM_DDR_CONTROLLERS >= 2
if (!(sdram_cfg & SDRAM_CFG_MEM_EN)) {
+#ifdef CONFIG_MPC86xx
+ ddr = (void __iomem *)CONFIG_SYS_MPC86xx_DDR2_ADDR;
+#else
ddr = (void __iomem *)CONFIG_SYS_MPC85xx_DDR2_ADDR;
+#endif
sdram_cfg = in_be32(&ddr->sdram_cfg);
}
#endif
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* [U-Boot] [u-boot-release] [PATCH] powerpc/mpc8xxx: Fix compiling error caused in DDR driver
2012-11-07 23:47 [U-Boot] [PATCH] powerpc/mpc8xxx: Fix compiling error caused in DDR driver York Sun
@ 2012-11-07 23:57 ` Fleming Andy-AFLEMING
2012-11-08 0:08 ` York Sun
0 siblings, 1 reply; 3+ messages in thread
From: Fleming Andy-AFLEMING @ 2012-11-07 23:57 UTC (permalink / raw)
To: u-boot
On Nov 7, 2012, at 5:47 PM, York Sun wrote:
> mpc86xx platforms should use CONFIG_SYS_MPC86xx_DDR2_ADDR in utils.c
> if applicable.
>
> Signed-off-by: York Sun <yorksun@freescale.com>
> ---
> arch/powerpc/cpu/mpc8xxx/ddr/util.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/powerpc/cpu/mpc8xxx/ddr/util.c b/arch/powerpc/cpu/mpc8xxx/ddr/util.c
> index 940ffff..9a07d9d 100644
> --- a/arch/powerpc/cpu/mpc8xxx/ddr/util.c
> +++ b/arch/powerpc/cpu/mpc8xxx/ddr/util.c
> @@ -152,7 +152,11 @@ void board_add_ram_info(int use_default)
>
> #if CONFIG_NUM_DDR_CONTROLLERS >= 2
> if (!(sdram_cfg & SDRAM_CFG_MEM_EN)) {
> +#ifdef CONFIG_MPC86xx
> + ddr = (void __iomem *)CONFIG_SYS_MPC86xx_DDR2_ADDR;
> +#else
> ddr = (void __iomem *)CONFIG_SYS_MPC85xx_DDR2_ADDR;
> +#endif
Argh, I submitted a patch to fix this more completely, but haven't applied it, yet. See: http://patchwork.ozlabs.org/patch/193611/
Andy
^ permalink raw reply [flat|nested] 3+ messages in thread* [U-Boot] [u-boot-release] [PATCH] powerpc/mpc8xxx: Fix compiling error caused in DDR driver
2012-11-07 23:57 ` [U-Boot] [u-boot-release] " Fleming Andy-AFLEMING
@ 2012-11-08 0:08 ` York Sun
0 siblings, 0 replies; 3+ messages in thread
From: York Sun @ 2012-11-08 0:08 UTC (permalink / raw)
To: u-boot
On 11/07/2012 03:57 PM, Fleming Andy-AFLEMING wrote:
>
> On Nov 7, 2012, at 5:47 PM, York Sun wrote:
>
>> mpc86xx platforms should use CONFIG_SYS_MPC86xx_DDR2_ADDR in utils.c
>> if applicable.
>>
>> Signed-off-by: York Sun <yorksun@freescale.com>
>> ---
>> arch/powerpc/cpu/mpc8xxx/ddr/util.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/arch/powerpc/cpu/mpc8xxx/ddr/util.c b/arch/powerpc/cpu/mpc8xxx/ddr/util.c
>> index 940ffff..9a07d9d 100644
>> --- a/arch/powerpc/cpu/mpc8xxx/ddr/util.c
>> +++ b/arch/powerpc/cpu/mpc8xxx/ddr/util.c
>> @@ -152,7 +152,11 @@ void board_add_ram_info(int use_default)
>>
>> #if CONFIG_NUM_DDR_CONTROLLERS >= 2
>> if (!(sdram_cfg & SDRAM_CFG_MEM_EN)) {
>> +#ifdef CONFIG_MPC86xx
>> + ddr = (void __iomem *)CONFIG_SYS_MPC86xx_DDR2_ADDR;
>> +#else
>> ddr = (void __iomem *)CONFIG_SYS_MPC85xx_DDR2_ADDR;
>> +#endif
>
>
> Argh, I submitted a patch to fix this more completely, but haven't applied it, yet. See: http://patchwork.ozlabs.org/patch/193611/
>
>
Thanks. You may want to add #else clause to catch errors. I'd rather see
compiling error than debugging run time error.
York
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-11-08 0:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-07 23:47 [U-Boot] [PATCH] powerpc/mpc8xxx: Fix compiling error caused in DDR driver York Sun
2012-11-07 23:57 ` [U-Boot] [u-boot-release] " Fleming Andy-AFLEMING
2012-11-08 0:08 ` York Sun
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.