All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shan Wei <shanwei88@gmail.com>
To: Christoph Lameter <cl@linux.com>
Cc: jesse@nicira.com, dev@openvswitch.org,
	NetDev <netdev@vger.kernel.org>,
	Kernel-Maillist <linux-kernel@vger.kernel.org>,
	David Miller <davem@davemloft.net>
Subject: Re: [PATCH 4/9] net: openvswitch: use this_cpu_ptr per-cpu helper
Date: Thu, 08 Nov 2012 22:22:30 +0800	[thread overview]
Message-ID: <509BC026.4040209@gmail.com> (raw)
In-Reply-To: <0000013ac23ac528-19a0dd1b-3144-45df-9d6e-471999d6ae31-000000@email.amazonses.com>

Christoph Lameter said, at 2012/11/3 1:46:
>>  		u64_stats_update_begin(&stats->sync);
>>  		stats->tx_packets++;
> 
> Use this_cpu_inc(vport->percpu_stats->packets) here?
 
Lots of network drivers use u64_stats_sync infrastructure for statistics
on 32bit or 64bit hosts no matter how many members in per-cpu variable. 

keep them be consistent, so no plan to change them.

Thanks 


  reply	other threads:[~2012-11-08 14:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-02 16:01 [PATCH 4/9] net: openvswitch: use this_cpu_ptr per-cpu helper Shan Wei
2012-11-02 17:46 ` Christoph Lameter
2012-11-08 14:22   ` Shan Wei [this message]
2012-11-08 17:18     ` Christoph Lameter
2012-11-09  1:39       ` Shan Wei
  -- strict thread matches above, loose matches on Subject: below --
2012-10-31 11:22 Shan Wei
2012-10-31 17:39 ` Christoph Lameter
2012-11-01 10:07   ` Shan Wei
2012-11-01 14:33     ` Christoph Lameter
2012-11-02  1:38       ` Jesse Gross
2012-11-02 14:01         ` Christoph Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=509BC026.4040209@gmail.com \
    --to=shanwei88@gmail.com \
    --cc=cl@linux.com \
    --cc=davem@davemloft.net \
    --cc=dev@openvswitch.org \
    --cc=jesse@nicira.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.