All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shan Wei <shanwei88@gmail.com>
To: Christoph Lameter <cl@linux.com>
Cc: jesse@nicira.com, dev@openvswitch.org,
	NetDev <netdev@vger.kernel.org>,
	Kernel-Maillist <linux-kernel@vger.kernel.org>,
	David Miller <davem@davemloft.net>
Subject: Re: [PATCH 4/9] net: openvswitch: use this_cpu_ptr per-cpu helper
Date: Fri, 09 Nov 2012 09:39:58 +0800	[thread overview]
Message-ID: <509C5EEE.4050205@gmail.com> (raw)
In-Reply-To: <0000013ae10817d9-c5215352-348f-4898-b618-bb89e8725ab1-000000@email.amazonses.com>

Christoph Lameter said, at 2012/11/9 1:18:
> On Thu, 8 Nov 2012, Shan Wei wrote:
> 
>> Christoph Lameter said, at 2012/11/3 1:46:
>>>>  		u64_stats_update_begin(&stats->sync);
>>>>  		stats->tx_packets++;
>>>
>>> Use this_cpu_inc(vport->percpu_stats->packets) here?
>>
>> Lots of network drivers use u64_stats_sync infrastructure for statistics
> 
> So they would all have an advantage from the patch.

I will try to do the optimizing next time in another patchset which not included
in this series patchset.

I will submit v3 version of this series after testing today.

Thanks

 
 


  reply	other threads:[~2012-11-09  1:40 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-02 16:01 [PATCH 4/9] net: openvswitch: use this_cpu_ptr per-cpu helper Shan Wei
2012-11-02 17:46 ` Christoph Lameter
2012-11-08 14:22   ` Shan Wei
2012-11-08 17:18     ` Christoph Lameter
2012-11-09  1:39       ` Shan Wei [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-10-31 11:22 Shan Wei
2012-10-31 17:39 ` Christoph Lameter
2012-11-01 10:07   ` Shan Wei
2012-11-01 14:33     ` Christoph Lameter
2012-11-02  1:38       ` Jesse Gross
2012-11-02 14:01         ` Christoph Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=509C5EEE.4050205@gmail.com \
    --to=shanwei88@gmail.com \
    --cc=cl@linux.com \
    --cc=davem@davemloft.net \
    --cc=dev@openvswitch.org \
    --cc=jesse@nicira.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.