From: Stephen Warren <swarren@wwwdotorg.org>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: Kukjin Kim <kgene.kim@samsung.com>,
Olof Johansson <olof@lixom.net>,
linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC PATCH 1/4] ARM: S3C24XX: move s3c24xx-irq to drivers/irqchip
Date: Mon, 12 Nov 2012 10:05:39 -0700 [thread overview]
Message-ID: <50A12C63.2000609@wwwdotorg.org> (raw)
In-Reply-To: <201211121447.49977.heiko@sntech.de>
On 11/12/2012 06:47 AM, Heiko Stübner wrote:
> Removes another part from plat-s3c24xx and also enables further
> improvements happening in the correct location.
>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ---
> arch/arm/Kconfig | 1 +
> arch/arm/plat-s3c24xx/Makefile | 1 -
> drivers/irqchip/Kconfig | 3 +++
> drivers/irqchip/Makefile | 1 +
> .../irq.c => drivers/irqchip/irq-s3c24xx.c | 0
> 5 files changed, 5 insertions(+), 1 deletions(-)
> rename arch/arm/plat-s3c24xx/irq.c => drivers/irqchip/irq-s3c24xx.c (100%)
Presumably there's a header file somewhere that defines the interface to
irq-s3c24xx.c that other code in arch/arm/plat-s3c24xx is using to
initialize it. That header should be moved somewhere public (i.e.
outside {mach,plat}-*/include/{mach,plat}). However, you then end up
with a header file per IRQ driver in that public location. So, Thomas
Petazzoni started working on a solution for that:
> http://lists.arm.linux.org.uk/lurker/message/20121027.164514.11eb86db.en.html
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 1/4] ARM: S3C24XX: move s3c24xx-irq to drivers/irqchip
Date: Mon, 12 Nov 2012 10:05:39 -0700 [thread overview]
Message-ID: <50A12C63.2000609@wwwdotorg.org> (raw)
In-Reply-To: <201211121447.49977.heiko@sntech.de>
On 11/12/2012 06:47 AM, Heiko St?bner wrote:
> Removes another part from plat-s3c24xx and also enables further
> improvements happening in the correct location.
>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ---
> arch/arm/Kconfig | 1 +
> arch/arm/plat-s3c24xx/Makefile | 1 -
> drivers/irqchip/Kconfig | 3 +++
> drivers/irqchip/Makefile | 1 +
> .../irq.c => drivers/irqchip/irq-s3c24xx.c | 0
> 5 files changed, 5 insertions(+), 1 deletions(-)
> rename arch/arm/plat-s3c24xx/irq.c => drivers/irqchip/irq-s3c24xx.c (100%)
Presumably there's a header file somewhere that defines the interface to
irq-s3c24xx.c that other code in arch/arm/plat-s3c24xx is using to
initialize it. That header should be moved somewhere public (i.e.
outside {mach,plat}-*/include/{mach,plat}). However, you then end up
with a header file per IRQ driver in that public location. So, Thomas
Petazzoni started working on a solution for that:
> http://lists.arm.linux.org.uk/lurker/message/20121027.164514.11eb86db.en.html
next prev parent reply other threads:[~2012-11-12 17:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-12 13:46 [RFC PATCH 0/4] ARM: S3C24XX: irq move to drivers and first steps to dt Heiko Stübner
2012-11-12 13:46 ` Heiko Stübner
2012-11-12 13:47 ` [RFC PATCH 1/4] ARM: S3C24XX: move s3c24xx-irq to drivers/irqchip Heiko Stübner
2012-11-12 13:47 ` Heiko Stübner
2012-11-12 17:05 ` Stephen Warren [this message]
2012-11-12 17:05 ` Stephen Warren
2012-11-12 18:15 ` Heiko Stübner
2012-11-12 18:15 ` Heiko Stübner
2012-11-12 13:48 ` [RFC PATCH 2/4] irqchip: s3c24xx: add irq_domains for the interrupt registers Heiko Stübner
2012-11-12 13:48 ` Heiko Stübner
2012-11-12 13:49 ` [RFC PATCH 3/4] ARM: S3C24XX: irq_data conversion for s3c_irqsub_* functions Heiko Stübner
2012-11-12 13:49 ` Heiko Stübner
2012-11-12 13:50 ` [RFC PATCH 4/4] ARM: S3C24XX: First part converting irq code to use hwirq Heiko Stübner
2012-11-12 13:50 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50A12C63.2000609@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=heiko@sntech.de \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.