All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Grégory Hermant" <gregory.hermant@calao-systems.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/6] hdmiservice: new package
Date: Tue, 13 Nov 2012 12:03:05 +0100	[thread overview]
Message-ID: <50A228E9.70507@calao-systems.com> (raw)
In-Reply-To: <20121112193458.1504468b@skate>

Hi thomas,

Le 12/11/2012 19:34, Thomas Petazzoni a ?crit :
> Dear Gregory Hermant,
> 
> On Mon, 12 Nov 2012 18:41:37 +0100, Gregory Hermant wrote:
>>
>> Signed-off-by: Gregory Hermant <gregory.hermant@calao-systems.com>
>> ---
>>  package/Config.in                  |    1 +
>>  package/hdmiservice/Config.in      |   10 +++++++++
>>  package/hdmiservice/hdmiservice.mk |   43 ++++++++++++++++++++++++++++++++++++
> 
> Is this software something generic, or very specific to the Snowball
> platform? I am worried by the package name that is way too generic for
> something that looks board specific. It seems to be tied to a very
> custom graphics driver.

Yes it is specific to the snowball.
What do you suggest to manage this package ?
> 
>> diff --git a/package/hdmiservice/hdmiservice.mk b/package/hdmiservice/hdmiservice.mk
>> new file mode 100644
>> index 0000000..7199f1c
>> --- /dev/null
>> +++ b/package/hdmiservice/hdmiservice.mk
>> @@ -0,0 +1,43 @@
>> +#############################################################
>> +#
>> +# hdmiservice
>> +#
>> +#############################################################
>> +HDMISERVICE_VERSION = f75c99d1c52707240a78b4ba78e41d20d3aa3b08
>> +HDMISERVICE_SITE = git://igloocommunity.org/git/bsp/hdmiservice.git
>> +HDMISERVICE_LICENSE = MIT
>> +HDMISERVICE_LICENSE_FILES = debian/copyright
>> +HDMISERVICE_INSTALL_STAGING = YES
>> +
>> +define HDMISERVICE_BUILD_CMDS
>> +	$(MAKE) CC="$(TARGET_CC)" -C $(@D)
>> +endef
>> +
>> +define HDMISERVICE_INSTALL_STAGING_CMDS
>> +	$(INSTALL) -D -m 0755 $(@D)/hdmiservice.so $(STAGING_DIR)/usr/lib/hdmiservice.so
>> +	$(INSTALL) -D -m 0644 $(@D)/include/hdmi_service_api.h $(STAGING_DIR)/usr/include/hdmi_service_api.h
>> +	$(INSTALL) -D -m 0644 $(@D)/include/hdmi_service_local.h $(STAGING_DIR)/usr/include/hdmi_service_local.h
>> +endef
>> +
>> +define HDMISERVICE_INSTALL_TARGET_CMDS
>> +	$(INSTALL) -D -m 0755 $(@D)/hdmiservice.so $(TARGET_DIR)/usr/lib/hdmiservice.so
>> +	$(INSTALL) -D -m 0755 $(@D)/hdmistart $(TARGET_DIR)/usr/bin/hdmistart
>> +endef
> 
> Any reason not to use the 'make install' target which apparently does
> the right thing?
> 
Not really. I just keep a similar syntax as staging part.
What do you recommend ?

> Thanks,
> 
> Thomas
> 
Thanks,
Gr?gory

  reply	other threads:[~2012-11-13 11:03 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-12 17:41 [Buildroot] [PATCH v2 0/6] Add support for the snowball board Gregory Hermant
2012-11-12 17:41 ` [Buildroot] [PATCH v2 1/6] hdmiservice: new package Gregory Hermant
2012-11-12 18:34   ` Thomas Petazzoni
2012-11-13 11:03     ` Grégory Hermant [this message]
2012-11-13 11:06       ` Thomas Petazzoni
2012-11-12 17:41 ` [Buildroot] [PATCH v2 2/6] ux500-firmware: " Gregory Hermant
2012-11-12 21:44   ` Arnout Vandecappelle
2012-11-12 17:41 ` [Buildroot] [PATCH v2 3/6] Add board files for snowball Gregory Hermant
2012-11-12 18:37   ` Thomas Petazzoni
2012-11-13 11:03     ` Grégory Hermant
2012-11-13 21:18       ` Arnout Vandecappelle
2012-11-12 17:41 ` [Buildroot] [PATCH v2 4/6] Add init script files for snowball board Gregory Hermant
2012-11-12 21:45   ` Arnout Vandecappelle
2012-11-12 17:41 ` [Buildroot] [PATCH v2 5/6] bluez-utils: add cg2900 support " Gregory Hermant
2012-11-12 21:47   ` Arnout Vandecappelle
2012-11-12 17:41 ` [Buildroot] [PATCH v2 6/6] Add config file for the " Gregory Hermant
2012-11-12 21:53   ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50A228E9.70507@calao-systems.com \
    --to=gregory.hermant@calao-systems.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.