From: David Daney <ddaney.cavm@gmail.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: Jonas Gorski <jonas.gorski@gmail.com>,
linux-mips@linux-mips.org, devicetree-discuss@lists.ozlabs.org,
Kevin Cernekee <cernekee@gmail.com>,
linux-kernel@vger.kernel.org, Ralf Baechle <ralf@linux-mips.org>,
Maxime Bizon <mbizon@freebox.fr>,
Florian Fainelli <florian@openwrt.org>
Subject: Re: [RFC] MIPS: BCM63XX: add simple Device Tree includes for all SoCs
Date: Tue, 13 Nov 2012 09:56:56 -0800 [thread overview]
Message-ID: <50A289E8.4030407@gmail.com> (raw)
In-Reply-To: <50A1D290.3050409@wwwdotorg.org>
On 11/12/2012 08:54 PM, Stephen Warren wrote:
> On 11/11/2012 05:50 AM, Jonas Gorski wrote:
>> Add simple Device Tree include files for all currently supported SoCs.
>> These will be populated with device definitions as driver support
>> gets added.
>
>> arch/mips/bcm63xx/dts/bcm6328.dtsi | 30 ++++++++++++++++++++++++++++++
>> arch/mips/bcm63xx/dts/bcm6338.dtsi | 30 ++++++++++++++++++++++++++++++
>> arch/mips/bcm63xx/dts/bcm6345.dtsi | 30 ++++++++++++++++++++++++++++++
>> arch/mips/bcm63xx/dts/bcm6348.dtsi | 30 ++++++++++++++++++++++++++++++
>> arch/mips/bcm63xx/dts/bcm6358.dtsi | 33 +++++++++++++++++++++++++++++++++
>> arch/mips/bcm63xx/dts/bcm6368.dtsi | 33 +++++++++++++++++++++++++++++++++
>
> All of ARM, c6x, microblaze, openrisc, powerpc put device tree files
> into arch/${arch}/boot/dts/ - should MIPS follow the same layout?
At this point, I don't see what the benefit of centralizing all of these
would be. Currently there is no concept of a single kernel image that
would work across multiple MIPS system implementations. So keeping the
DTS files with their users makes some organizational sense.
Similar arguments could be made for moving all the files in `find .
-name \*.dts\*` to a top level dts/ directory.
David Daney
WARNING: multiple messages have this Message-ID (diff)
From: David Daney <ddaney.cavm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
Cc: linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
Kevin Cernekee <cernekee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Ralf Baechle <ralf-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org>,
Maxime Bizon <mbizon-MmRyKUhfbQ9GWvitb5QawA@public.gmane.org>,
Florian Fainelli
<florian-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
Subject: Re: [RFC] MIPS: BCM63XX: add simple Device Tree includes for all SoCs
Date: Tue, 13 Nov 2012 09:56:56 -0800 [thread overview]
Message-ID: <50A289E8.4030407@gmail.com> (raw)
In-Reply-To: <50A1D290.3050409-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
On 11/12/2012 08:54 PM, Stephen Warren wrote:
> On 11/11/2012 05:50 AM, Jonas Gorski wrote:
>> Add simple Device Tree include files for all currently supported SoCs.
>> These will be populated with device definitions as driver support
>> gets added.
>
>> arch/mips/bcm63xx/dts/bcm6328.dtsi | 30 ++++++++++++++++++++++++++++++
>> arch/mips/bcm63xx/dts/bcm6338.dtsi | 30 ++++++++++++++++++++++++++++++
>> arch/mips/bcm63xx/dts/bcm6345.dtsi | 30 ++++++++++++++++++++++++++++++
>> arch/mips/bcm63xx/dts/bcm6348.dtsi | 30 ++++++++++++++++++++++++++++++
>> arch/mips/bcm63xx/dts/bcm6358.dtsi | 33 +++++++++++++++++++++++++++++++++
>> arch/mips/bcm63xx/dts/bcm6368.dtsi | 33 +++++++++++++++++++++++++++++++++
>
> All of ARM, c6x, microblaze, openrisc, powerpc put device tree files
> into arch/${arch}/boot/dts/ - should MIPS follow the same layout?
At this point, I don't see what the benefit of centralizing all of these
would be. Currently there is no concept of a single kernel image that
would work across multiple MIPS system implementations. So keeping the
DTS files with their users makes some organizational sense.
Similar arguments could be made for moving all the files in `find .
-name \*.dts\*` to a top level dts/ directory.
David Daney
next prev parent reply other threads:[~2012-11-13 17:57 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-11 12:50 [RFC] MIPS: BCM63XX: add initial Device Tree support Jonas Gorski
2012-11-11 12:50 ` [RFC] MIPS: BCM63XX: add support for loading DTB Jonas Gorski
2012-11-11 12:50 ` Jonas Gorski
2012-11-11 12:50 ` [RFC] MIPS: BCM63XX: add simple Device Tree includes for all SoCs Jonas Gorski
2012-11-11 12:50 ` Jonas Gorski
2012-11-13 4:54 ` Stephen Warren
2012-11-13 17:56 ` David Daney [this message]
2012-11-13 17:56 ` David Daney
2012-11-11 12:50 ` [RFC] MIPS: BCM63XX: add generic fallback device trees Jonas Gorski
2012-11-11 12:50 ` [RFC] MIPS: BCM63XX: add Device Tree glue code for IRQ handling Jonas Gorski
2012-11-13 5:00 ` Stephen Warren
2012-11-14 12:09 ` Jonas Gorski
2012-11-17 4:13 ` Stephen Warren
2012-11-11 12:50 ` [RFC] SPI: spi-bcm63xx: use clk_{prepare_enable,disable_unprepare} Jonas Gorski
2012-11-11 12:50 ` Jonas Gorski
2012-11-11 12:50 ` [RFC] bcm63xx-rng: " Jonas Gorski
2012-11-11 12:50 ` Jonas Gorski
2012-11-11 12:50 ` [RFC] net: ethernet: bcm63xx_enet: " Jonas Gorski
2012-11-11 12:50 ` [RFC] serial: bcm63xx_uart: remove unnecessary include Jonas Gorski
2012-11-11 12:50 ` Jonas Gorski
2012-11-11 12:50 ` [RFC] MIPS: BCM63XX: add Device Tree clock definitions Jonas Gorski
2012-11-13 5:02 ` Stephen Warren
2012-11-14 12:11 ` Jonas Gorski
2012-11-17 4:15 ` Stephen Warren
2012-11-11 12:50 ` [RFC] MIPS: BCM63XX: switch to common clock and Device Tree Jonas Gorski
2012-11-13 5:04 ` Stephen Warren
2012-11-14 12:12 ` Jonas Gorski
2012-11-11 12:50 ` [RFC] MIPS: BCM63XX: register GPIO controller through " Jonas Gorski
2012-11-13 5:06 ` Stephen Warren
2012-11-14 12:13 ` Jonas Gorski
2012-11-11 12:50 ` [RFC] serial: bcm63xx_uart: allow probing " Jonas Gorski
2012-11-11 12:50 ` [RFC] MIPS: BCM63XX: add serial blocks to Device Tree includes Jonas Gorski
2012-11-11 12:50 ` [RFC] MIPS: BCM63XX: add empty Device Trees for all supported boards Jonas Gorski
2012-11-13 5:12 ` Stephen Warren
2012-11-14 12:15 ` Jonas Gorski
2012-11-11 12:50 ` [RFC] MIPS: BCM63XX: enable serial through Device Tree Jonas Gorski
2012-11-13 5:13 ` Stephen Warren
2012-11-13 5:13 ` Stephen Warren
[not found] ` <50A1D6ED.50001-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-11-14 12:17 ` Jonas Gorski
2012-11-11 12:59 ` [RFC] MIPS: BCM63XX: add initial Device Tree support Jonas Gorski
2012-11-11 12:59 ` Jonas Gorski
2012-11-12 11:18 ` Maxime Bizon
2012-11-14 12:07 ` Jonas Gorski
2012-11-14 14:47 ` Maxime Bizon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50A289E8.4030407@gmail.com \
--to=ddaney.cavm@gmail.com \
--cc=cernekee@gmail.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=florian@openwrt.org \
--cc=jonas.gorski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=mbizon@freebox.fr \
--cc=ralf@linux-mips.org \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.