Re: [Qemu-devel] [PATCH 1/6] pixman: add output dir to include path

[Gerd Hoffmann <kraxel@redhat.com>]

On 11/13/12 18:57, Stefan Weil wrote:
> Am 13.11.2012 09:42, schrieb Gerd Hoffmann:
>> Needed to make sure the (generated) pixman-version.h file is found.
>> Based on a patch from Blue Swirl.
>>
>> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
>> ---
>>   configure |    6 +++---
>>   1 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/configure b/configure
>> index 7290f50..18faded 100755
>> --- a/configure
>> +++ b/configure
>> @@ -2121,8 +2121,9 @@ else
>>       echo "      git submodule update --init pixman"
>>       exit 1
>>     fi
>> -  pixman_cflags="-I${source_path}/pixman/pixman"
>> -  pixman_libs="-Lpixman/pixman/.libs -lpixman-1"
>> +  mkdir -p pixman/pixman
>> +  pixman_cflags="-I${source_path}/pixman/pixman -I$(pwd)/pixman/pixman"
>> +  pixman_libs="-L$(pwd)/pixman/pixman/.libs -lpixman-1"
> 
> I'd prefer \$(BUILD_DIR) instead of $(pwd) for cflags and libs
> because it allows moving the build directory.

It isn't that simple.  Blue Swirl had it that way initially.  The
problem is that pixman_cflags is added to QEMU_CFLAGS, which in turn is
used by configure script checks too, which then blow up because make and
shell interpret "$(BUILD_DIR)" in different ways ...

cheers,
  Gerd