From: Gerd Hoffmann <kraxel@redhat.com>
To: "Johnson, Eric" <ericj@mips.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 5/6] pixman: build internal version early
Date: Wed, 14 Nov 2012 13:41:55 +0100 [thread overview]
Message-ID: <50A39193.4090908@redhat.com> (raw)
In-Reply-To: <AD431C1EF67D4B4B801AEC089EB7ED480144889FBF@exchdb03.mips.com>
On 11/13/12 19:41, Johnson, Eric wrote:
> It's OK to add.
> Signed-off-by: Eric Johnson <ericj@mips.com>
Updated patch.
> I wasn't sure how to submit a patch to an unsubmitted patch.
As usual: "git commit -s" + "git format-patch" + "git send-email",
especially as this one stands on its own and has no dependency on the
unsubmitted patch, but it is fine for incremental fixes too.
Then I can simply "git am -s" the patch and either carry it on as is or
squash in the incremental fix on a case-by-case basis. I tend to carry
patches as is, but in some cases squashing can be better for bisectability.
cheers,
Gerd
next prev parent reply other threads:[~2012-11-14 12:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-13 8:42 [Qemu-devel] [PULL 0/6] pixman build fixes Gerd Hoffmann
2012-11-13 8:42 ` [Qemu-devel] [PATCH 1/6] pixman: add output dir to include path Gerd Hoffmann
2012-11-13 17:57 ` Stefan Weil
2012-11-14 8:40 ` Gerd Hoffmann
2012-11-14 12:33 ` Gerd Hoffmann
2012-11-13 8:42 ` [Qemu-devel] [PATCH 2/6] pixman: pass tools to configure Gerd Hoffmann
2012-11-13 17:50 ` Stefan Weil
2012-11-14 8:42 ` Gerd Hoffmann
2012-11-13 8:42 ` [Qemu-devel] [PATCH 3/6] pixman: disable gtk Gerd Hoffmann
2012-11-13 18:27 ` Peter Maydell
2012-11-13 8:42 ` [Qemu-devel] [PATCH 4/6] pixman: add pass cflags, add -fPIC Gerd Hoffmann
2012-11-13 18:28 ` Peter Maydell
2012-11-13 8:42 ` [Qemu-devel] [PATCH 5/6] pixman: build internal version early Gerd Hoffmann
2012-11-13 18:29 ` Peter Maydell
2012-11-13 18:41 ` Johnson, Eric
2012-11-14 12:41 ` Gerd Hoffmann [this message]
2012-11-14 18:42 ` Johnson, Eric
2012-11-13 8:42 ` [Qemu-devel] [PATCH 6/6] pixman: add licensing info Gerd Hoffmann
2012-11-13 17:31 ` [Qemu-devel] [PULL 0/6] pixman build fixes Peter Maydell
2012-11-13 18:07 ` Stefan Weil
2012-11-14 16:27 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50A39193.4090908@redhat.com \
--to=kraxel@redhat.com \
--cc=ericj@mips.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.