All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benoit Cousson <b-cousson-l0cyMroinI0@public.gmane.org>
To: Mark Brown
	<broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
Cc: "a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org"
	<a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org>,
	"sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org"
	<sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
	"rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org"
	<rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org>,
	"devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org"
	<devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>,
	"rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org"
	<rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
	Colin Foe-Parker
	<colin.foeparker-L+YfUVVR8+RBDgjK7y7TUQ@public.gmane.org>,
	"linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH 1/4] mfd: tps65217: Set PMIC to shutdowm on PWR_EN toggle
Date: Wed, 14 Nov 2012 11:08:49 +0100	[thread overview]
Message-ID: <50A36DB1.3010706@ti.com> (raw)
In-Reply-To: <20121114070046.GE7407-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>

Hi Mark,

On 11/14/2012 08:00 AM, Mark Brown wrote:
> On Wed, Nov 14, 2012 at 06:49:58AM +0000, AnilKumar, Chimata wrote:
> 
>> Earlier you have a comment on this thread, I am adding my comments
>> on top of it. Sorry if I am in wrong direction.
> 
> Ah, I see.  I was just commenting because Benoit was asking if this
> should be supported with a standard framework feature - I'm not
> convinced that it should right now as there's not any clear patterns in
> hardware behaviour.  I've no specific interest in this system.

I was wondering that, because exposing a pin to control the whole PMIC
low power mode seems to be something that should be generic enough to be
handled by the regulator framework.

In the current situation we do have a pwr_en pin that can be controlled
by a GPIO or whatever signal from the SoC.
That's very similar, at PMIC level, to the fixedregulator that allow a
GPIO binding to enable it.

Don't you think that should deserve a support in the fmwk?

Regards,
Benoit

WARNING: multiple messages have this Message-ID (diff)
From: b-cousson@ti.com (Benoit Cousson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] mfd: tps65217: Set PMIC to shutdowm on PWR_EN toggle
Date: Wed, 14 Nov 2012 11:08:49 +0100	[thread overview]
Message-ID: <50A36DB1.3010706@ti.com> (raw)
In-Reply-To: <20121114070046.GE7407@opensource.wolfsonmicro.com>

Hi Mark,

On 11/14/2012 08:00 AM, Mark Brown wrote:
> On Wed, Nov 14, 2012 at 06:49:58AM +0000, AnilKumar, Chimata wrote:
> 
>> Earlier you have a comment on this thread, I am adding my comments
>> on top of it. Sorry if I am in wrong direction.
> 
> Ah, I see.  I was just commenting because Benoit was asking if this
> should be supported with a standard framework feature - I'm not
> convinced that it should right now as there's not any clear patterns in
> hardware behaviour.  I've no specific interest in this system.

I was wondering that, because exposing a pin to control the whole PMIC
low power mode seems to be something that should be generic enough to be
handled by the regulator framework.

In the current situation we do have a pwr_en pin that can be controlled
by a GPIO or whatever signal from the SoC.
That's very similar, at PMIC level, to the fixedregulator that allow a
GPIO binding to enable it.

Don't you think that should deserve a support in the fmwk?

Regards,
Benoit

  parent reply	other threads:[~2012-11-14 10:08 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-05  9:42 [PATCH 0/4] pm: Add power off control AnilKumar Ch
2012-11-05  9:42 ` AnilKumar Ch
2012-11-05  9:42 ` [PATCH 1/4] mfd: tps65217: Set PMIC to shutdowm on PWR_EN toggle AnilKumar Ch
2012-11-05  9:42   ` AnilKumar Ch
     [not found]   ` <1352108549-9341-2-git-send-email-anilkumar-l0cyMroinI0@public.gmane.org>
2012-11-05 16:59     ` Benoit Cousson
2012-11-05 16:59       ` Benoit Cousson
     [not found]       ` <5097F078.50701-l0cyMroinI0@public.gmane.org>
2012-11-06  5:13         ` AnilKumar, Chimata
2012-11-06  5:13           ` AnilKumar, Chimata
2012-11-14  2:23       ` Mark Brown
2012-11-14  2:23         ` Mark Brown
     [not found]         ` <20121114022341.GM4415-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-11-14  5:10           ` AnilKumar, Chimata
2012-11-14  5:10             ` AnilKumar, Chimata
2012-11-14  6:11         ` AnilKumar, Chimata
2012-11-14  6:11           ` AnilKumar, Chimata
2012-11-14  6:21           ` Mark Brown
2012-11-14  6:21             ` Mark Brown
     [not found]             ` <20121114062117.GC7407-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-11-14  6:49               ` AnilKumar, Chimata
2012-11-14  6:49                 ` AnilKumar, Chimata
2012-11-14  7:00                 ` Mark Brown
2012-11-14  7:00                   ` Mark Brown
     [not found]                   ` <20121114070046.GE7407-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-11-14 10:08                     ` Benoit Cousson [this message]
2012-11-14 10:08                       ` Benoit Cousson
2012-11-14 10:24                       ` Mark Brown
2012-11-14 10:24                         ` Mark Brown
     [not found]                         ` <20121114102452.GI7407-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-11-16  6:16                           ` AnilKumar, Chimata
2012-11-16  6:16                             ` AnilKumar, Chimata
2012-11-05  9:42 ` [PATCH 2/4] rtc: OMAP: Add system pm_power_off to rtc driver AnilKumar Ch
2012-11-05  9:42   ` AnilKumar Ch
     [not found]   ` <1352108549-9341-3-git-send-email-anilkumar-l0cyMroinI0@public.gmane.org>
2012-11-05 16:43     ` Benoit Cousson
2012-11-05 16:43       ` Benoit Cousson
     [not found]       ` <5097ECAD.9010101-l0cyMroinI0@public.gmane.org>
2012-11-05 17:39         ` Colin FoeParker
2012-11-05 17:39           ` Colin FoeParker
2012-11-06  5:07       ` AnilKumar, Chimata
2012-11-06  5:07         ` AnilKumar, Chimata
2012-11-06 16:56         ` Benoit Cousson
2012-11-06 16:56           ` Benoit Cousson
     [not found]           ` <50994156.4080305-l0cyMroinI0@public.gmane.org>
2012-11-12  9:47             ` AnilKumar, Chimata
2012-11-12  9:47               ` AnilKumar, Chimata
2012-11-14  5:01           ` AnilKumar, Chimata
2012-11-14  5:01             ` AnilKumar, Chimata
2012-11-14  5:21             ` Mark Brown
2012-11-14  5:21               ` Mark Brown
2012-11-14  5:50           ` AnilKumar, Chimata
2012-11-14  5:50             ` AnilKumar, Chimata
2012-11-14  6:00             ` Mark Brown
2012-11-14  6:00               ` Mark Brown
2012-11-06  5:45   ` Bedia, Vaibhav
2012-11-06  5:45     ` Bedia, Vaibhav
     [not found]     ` <B5906170F1614E41A8A28DE3B8D121433EC04226-Er742YJ7I/eIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2012-11-12  9:47       ` AnilKumar, Chimata
2012-11-12  9:47         ` AnilKumar, Chimata
2012-11-16  6:13     ` AnilKumar, Chimata
2012-11-16  6:13       ` AnilKumar, Chimata
2012-11-16 10:47     ` AnilKumar, Chimata
2012-11-16 10:47       ` AnilKumar, Chimata
2012-11-05  9:42 ` [PATCH 3/4] ARM: dts: AM33XX: Set pmic-shutdown-controller for BeagleBone AnilKumar Ch
2012-11-05  9:42   ` AnilKumar Ch
     [not found] ` <1352108549-9341-1-git-send-email-anilkumar-l0cyMroinI0@public.gmane.org>
2012-11-05  9:42   ` [PATCH 4/4] ARM: dts: AM33XX: Enable system power off control in am335x-bone AnilKumar Ch
2012-11-05  9:42     ` AnilKumar Ch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50A36DB1.3010706@ti.com \
    --to=b-cousson-l0cymroini0@public.gmane.org \
    --cc=a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org \
    --cc=broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org \
    --cc=colin.foeparker-L+YfUVVR8+RBDgjK7y7TUQ@public.gmane.org \
    --cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \
    --cc=rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
    --cc=sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.