All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Charles Arnold <carnold@suse.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
	Thanos Makatos <thanos.makatos@citrix.com>,
	"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"stefanha@redhat.com" <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] block: vpc support for ~2 TB disks
Date: Thu, 15 Nov 2012 18:00:16 +0100	[thread overview]
Message-ID: <50A51FA0.1070504@redhat.com> (raw)
In-Reply-To: <50A4B9FB0200009100083093@novprvoes0310.provo.novell.com>

Il 15/11/2012 17:46, Charles Arnold ha scritto:
>>> We don't use qemu's VHD driver in XenServer. Instead, we use blktap2
>>> >> to create a block device in dom0 serving the VHD file in question,
>>> >> and have qemu open that block device instead of the VHD file itself.
>> > 
>> > Yes, the question is how you handle disks bigger than 127GB, so that
>> > QEMU can do the same.
>> > 
> In analyzing a 160 GB VHD fixed disk image created on Windows 2008 R2, it appears that
> MS is also ignoring the CHS values in the footer geometry field in whatever
> driver they use for accessing the image.  The CHS values are set at 65535,16,255
> which obviously doesn't represent an image size of 160 GB.

Thanks, this would have been useful in the commit message.

The patch looks good,

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>

Paolo

> This patch only extends the existing qemu driver to allow a larger image by allowing
> more heads.  On real hardware, only 4 bits would be allowed for heads but we don't
> have that restriction in qemu. 

WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Charles Arnold <carnold@suse.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
	Thanos Makatos <thanos.makatos@citrix.com>,
	"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"stefanha@redhat.com" <stefanha@redhat.com>
Subject: Re: [PATCH] block: vpc support for ~2 TB disks
Date: Thu, 15 Nov 2012 18:00:16 +0100	[thread overview]
Message-ID: <50A51FA0.1070504@redhat.com> (raw)
In-Reply-To: <50A4B9FB0200009100083093@novprvoes0310.provo.novell.com>

Il 15/11/2012 17:46, Charles Arnold ha scritto:
>>> We don't use qemu's VHD driver in XenServer. Instead, we use blktap2
>>> >> to create a block device in dom0 serving the VHD file in question,
>>> >> and have qemu open that block device instead of the VHD file itself.
>> > 
>> > Yes, the question is how you handle disks bigger than 127GB, so that
>> > QEMU can do the same.
>> > 
> In analyzing a 160 GB VHD fixed disk image created on Windows 2008 R2, it appears that
> MS is also ignoring the CHS values in the footer geometry field in whatever
> driver they use for accessing the image.  The CHS values are set at 65535,16,255
> which obviously doesn't represent an image size of 160 GB.

Thanks, this would have been useful in the commit message.

The patch looks good,

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>

Paolo

> This patch only extends the existing qemu driver to allow a larger image by allowing
> more heads.  On real hardware, only 4 bits would be allowed for heads but we don't
> have that restriction in qemu. 

  reply	other threads:[~2012-11-15 17:12 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-12 19:12 [Qemu-devel] [PATCH] block: vpc support for ~2 TB disks Charles Arnold
2012-11-13 10:46 ` Paolo Bonzini
2012-11-13 10:56   ` Stefano Stabellini
2012-11-13 10:56     ` Stefano Stabellini
2012-11-14 16:25     ` [Qemu-devel] " Thanos Makatos
2012-11-14 16:25       ` Thanos Makatos
2012-11-14 16:35       ` [Qemu-devel] " Paolo Bonzini
2012-11-14 16:35         ` Paolo Bonzini
2012-11-15 16:46         ` [Qemu-devel] " Charles Arnold
2012-11-15 16:46           ` Charles Arnold
2012-11-15 17:00           ` Paolo Bonzini [this message]
2012-11-15 17:00             ` Paolo Bonzini
2012-11-15 17:48         ` [Qemu-devel] " Thanos Makatos
2012-11-15 17:48           ` Thanos Makatos
  -- strict thread matches above, loose matches on Subject: below --
2012-10-31  2:59 [Qemu-devel] " Charles Arnold
2012-11-19 11:50 ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50A51FA0.1070504@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=Stefano.Stabellini@eu.citrix.com \
    --cc=carnold@suse.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=thanos.makatos@citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.