From: Jon Hunter <jon-hunter@ti.com>
To: balbi@ti.com
Cc: Tony Lindgren <tony@atomide.com>,
linux-omap <linux-omap@vger.kernel.org>,
linux-arm <linux-arm-kernel@lists.infradead.org>,
Kevin Hilman <khilman@deeprootsystems.com>
Subject: Re: [PATCH] ARM: OMAP2+: Fix compiler warning for 32k timer
Date: Thu, 15 Nov 2012 15:35:47 -0600 [thread overview]
Message-ID: <50A56033.6080908@ti.com> (raw)
In-Reply-To: <20121115204526.GC12466@arwen.pp.htv.fi>
On 11/15/2012 02:45 PM, Felipe Balbi wrote:
> Hi,
>
> On Thu, Nov 15, 2012 at 01:44:04PM -0600, Jon Hunter wrote:
>> +static struct of_device_id omap_counter_match[] __initdata = {
>
> not directly related to $SUBJECT, but shouldn't this be static const
> __initconst ?
Yes you are right. Looks like there are several other of_device_id
structs in arch/arm/mach-omap2 that could be updated to const too.
Cheers
Jon
WARNING: multiple messages have this Message-ID (diff)
From: jon-hunter@ti.com (Jon Hunter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP2+: Fix compiler warning for 32k timer
Date: Thu, 15 Nov 2012 15:35:47 -0600 [thread overview]
Message-ID: <50A56033.6080908@ti.com> (raw)
In-Reply-To: <20121115204526.GC12466@arwen.pp.htv.fi>
On 11/15/2012 02:45 PM, Felipe Balbi wrote:
> Hi,
>
> On Thu, Nov 15, 2012 at 01:44:04PM -0600, Jon Hunter wrote:
>> +static struct of_device_id omap_counter_match[] __initdata = {
>
> not directly related to $SUBJECT, but shouldn't this be static const
> __initconst ?
Yes you are right. Looks like there are several other of_device_id
structs in arch/arm/mach-omap2 that could be updated to const too.
Cheers
Jon
next prev parent reply other threads:[~2012-11-15 21:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-15 19:44 [PATCH] ARM: OMAP2+: Fix compiler warning for 32k timer Jon Hunter
2012-11-15 19:44 ` Jon Hunter
2012-11-15 20:45 ` Felipe Balbi
2012-11-15 20:45 ` Felipe Balbi
2012-11-15 21:35 ` Jon Hunter [this message]
2012-11-15 21:35 ` Jon Hunter
2012-11-16 7:52 ` Felipe Balbi
2012-11-16 7:52 ` Felipe Balbi
2012-11-16 15:03 ` Jon Hunter
2012-11-16 15:03 ` Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50A56033.6080908@ti.com \
--to=jon-hunter@ti.com \
--cc=balbi@ti.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.