From: Peter Lieven <pl@dlhnet.de>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kwolf@redhat.com, Peter Lieven <lieven-lists@dlhnet.de>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
ronnie sahlberg <ronniesahlberg@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] iscsi: fix deadlock during login
Date: Fri, 16 Nov 2012 10:26:39 +0100 [thread overview]
Message-ID: <50A606CF.6060208@dlhnet.de> (raw)
In-Reply-To: <50A5EED1.3060503@redhat.com>
Am 16.11.2012 08:44, schrieb Paolo Bonzini:
> Il 15/11/2012 19:28, Peter Lieven ha scritto:
>>>>>> I dont know if we should switch to use synchronous code here.
>>>>>> It is much nicer if all code is async.
>>>> bdrv_open is generally synchronous, so I think Peter's patch is ok.
>> if all is sync wouldn't it be best to have all code in iscsi_open sync
>> then and convert the iscsi_inquiry and iscsi_readcapacity commands also to
>> sync?
> Indeed, there is no real advantage in using qemu_aio_wait(). I didn't
> know libiscsi also had sync APIs. :)
ok, give me some days to rewrite this patch. i think it should be ready
by monday.
i will also add the missing iscsi_create which is a few lines only then.
peter
>
> Paolo
prev parent reply other threads:[~2012-11-16 9:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-15 14:50 [Qemu-devel] [PATCH] iscsi: fix deadlock during login Peter Lieven
2012-11-15 14:57 ` ronnie sahlberg
2012-11-15 15:05 ` Peter Lieven
2012-11-15 15:54 ` Paolo Bonzini
2012-11-15 16:11 ` Peter Lieven
2012-11-15 16:13 ` ronnie sahlberg
2012-11-15 16:37 ` Paolo Bonzini
2012-11-16 10:38 ` Kevin Wolf
2012-11-16 17:38 ` Peter Lieven
2012-11-16 17:55 ` Paolo Bonzini
2012-11-15 18:28 ` Peter Lieven
2012-11-16 7:44 ` Paolo Bonzini
2012-11-16 9:26 ` Peter Lieven [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50A606CF.6060208@dlhnet.de \
--to=pl@dlhnet.de \
--cc=kwolf@redhat.com \
--cc=lieven-lists@dlhnet.de \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=ronniesahlberg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.