From: Kevin Wolf <kwolf@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Peter Lieven <pl@dlhnet.de>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
ronnie sahlberg <ronniesahlberg@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] iscsi: fix deadlock during login
Date: Fri, 16 Nov 2012 11:38:20 +0100 [thread overview]
Message-ID: <50A6179C.5070104@redhat.com> (raw)
In-Reply-To: <50A51A52.4000807@redhat.com>
Am 15.11.2012 17:37, schrieb Paolo Bonzini:
> Il 15/11/2012 17:13, ronnie sahlberg ha scritto:
>> On Thu, Nov 15, 2012 at 7:54 AM, Paolo Bonzini <pbonzini@redhat.com> wrote:
>>> Il 15/11/2012 15:57, ronnie sahlberg ha scritto:
>>>> I dont know if we should switch to use synchronous code here.
>>>> It is much nicer if all code is async.
>>>
>>> bdrv_open is generally synchronous, so I think Peter's patch is ok.
>>
>> I was thinking about the case where you disconnect/reconnect a device
>> at runtime. Like swapping the medium in a CDROM.
>> If bdrv_open() is synchronous and blocks for a long time, would that
>> not impact the rest of QEMU?
>
> Yes, it's not optimal, but VCPUs would still run until they request I/O.
> But usually iscsi devices should be non-removable, no? That leaves
> hotplug as the only problematic case.
I guess we need a bdrv_co_open() for the long term.
Kevin
next prev parent reply other threads:[~2012-11-16 10:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-15 14:50 [Qemu-devel] [PATCH] iscsi: fix deadlock during login Peter Lieven
2012-11-15 14:57 ` ronnie sahlberg
2012-11-15 15:05 ` Peter Lieven
2012-11-15 15:54 ` Paolo Bonzini
2012-11-15 16:11 ` Peter Lieven
2012-11-15 16:13 ` ronnie sahlberg
2012-11-15 16:37 ` Paolo Bonzini
2012-11-16 10:38 ` Kevin Wolf [this message]
2012-11-16 17:38 ` Peter Lieven
2012-11-16 17:55 ` Paolo Bonzini
2012-11-15 18:28 ` Peter Lieven
2012-11-16 7:44 ` Paolo Bonzini
2012-11-16 9:26 ` Peter Lieven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50A6179C.5070104@redhat.com \
--to=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pl@dlhnet.de \
--cc=qemu-devel@nongnu.org \
--cc=ronniesahlberg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.