From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC] fbdev: arm has __raw I/O accessors, use them in fb.h
Date: Fri, 16 Nov 2012 09:28:18 +0000 [thread overview]
Message-ID: <50A60732.3050602@ti.com> (raw)
In-Reply-To: <1353057364-21214-1-git-send-email-archit@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1192 bytes --]
On 2012-11-16 11:16, Archit Taneja wrote:
> This removes the sparse warnings on arm platforms:
>
> warning: cast removes address space of expression
>
> Signed-off-by: Archit Taneja <archit@ti.com>
> ---
> include/linux/fb.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/fb.h b/include/linux/fb.h
> index c7a9571..7fce1e1 100644
> --- a/include/linux/fb.h
> +++ b/include/linux/fb.h
> @@ -548,7 +548,7 @@ static inline struct apertures_struct *alloc_apertures(unsigned int max_num) {
> #define fb_memcpy_fromfb sbus_memcpy_fromio
> #define fb_memcpy_tofb sbus_memcpy_toio
>
> -#elif defined(__i386__) || defined(__alpha__) || defined(__x86_64__) || defined(__hppa__) || defined(__sh__) || defined(__powerpc__) || defined(__avr32__) || defined(__bfin__)
> +#elif defined(__i386__) || defined(__alpha__) || defined(__x86_64__) || defined(__hppa__) || defined(__sh__) || defined(__powerpc__) || defined(__avr32__) || defined(__bfin__) || defined(__arm__)
>
> #define fb_readb __raw_readb
> #define fb_readw __raw_readw
Looks good and works for me:
Acked-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 897 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: tomi.valkeinen@ti.com (Tomi Valkeinen)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC] fbdev: arm has __raw I/O accessors, use them in fb.h
Date: Fri, 16 Nov 2012 11:28:18 +0200 [thread overview]
Message-ID: <50A60732.3050602@ti.com> (raw)
In-Reply-To: <1353057364-21214-1-git-send-email-archit@ti.com>
On 2012-11-16 11:16, Archit Taneja wrote:
> This removes the sparse warnings on arm platforms:
>
> warning: cast removes address space of expression
>
> Signed-off-by: Archit Taneja <archit@ti.com>
> ---
> include/linux/fb.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/fb.h b/include/linux/fb.h
> index c7a9571..7fce1e1 100644
> --- a/include/linux/fb.h
> +++ b/include/linux/fb.h
> @@ -548,7 +548,7 @@ static inline struct apertures_struct *alloc_apertures(unsigned int max_num) {
> #define fb_memcpy_fromfb sbus_memcpy_fromio
> #define fb_memcpy_tofb sbus_memcpy_toio
>
> -#elif defined(__i386__) || defined(__alpha__) || defined(__x86_64__) || defined(__hppa__) || defined(__sh__) || defined(__powerpc__) || defined(__avr32__) || defined(__bfin__)
> +#elif defined(__i386__) || defined(__alpha__) || defined(__x86_64__) || defined(__hppa__) || defined(__sh__) || defined(__powerpc__) || defined(__avr32__) || defined(__bfin__) || defined(__arm__)
>
> #define fb_readb __raw_readb
> #define fb_readw __raw_readw
Looks good and works for me:
Acked-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Tomi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 897 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20121116/b7cd2ded/attachment.sig>
next prev parent reply other threads:[~2012-11-16 9:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-16 9:16 [RFC] fbdev: arm has __raw I/O accessors, use them in fb.h Archit Taneja
2012-11-16 9:28 ` Archit Taneja
2012-11-16 9:28 ` Tomi Valkeinen [this message]
2012-11-16 9:28 ` Tomi Valkeinen
2012-11-16 16:44 ` H Hartley Sweeten
2012-11-16 16:44 ` H Hartley Sweeten
2012-11-19 5:21 ` Archit Taneja
2012-11-19 5:33 ` Archit Taneja
2012-11-19 9:15 ` Russell King - ARM Linux
2012-11-19 9:15 ` Russell King - ARM Linux
2012-11-19 9:36 ` Tomi Valkeinen
2012-11-19 9:36 ` Tomi Valkeinen
2012-11-19 9:46 ` Russell King - ARM Linux
2012-11-19 9:46 ` Russell King - ARM Linux
2012-11-19 10:34 ` Tomi Valkeinen
2012-11-19 10:34 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50A60732.3050602@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.