All of lore.kernel.org
 help / color / mirror / Atom feed
From: matthieu.castet@parrot.com (Matthieu CASTET)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 7/9] usb: chipidea: udc: add force-full-speed option
Date: Fri, 16 Nov 2012 15:53:21 +0100	[thread overview]
Message-ID: <50A65361.5070209@parrot.com> (raw)
In-Reply-To: <87wqxl679k.fsf@ashishki-desk.ger.corp.intel.com>

Alexander Shishkin a ?crit :
> Michael Grzeschik <m.grzeschik@pengutronix.de> writes:
> 
>> This patch makes it possible to set the chipidea udc
>> into full-speed only mode. It can be set by the oftree
>> property "force-full-speed".
>>
>> Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
>> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
>> ---
>>  drivers/usb/chipidea/bits.h  |    1 +
>>  drivers/usb/chipidea/core.c  |    5 +++++
>>  include/linux/usb/chipidea.h |    1 +
>>  3 files changed, 7 insertions(+)
>>
>> diff --git a/drivers/usb/chipidea/bits.h b/drivers/usb/chipidea/bits.h
>> index 3cded5f..85b6b09 100644
>> --- a/drivers/usb/chipidea/bits.h
>> +++ b/drivers/usb/chipidea/bits.h
>> @@ -51,6 +51,7 @@
>>  #define PORTSC_PTS            (BIT(31) | BIT(30))
>>  #define PORTSC_PTW            BIT(28)
>>  #define PORTSC_STS            BIT(29)
>> +#define PORTSC_PFSC           BIT(24)
> 
> Same for this one, it's in DEVLC in my spec.
> 
Yes it depends it device support lpm or not.

We have the same problem with hw_port_is_high_speed [1]. Mapping is different
according lpm support for some register.

Matthieu

[1]
drivers/usb/chipidea/udc.c
static int hw_port_is_high_speed(struct ci13xxx *ci)
{
    return ci->hw_bank.lpm ? hw_read(ci, OP_DEVLC, DEVLC_PSPD) :
        hw_read(ci, OP_PORTSC, PORTSC_HSP);
}

WARNING: multiple messages have this Message-ID (diff)
From: Matthieu CASTET <matthieu.castet-ITF29qwbsa/QT0dZR+AlfA@public.gmane.org>
To: Alexander Shishkin
	<alexander.shishkin-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Cc: Michael Grzeschik
	<m.grzeschik-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
	"linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	"mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org"
	<mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
	"gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org"
	<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
	"fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org"
	<fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
	"kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org"
	<kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
	"devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org"
	<devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>
Subject: Re: [PATCH 7/9] usb: chipidea: udc: add force-full-speed option
Date: Fri, 16 Nov 2012 15:53:21 +0100	[thread overview]
Message-ID: <50A65361.5070209@parrot.com> (raw)
In-Reply-To: <87wqxl679k.fsf-qxRn5AmX6ZD9BXuAQUXR0fooFf0ArEBIu+b9c/7xato@public.gmane.org>

Alexander Shishkin a écrit :
> Michael Grzeschik <m.grzeschik-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> writes:
> 
>> This patch makes it possible to set the chipidea udc
>> into full-speed only mode. It can be set by the oftree
>> property "force-full-speed".
>>
>> Signed-off-by: Michael Grzeschik <m.grzeschik-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
>> Signed-off-by: Marc Kleine-Budde <mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
>> ---
>>  drivers/usb/chipidea/bits.h  |    1 +
>>  drivers/usb/chipidea/core.c  |    5 +++++
>>  include/linux/usb/chipidea.h |    1 +
>>  3 files changed, 7 insertions(+)
>>
>> diff --git a/drivers/usb/chipidea/bits.h b/drivers/usb/chipidea/bits.h
>> index 3cded5f..85b6b09 100644
>> --- a/drivers/usb/chipidea/bits.h
>> +++ b/drivers/usb/chipidea/bits.h
>> @@ -51,6 +51,7 @@
>>  #define PORTSC_PTS            (BIT(31) | BIT(30))
>>  #define PORTSC_PTW            BIT(28)
>>  #define PORTSC_STS            BIT(29)
>> +#define PORTSC_PFSC           BIT(24)
> 
> Same for this one, it's in DEVLC in my spec.
> 
Yes it depends it device support lpm or not.

We have the same problem with hw_port_is_high_speed [1]. Mapping is different
according lpm support for some register.

Matthieu

[1]
drivers/usb/chipidea/udc.c
static int hw_port_is_high_speed(struct ci13xxx *ci)
{
    return ci->hw_bank.lpm ? hw_read(ci, OP_DEVLC, DEVLC_PSPD) :
        hw_read(ci, OP_PORTSC, PORTSC_HSP);
}
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2012-11-16 14:53 UTC|newest]

Thread overview: 98+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-14 16:19 [PATCH 0/9] chipidea fixes and features Michael Grzeschik
2012-11-14 16:19 ` Michael Grzeschik
2012-11-14 16:19 ` [PATCH 1/9] usb: chipidea: pci: mark platformdata as static and __devinitdata Michael Grzeschik
2012-11-14 16:19   ` Michael Grzeschik
2012-11-16 10:06   ` Alexander Shishkin
2012-11-16 10:06     ` Alexander Shishkin
2012-11-16 10:17     ` Marc Kleine-Budde
2012-11-16 10:17       ` Marc Kleine-Budde
2012-11-16 11:41       ` Alexander Shishkin
2012-11-16 11:41         ` Alexander Shishkin
2012-11-16 12:02     ` Greg KH
2012-11-16 12:02       ` Greg KH
2012-11-14 16:19 ` [PATCH 2/9] usb: chipidea: ci13xxx_imx: add 2nd and 3rd clock to support imx5x and newer Michael Grzeschik
2012-11-14 16:19   ` Michael Grzeschik
2012-11-26  9:29   ` Peter Chen
2012-11-26  9:29     ` Peter Chen
2012-11-26 10:22     ` Sascha Hauer
2012-11-26 10:22       ` Sascha Hauer
2012-11-27  6:50       ` Peter Chen
2012-11-27  6:50         ` Peter Chen
2012-11-27  7:34         ` Sascha Hauer
2012-11-27  7:34           ` Sascha Hauer
2012-11-14 16:19 ` [PATCH 3/9] usb: chipidea: ci13xxx-imx: create dynamic platformdata Michael Grzeschik
2012-11-14 16:19   ` Michael Grzeschik
2012-11-16 10:14   ` Alexander Shishkin
2012-11-16 10:14     ` Alexander Shishkin
2012-11-16 10:19     ` Marc Kleine-Budde
2012-11-16 10:19       ` Marc Kleine-Budde
2012-11-16 12:06   ` Alexander Shishkin
2012-11-16 12:06     ` Alexander Shishkin
2012-11-14 16:19 ` [PATCH 4/9] usb: chipidea: ci13xxx-imx: add "dr_mode" property to device tree bindings Michael Grzeschik
2012-11-14 16:19   ` Michael Grzeschik
2012-11-16 11:53   ` Alexander Shishkin
2012-11-16 11:53     ` Alexander Shishkin
2012-11-16 11:55     ` Marc Kleine-Budde
2012-11-16 11:55       ` Marc Kleine-Budde
2012-11-26  9:46     ` Peter Chen
2012-11-26  9:46       ` Peter Chen
2012-11-29 12:54       ` Alexander Shishkin
2012-11-29 12:54         ` Alexander Shishkin
2012-11-14 16:19 ` [PATCH 5/9] usb: add phy connection by phy-mode Michael Grzeschik
2012-11-14 16:19   ` Michael Grzeschik
2012-11-16  9:25   ` Alexander Shishkin
2012-11-16  9:25     ` Alexander Shishkin
2012-11-16 11:28   ` Felipe Balbi
2012-11-16 11:28     ` Felipe Balbi
2012-11-16 11:31   ` Felipe Balbi
2012-11-16 11:31     ` Felipe Balbi
2012-11-16 11:44     ` Marc Kleine-Budde
2012-11-16 11:44       ` Marc Kleine-Budde
2012-11-16 13:41       ` Felipe Balbi
2012-11-16 13:41         ` Felipe Balbi
2012-11-16 14:32         ` Marc Kleine-Budde
2012-11-16 14:32           ` Marc Kleine-Budde
2012-11-26  9:56   ` Peter Chen
2012-11-26  9:56     ` Peter Chen
2012-11-14 16:19 ` [PATCH 6/9] usb: chipidea: add PTW and PTS handling Michael Grzeschik
2012-11-14 16:19   ` Michael Grzeschik
2012-11-16 12:18   ` Alexander Shishkin
2012-11-16 12:18     ` Alexander Shishkin
2012-11-16 12:45   ` Alexander Shishkin
2012-11-16 12:45     ` Alexander Shishkin
2012-11-16 13:16     ` Michael Grzeschik
2012-11-16 13:16       ` Michael Grzeschik
2012-11-16 13:34       ` Alexander Shishkin
2012-11-16 13:34         ` Alexander Shishkin
2012-11-16 13:57         ` Michael Grzeschik
2012-11-16 13:57           ` Michael Grzeschik
2012-11-16 14:06           ` Alexander Shishkin
2012-11-16 14:06             ` Alexander Shishkin
2012-11-16 14:46             ` Matthieu CASTET
2012-11-16 14:46               ` Matthieu CASTET
2012-11-16 15:39               ` Alexander Shishkin
2012-11-16 15:39                 ` Alexander Shishkin
2012-11-21 15:57                 ` Michael Grzeschik
2012-11-21 15:57                   ` Michael Grzeschik
2012-11-21 16:06                   ` Matthieu CASTET
2012-11-21 16:06                     ` Matthieu CASTET
2012-11-27  1:12   ` Peter Chen
2012-11-27  1:12     ` Peter Chen
2012-11-27  9:54     ` Michael Grzeschik
2012-11-27  9:54       ` Michael Grzeschik
2012-11-28  1:26       ` Peter Chen
2012-11-28  1:26         ` Peter Chen
2012-11-14 16:19 ` [PATCH 7/9] usb: chipidea: udc: add force-full-speed option Michael Grzeschik
2012-11-14 16:19   ` Michael Grzeschik
2012-11-16 12:51   ` Alexander Shishkin
2012-11-16 12:51     ` Alexander Shishkin
2012-11-16 14:53     ` Matthieu CASTET [this message]
2012-11-16 14:53       ` Matthieu CASTET
2012-11-14 16:19 ` [PATCH 8/9] usb: chipidea: udc: remove unlocked ep_queue which can lead to an race Michael Grzeschik
2012-11-14 16:19   ` Michael Grzeschik
2012-11-16 12:55   ` Alexander Shishkin
2012-11-16 12:55     ` Alexander Shishkin
2012-11-14 16:19 ` [PATCH 9/9] usb: chipidea: udc: configure iso endpoints Michael Grzeschik
2012-11-14 16:19   ` Michael Grzeschik
2012-11-14 18:04   ` Sergei Shtylyov
2012-11-14 18:04     ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50A65361.5070209@parrot.com \
    --to=matthieu.castet@parrot.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.