From: Stefan Weil <sw@weilnetz.de>
To: qemu-trivial <qemu-trivial@nongnu.org>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [PATCH] s390x: Spelling fixes (endianess -> endianness, occured -> occurred)
Date: Sun, 18 Nov 2012 20:32:42 +0100 [thread overview]
Message-ID: <50A937DA.7080906@weilnetz.de> (raw)
In-Reply-To: <1351841754-26483-1-git-send-email-sw@weilnetz.de>
Am 02.11.2012 08:35, schrieb Stefan Weil:
> Replace also "write into" by "write to".
>
> Signed-off-by: Stefan Weil<sw@weilnetz.de>
> ---
>
> I think "write to" is better, but I am not sure about this,
> so please wait until a native speaker has reviewed that patch.
>
> Regards
> Stefan Weil
>
> hw/s390x/sclp.h | 4 ++--
> hw/s390x/sclpconsole.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/hw/s390x/sclp.h b/hw/s390x/sclp.h
> index fe89dad..231a38a 100644
> --- a/hw/s390x/sclp.h
> +++ b/hw/s390x/sclp.h
> @@ -51,7 +51,7 @@
>
> /*
> * Normally packed structures are not the right thing to do, since all code
> - * must take care of endianess. We cant use ldl_phys and friends for two
> + * must take care of endianness. We cannot use ldl_phys and friends for two
> * reasons, though:
> * - some of the embedded structures below the SCCB can appear multiple times
> * at different locations, so there is no fixed offset
> @@ -60,7 +60,7 @@
> * alter the structure while we parse it. We cannot use ldl_p and friends
> * either without doing pointer arithmetics
> * So we have to double check that all users of sclp data structures use the
> - * right endianess wrappers.
> + * right endianness wrappers.
> */
> typedef struct SCCBHeader {
> uint16_t length;
> diff --git a/hw/s390x/sclpconsole.c b/hw/s390x/sclpconsole.c
> index 0ec5623..fece878 100644
> --- a/hw/s390x/sclpconsole.c
> +++ b/hw/s390x/sclpconsole.c
> @@ -179,8 +179,8 @@ static int read_event_data(SCLPEvent *event, EventBufferHeader *evt_buf_hdr,
> }
>
> /* triggered by SCLP's write_event_data
> - * - write console data into character layer
> - * returns< 0 if an error occured
> + * - write console data to character layer
> + * returns< 0 if an error occurred
> */
> static ssize_t write_console_data(SCLPEvent *event, const uint8_t *buf,
> size_t len)
>
ping?
WARNING: multiple messages have this Message-ID (diff)
From: Stefan Weil <sw@weilnetz.de>
To: qemu-trivial <qemu-trivial@nongnu.org>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] s390x: Spelling fixes (endianess -> endianness, occured -> occurred)
Date: Sun, 18 Nov 2012 20:32:42 +0100 [thread overview]
Message-ID: <50A937DA.7080906@weilnetz.de> (raw)
In-Reply-To: <1351841754-26483-1-git-send-email-sw@weilnetz.de>
Am 02.11.2012 08:35, schrieb Stefan Weil:
> Replace also "write into" by "write to".
>
> Signed-off-by: Stefan Weil<sw@weilnetz.de>
> ---
>
> I think "write to" is better, but I am not sure about this,
> so please wait until a native speaker has reviewed that patch.
>
> Regards
> Stefan Weil
>
> hw/s390x/sclp.h | 4 ++--
> hw/s390x/sclpconsole.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/hw/s390x/sclp.h b/hw/s390x/sclp.h
> index fe89dad..231a38a 100644
> --- a/hw/s390x/sclp.h
> +++ b/hw/s390x/sclp.h
> @@ -51,7 +51,7 @@
>
> /*
> * Normally packed structures are not the right thing to do, since all code
> - * must take care of endianess. We cant use ldl_phys and friends for two
> + * must take care of endianness. We cannot use ldl_phys and friends for two
> * reasons, though:
> * - some of the embedded structures below the SCCB can appear multiple times
> * at different locations, so there is no fixed offset
> @@ -60,7 +60,7 @@
> * alter the structure while we parse it. We cannot use ldl_p and friends
> * either without doing pointer arithmetics
> * So we have to double check that all users of sclp data structures use the
> - * right endianess wrappers.
> + * right endianness wrappers.
> */
> typedef struct SCCBHeader {
> uint16_t length;
> diff --git a/hw/s390x/sclpconsole.c b/hw/s390x/sclpconsole.c
> index 0ec5623..fece878 100644
> --- a/hw/s390x/sclpconsole.c
> +++ b/hw/s390x/sclpconsole.c
> @@ -179,8 +179,8 @@ static int read_event_data(SCLPEvent *event, EventBufferHeader *evt_buf_hdr,
> }
>
> /* triggered by SCLP's write_event_data
> - * - write console data into character layer
> - * returns< 0 if an error occured
> + * - write console data to character layer
> + * returns< 0 if an error occurred
> */
> static ssize_t write_console_data(SCLPEvent *event, const uint8_t *buf,
> size_t len)
>
ping?
next prev parent reply other threads:[~2012-11-18 19:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-02 7:35 [Qemu-trivial] [PATCH] s390x: Spelling fixes (endianess -> endianness, occured -> occurred) Stefan Weil
2012-11-02 7:35 ` [Qemu-devel] " Stefan Weil
2012-11-18 19:32 ` Stefan Weil [this message]
2012-11-18 19:32 ` Stefan Weil
2012-11-19 8:39 ` [Qemu-trivial] " Stefan Hajnoczi
2012-11-19 8:39 ` [Qemu-devel] " Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50A937DA.7080906@weilnetz.de \
--to=sw@weilnetz.de \
--cc=borntraeger@de.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.