From: Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
To: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/2] cgroup, cpuset: remove cgroup_subsys->post_clone()
Date: Mon, 19 Nov 2012 13:40:25 +0800 [thread overview]
Message-ID: <50A9C649.9080602@huawei.com> (raw)
In-Reply-To: <20121113202745.GB21185-9pTldWuhBndy/B6EtB590w@public.gmane.org>
On 2012/11/14 4:27, Tejun Heo wrote:
>>From bbf2566f9f4fc79ff3320e83cafb69533efc9ea0 Mon Sep 17 00:00:00 2001
> From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> Date: Tue, 13 Nov 2012 12:21:50 -0800
>
> Currently CGRP_CPUSET_CLONE_CHILDREN triggers ->post_clone(). Now
> that clone_children is cpuset specific, there's no reason to have this
> rather odd option activation mechanism in cgroup core. cpuset can
> check the flag from its ->css_allocate() and take the necessary
> action.
>
> Move cpuset_post_clone() logic to the end of cpuset_css_alloc() and
> remove cgroup_subsys->post_clone().
>
> Loosely based on Glauber's "generalize post_clone into post_create"
> patch.
>
> Signed-off-by: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> Original-patch-by: Glauber Costa <glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
> Original-patch: <1351686554-22592-2-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
> Cc: Glauber Costa <glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
Acked-by: Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
WARNING: multiple messages have this Message-ID (diff)
From: Li Zefan <lizefan@huawei.com>
To: Tejun Heo <tj@kernel.org>
Cc: <containers@lists.linux-foundation.org>,
<cgroups@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] cgroup, cpuset: remove cgroup_subsys->post_clone()
Date: Mon, 19 Nov 2012 13:40:25 +0800 [thread overview]
Message-ID: <50A9C649.9080602@huawei.com> (raw)
In-Reply-To: <20121113202745.GB21185@mtj.dyndns.org>
On 2012/11/14 4:27, Tejun Heo wrote:
>>From bbf2566f9f4fc79ff3320e83cafb69533efc9ea0 Mon Sep 17 00:00:00 2001
> From: Tejun Heo <tj@kernel.org>
> Date: Tue, 13 Nov 2012 12:21:50 -0800
>
> Currently CGRP_CPUSET_CLONE_CHILDREN triggers ->post_clone(). Now
> that clone_children is cpuset specific, there's no reason to have this
> rather odd option activation mechanism in cgroup core. cpuset can
> check the flag from its ->css_allocate() and take the necessary
> action.
>
> Move cpuset_post_clone() logic to the end of cpuset_css_alloc() and
> remove cgroup_subsys->post_clone().
>
> Loosely based on Glauber's "generalize post_clone into post_create"
> patch.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Original-patch-by: Glauber Costa <glommer@parallels.com>
> Original-patch: <1351686554-22592-2-git-send-email-glommer@parallels.com>
> Cc: Glauber Costa <glommer@parallels.com>
Acked-by: Li Zefan <lizefan@huawei.com>
next prev parent reply other threads:[~2012-11-19 5:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-13 20:27 [PATCH 1/2] cgroup: s/CGRP_CLONE_CHILDREN/CGRP_CPUSET_CLONE_CHILDREN/ Tejun Heo
2012-11-13 20:27 ` Tejun Heo
[not found] ` <20121113202714.GA21185-9pTldWuhBndy/B6EtB590w@public.gmane.org>
2012-11-13 20:27 ` [PATCH 2/2] cgroup, cpuset: remove cgroup_subsys->post_clone() Tejun Heo
2012-11-13 20:27 ` Tejun Heo
[not found] ` <20121113202745.GB21185-9pTldWuhBndy/B6EtB590w@public.gmane.org>
2012-11-14 16:20 ` Glauber Costa
2012-11-14 16:20 ` Glauber Costa
2012-11-14 16:20 ` Glauber Costa
2012-11-19 5:40 ` Li Zefan [this message]
2012-11-19 5:40 ` Li Zefan
[not found] ` <50A9C649.9080602-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2012-11-19 16:36 ` Tejun Heo
2012-11-19 16:36 ` Tejun Heo
2012-11-19 16:36 ` Tejun Heo
2012-11-14 15:50 ` [PATCH 1/2] cgroup: s/CGRP_CLONE_CHILDREN/CGRP_CPUSET_CLONE_CHILDREN/ Serge Hallyn
2012-11-14 15:50 ` Serge Hallyn
2012-11-14 15:50 ` Serge Hallyn
2012-11-19 5:39 ` Li Zefan
2012-11-19 5:39 ` Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50A9C649.9080602@huawei.com \
--to=lizefan-hv44wf8li93qt0dzr+alfa@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.