All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Lieven <pl@dlhnet.de>
Cc: Kevin Wolf <kwolf@redhat.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	ronnie sahlberg <ronniesahlberg@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] iscsi: do not assume device is zero initialized
Date: Mon, 19 Nov 2012 09:25:40 +0100	[thread overview]
Message-ID: <50A9ED04.1020402@redhat.com> (raw)
In-Reply-To: <50A7AB3C.4070902@dlhnet.de>

Il 17/11/2012 16:20, Peter Lieven ha scritto:
> Without any complex checks we can't assume that an
> iscsi target is initialized to zero.
> 
> Signed-off-by: Peter Lieven <pl@kamp.de>
> ---
>  block/iscsi.c |    6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/block/iscsi.c b/block/iscsi.c
> index eb586cb..d685f20 100644
> --- a/block/iscsi.c
> +++ b/block/iscsi.c
> @@ -991,6 +991,11 @@ out:
>      return ret;
>  }
>  
> +static int iscsi_has_zero_init(BlockDriverState *bs)
> +{
> +    return 0;
> +}
> +
>  static QEMUOptionParameter iscsi_create_options[] = {
>      {
>          .name = BLOCK_OPT_SIZE,
> @@ -1017,6 +1022,7 @@ static BlockDriver bdrv_iscsi = {
>      .bdrv_aio_flush  = iscsi_aio_flush,
>  
>      .bdrv_aio_discard = iscsi_aio_discard,
> +    .bdrv_has_zero_init = iscsi_has_zero_init,    
>  
>  #ifdef __linux__
>      .bdrv_ioctl       = iscsi_ioctl,
> 

Applied to scsi-next branch.

Paolo

  reply	other threads:[~2012-11-19  8:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-17 15:20 [Qemu-devel] [PATCH] iscsi: do not assume device is zero initialized Peter Lieven
2012-11-19  8:25 ` Paolo Bonzini [this message]
2012-11-19 10:09   ` Peter Lieven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50A9ED04.1020402@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=pl@dlhnet.de \
    --cc=qemu-devel@nongnu.org \
    --cc=ronniesahlberg@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.