Re: [RFC PATCH V2] mount: Added the -o v4.1 mount option

[Steve Dickson <SteveD@redhat.com>]

On 19/11/12 11:02, Myklebust, Trond wrote:
> On Mon, 2012-11-19 at 10:58 -0500, Steve Dickson wrote:
>>
>> On 19/11/12 10:54, Myklebust, Trond wrote:
>>> On Mon, 2012-11-19 at 10:43 -0500, Steve Dickson wrote:
>>>> This patch will convert -o v4.1, vers=4.1 or nfsvers=4.1 into
>>>> the corresponding "v4,minorversion=1", "vers=4,minorversion=1"
>>>> or "nfsvers=4,minorversion=1" options.
>>>>
>>>
>>> NACK.
>>>
>>> If you are going to do this, then please do it only for kernels that
>>> don't support the "vers=4.1" syntax. i.e. anything older than Linux-3.4.
>> This is the intention... 
>>
>>>
>>> We want to get rid of minorversion=x, not perpetuate it...
>>>
>> Understood... But that is not option in some worlds... ;-) 
> 
> Sure it is. The mount program can continue to parse minorversion= after
> it is gone from the kernel and convert it into the vers=4.x syntax.
> 
Basically what I'm doing now, with the exception of not adding
the minorversion=1 options... 

BTW, there is a bug in the -o v4.1 current logic... 

mount -o v4.1 produces both "v4.1,vers=4,..." in the string that given
to the kernel which does not seem right... I would assume just a "v4.1,.."
should be pumped down.. 

steved.