All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jon Hunter <jon-hunter@ti.com>
To: Daniel Mack <zonque@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
	avinashphilip@ti.com, x0148406@ti.com, tony@atomide.com,
	paul@pwsan.com, nsekhar@ti.com
Subject: Re: [PATCH v4 0/3] OMAP GPMC DT bindings
Date: Mon, 19 Nov 2012 10:48:23 -0600	[thread overview]
Message-ID: <50AA62D7.2040308@ti.com> (raw)
In-Reply-To: <1353338956-19420-1-git-send-email-zonque@gmail.com>


On 11/19/2012 09:29 AM, Daniel Mack wrote:
> This is a series of patches to support GPMC peripherals on OMAP boards.
> 
> Depends on Linus' master +
> omap-next (branch omap-for-v3.8/cleanup-headers-gpmc)
> 
> The only supported peripheral for now is NAND, but other types would be
> easy to add.
> 
> Version 2 addresses details pointed out by Jon Hunter, Afzal Mohammed
> and Rob Herring:
> 
>  - add "reg" and "ti,hwmod" properties to Documentation
>  - use generic of_mtd functions and the property names defined by them,
>    namely "nand-bus-width" and "nand-ecc-mode"
>  - reduce the default register space size in the Documentation to 8K,
>    as found in the hwmod code
>  - switch to a DT layout based on ranges and address translation.
>    Although this property is not currently looked at as long as the
>    handling code still uses the runtime calculation methods, we now
>    have these values in the bindings, eventually allowing us to
>    switch the implementation with less pain.
> 
> Version 3 includes fixes pointed out by Jon Hunter:
> 
>  - better documentation of the 'ranges' property to describe the
>    fact that it's representing the CS lines
>  - GPMC_CS_CONFIGx -> GPMC_CONFIGx in comments
>  - drop interrupt-parent from example bindings
>  - add of_node_put() at the end of the child iteration
> 
> Version 4 fixes compilation for !CONFIG_MTD_NAND and includes more
> details from Jon Hunter and Avinash, Philip:
> 
>  - Add "num-cs" and "num-waitpins" properties, which will eventually
>    be used to get rid of GPMC_CS_NUM
>  - Better description of generic nand DT properties
>  - Dropped patch 3/4 as an equivalent fix was already merged
>  - Added ti,nand-ecc-use-elm property
> 
> Daniel Mack (3):
>   mtd: omap-nand: pass device_node in platform data
>   ARM: OMAP: gpmc: enable hwecc for AM33xx SoCs
>   ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND
> 
>  .../devicetree/bindings/mtd/gpmc-nand.txt          |  84 ++++++++++
>  arch/arm/mach-omap2/gpmc-nand.c                    |   9 +-
>  arch/arm/mach-omap2/gpmc.c                         | 170 +++++++++++++++++++++
>  drivers/mtd/nand/omap2.c                           |   4 +-
>  include/linux/platform_data/mtd-nand-omap2.h       |   2 +
>  5 files changed, 264 insertions(+), 5 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/mtd/gpmc-nand.txt

Thanks for sending out the update. Am I missing something or did you
drop the gpmc.txt binding documentation?

Cheers
Jon


WARNING: multiple messages have this Message-ID (diff)
From: jon-hunter@ti.com (Jon Hunter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 0/3] OMAP GPMC DT bindings
Date: Mon, 19 Nov 2012 10:48:23 -0600	[thread overview]
Message-ID: <50AA62D7.2040308@ti.com> (raw)
In-Reply-To: <1353338956-19420-1-git-send-email-zonque@gmail.com>


On 11/19/2012 09:29 AM, Daniel Mack wrote:
> This is a series of patches to support GPMC peripherals on OMAP boards.
> 
> Depends on Linus' master +
> omap-next (branch omap-for-v3.8/cleanup-headers-gpmc)
> 
> The only supported peripheral for now is NAND, but other types would be
> easy to add.
> 
> Version 2 addresses details pointed out by Jon Hunter, Afzal Mohammed
> and Rob Herring:
> 
>  - add "reg" and "ti,hwmod" properties to Documentation
>  - use generic of_mtd functions and the property names defined by them,
>    namely "nand-bus-width" and "nand-ecc-mode"
>  - reduce the default register space size in the Documentation to 8K,
>    as found in the hwmod code
>  - switch to a DT layout based on ranges and address translation.
>    Although this property is not currently looked at as long as the
>    handling code still uses the runtime calculation methods, we now
>    have these values in the bindings, eventually allowing us to
>    switch the implementation with less pain.
> 
> Version 3 includes fixes pointed out by Jon Hunter:
> 
>  - better documentation of the 'ranges' property to describe the
>    fact that it's representing the CS lines
>  - GPMC_CS_CONFIGx -> GPMC_CONFIGx in comments
>  - drop interrupt-parent from example bindings
>  - add of_node_put() at the end of the child iteration
> 
> Version 4 fixes compilation for !CONFIG_MTD_NAND and includes more
> details from Jon Hunter and Avinash, Philip:
> 
>  - Add "num-cs" and "num-waitpins" properties, which will eventually
>    be used to get rid of GPMC_CS_NUM
>  - Better description of generic nand DT properties
>  - Dropped patch 3/4 as an equivalent fix was already merged
>  - Added ti,nand-ecc-use-elm property
> 
> Daniel Mack (3):
>   mtd: omap-nand: pass device_node in platform data
>   ARM: OMAP: gpmc: enable hwecc for AM33xx SoCs
>   ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND
> 
>  .../devicetree/bindings/mtd/gpmc-nand.txt          |  84 ++++++++++
>  arch/arm/mach-omap2/gpmc-nand.c                    |   9 +-
>  arch/arm/mach-omap2/gpmc.c                         | 170 +++++++++++++++++++++
>  drivers/mtd/nand/omap2.c                           |   4 +-
>  include/linux/platform_data/mtd-nand-omap2.h       |   2 +
>  5 files changed, 264 insertions(+), 5 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/mtd/gpmc-nand.txt

Thanks for sending out the update. Am I missing something or did you
drop the gpmc.txt binding documentation?

Cheers
Jon

  parent reply	other threads:[~2012-11-19 16:48 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-19 15:29 [PATCH v4 0/3] OMAP GPMC DT bindings Daniel Mack
2012-11-19 15:29 ` Daniel Mack
2012-11-19 15:29 ` [PATCH v4 1/3] mtd: omap-nand: pass device_node in platform data Daniel Mack
2012-11-19 15:29   ` Daniel Mack
2012-11-19 15:29 ` [PATCH v4 2/3] ARM: OMAP: gpmc: enable hwecc for AM33xx SoCs Daniel Mack
2012-11-19 15:29   ` Daniel Mack
2012-11-19 15:29 ` [PATCH v4 3/3] ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND Daniel Mack
2012-11-19 15:29   ` Daniel Mack
2012-11-19 20:52   ` Peter Korsgaard
2012-11-19 20:52     ` Peter Korsgaard
2012-11-23 10:36     ` Daniel Mack
2012-11-23 10:36       ` Daniel Mack
2012-11-23 10:47       ` Peter Korsgaard
2012-11-23 10:47         ` Peter Korsgaard
2012-11-23 10:55         ` Daniel Mack
2012-11-23 10:55           ` Daniel Mack
2012-11-23 11:06           ` Peter Korsgaard
2012-11-23 11:06             ` Peter Korsgaard
2012-11-20 11:26   ` Philip, Avinash
2012-11-20 11:26     ` Philip, Avinash
2012-11-19 16:48 ` Jon Hunter [this message]
2012-11-19 16:48   ` [PATCH v4 0/3] OMAP GPMC DT bindings Jon Hunter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50AA62D7.2040308@ti.com \
    --to=jon-hunter@ti.com \
    --cc=avinashphilip@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=nsekhar@ti.com \
    --cc=paul@pwsan.com \
    --cc=tony@atomide.com \
    --cc=x0148406@ti.com \
    --cc=zonque@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.