Re: librbd discard bug problems -> i got it

[Stefan Priebe <s.priebe@profihost.ag>]

Hi Josh,

how can i log in AioRequest.h?

I need to add some debugging into:
     void complete(int r)
     {
       if (should_complete(r)) {
         if (m_hide_enoent && r == -ENOENT)
           r = 0;
         m_completion->complete(r);
         delete this;
       }
     }

Stefan

Am 19.11.2012 23:38, schrieb Josh Durgin:
> On 11/19/2012 01:19 PM, Stefan Priebe wrote:
>> Hello Josh,
>>
>> after digging three days around i got it.
>
> That's great!
>
>> The problem is in aio_discard in internal.cc. The i/o fails when AioZero
>> or AioTruncate is used.
>
> Interesting, I wouldn't have expected the bug to be there. Is
> it failing with a different error code, or just taking too long
> so the guest kernel tries to cancel it?
>
>> It works fine with AioRemove. It seems to depend on overlapping.
>> Hopefully i'm able to provide a patch this nicht.
>
> Looking forward to it!
>
> Josh