All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Priebe <s.priebe@profihost.ag>
To: Josh Durgin <josh.durgin@inktank.com>
Cc: "ceph-devel@vger.kernel.org" <ceph-devel@vger.kernel.org>
Subject: Re: librbd discard bug problems -> i got it
Date: Tue, 20 Nov 2012 00:42:03 +0100	[thread overview]
Message-ID: <50AAC3CB.9090309@profihost.ag> (raw)
In-Reply-To: <50AAC1B1.9070701@inktank.com>

Am 20.11.2012 00:33, schrieb Josh Durgin:
> On 11/19/2012 03:16 PM, Stefan Priebe wrote:
>> mhm qemu rbd block driver. Get's always these errors back. As
>> rbd_aio_bh_cb is directly called from librbd the problem must be there.
>> Strangely i can't find where rbd_aio_bh_cb get's called with -512.
>>
>> ANy further ideas?
>
> Two ideas:
>
> 1) Is rbd_finish_aiocb getting this same return value?
Will check this tomorrow.


> 2) Perhaps it's an issue with the return value wrapping around with
> very large discards. Adding some logging of the return values of each
> rados operation in AioCompletion::complete_request() might give us a
> clue. These large negative return values are suspicious.

Good idea. As r and rval is int it is limited. But 
AioCompletion::complete_request is adding more and more stuff to rval. 
What could be a solution? Bump rval to int64? Or wrap to around to start 
at 0 again?

Stefan

  reply	other threads:[~2012-11-19 23:42 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-19 21:19 librbd discard bug problems -> i got it Stefan Priebe
2012-11-19 22:38 ` Josh Durgin
2012-11-19 22:45   ` Stefan Priebe
2012-11-19 22:48     ` Josh Durgin
2012-11-19 23:16   ` Stefan Priebe
2012-11-19 23:33     ` Josh Durgin
2012-11-19 23:42       ` Stefan Priebe [this message]
2012-11-19 23:47         ` Josh Durgin
2012-11-20  0:00           ` Stefan Priebe
2012-11-20  0:28             ` Josh Durgin
2012-11-20  9:50               ` Stefan Priebe - Profihost AG
2012-11-20 12:46               ` librbd discard bug problems -> i REALLY " Stefan Priebe - Profihost AG
2012-11-20 17:09                 ` Josh Durgin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50AAC3CB.9090309@profihost.ag \
    --to=s.priebe@profihost.ag \
    --cc=ceph-devel@vger.kernel.org \
    --cc=josh.durgin@inktank.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.