From: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
To: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
Cc: Avi Kivity <avi@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
LKML <linux-kernel@vger.kernel.org>, KVM <kvm@vger.kernel.org>
Subject: [PATCH 2/3] KVM: x86: let reexecute_instruction work for tdp
Date: Tue, 20 Nov 2012 07:59:10 +0800 [thread overview]
Message-ID: <50AAC7CE.2050506@linux.vnet.ibm.com> (raw)
In-Reply-To: <50AAC77C.8040505@linux.vnet.ibm.com>
Currently, reexecute_instruction refused to retry all instructions. If
nested npt is used, the emulation may be caused by shadow page, it can
be fixed by dropping the shadow page
Signed-off-by: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
---
arch/x86/kvm/x86.c | 14 ++++++++------
1 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index 7be8452..5fe72cc 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -4469,17 +4469,19 @@ static int handle_emulation_failure(struct kvm_vcpu *vcpu)
return r;
}
-static bool reexecute_instruction(struct kvm_vcpu *vcpu, gva_t gva)
+static bool reexecute_instruction(struct kvm_vcpu *vcpu, unsigned long cr2)
{
- gpa_t gpa;
+ gpa_t gpa = cr2;
pfn_t pfn;
- if (tdp_enabled)
+ if (!ACCESS_ONCE(vcpu->kvm->arch.indirect_shadow_pages))
return false;
- gpa = kvm_mmu_gva_to_gpa_read(vcpu, gva, NULL);
- if (gpa == UNMAPPED_GVA)
- return true; /* let cpu generate fault */
+ if (!vcpu->arch.mmu.direct_map) {
+ gpa = kvm_mmu_gva_to_gpa_read(vcpu, cr2, NULL);
+ if (gpa == UNMAPPED_GVA)
+ return true; /* let cpu generate fault */
+ }
/*
* if emulation was due to access to shadowed page table
--
1.7.7.6
next prev parent reply other threads:[~2012-11-19 23:59 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-19 23:57 [PATCH 0/3] KVM: x86: improve reexecute_instruction Xiao Guangrong
2012-11-19 23:58 ` [PATCH 1/3] KVM: x86: clean up reexecute_instruction Xiao Guangrong
2012-11-20 12:11 ` Gleb Natapov
2012-11-20 20:13 ` Xiao Guangrong
2012-11-19 23:59 ` Xiao Guangrong [this message]
2012-11-26 22:37 ` [PATCH 2/3] KVM: x86: let reexecute_instruction work for tdp Marcelo Tosatti
2012-11-27 3:13 ` Xiao Guangrong
2012-11-27 23:32 ` Marcelo Tosatti
2012-11-28 3:15 ` Xiao Guangrong
2012-11-28 14:01 ` Gleb Natapov
2012-11-28 14:55 ` Xiao Guangrong
2012-11-28 22:07 ` Marcelo Tosatti
2012-11-19 23:59 ` [PATCH 3/3] KVM: x86: improve reexecute_instruction Xiao Guangrong
2012-11-26 22:41 ` Marcelo Tosatti
2012-11-27 3:30 ` Xiao Guangrong
2012-11-27 23:42 ` Marcelo Tosatti
2012-11-28 3:33 ` Xiao Guangrong
2012-11-28 14:12 ` Gleb Natapov
2012-11-28 14:59 ` Xiao Guangrong
2012-11-28 21:57 ` Marcelo Tosatti
2012-11-28 22:40 ` Xiao Guangrong
2012-11-28 23:16 ` Xiao Guangrong
2012-11-29 0:23 ` Marcelo Tosatti
2012-11-29 0:21 ` Marcelo Tosatti
2012-12-03 8:33 ` Xiao Guangrong
2012-12-03 19:47 ` Marcelo Tosatti
2012-11-23 1:16 ` [PATCH 0/3] " Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50AAC7CE.2050506@linux.vnet.ibm.com \
--to=xiaoguangrong@linux.vnet.ibm.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.