* [PATCH] ARM: gic: Fix sparse warning
@ 2012-11-19 10:58 Tushar Behera
2012-11-19 12:42 ` Sergei Shtylyov
0 siblings, 1 reply; 4+ messages in thread
From: Tushar Behera @ 2012-11-19 10:58 UTC (permalink / raw)
To: linux-arm-kernel
gic_irq_domain_ops is only used in this file, so should be marked as
static.
Fixes following compilation warning.
arch/arm/common/gic.c:638:29: warning: symbol 'gic_irq_domain_ops' was
not declared. Should it be static?
Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
---
arch/arm/common/gic.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/common/gic.c b/arch/arm/common/gic.c
index aa52699..4896dec 100644
--- a/arch/arm/common/gic.c
+++ b/arch/arm/common/gic.c
@@ -635,7 +635,7 @@ static int gic_irq_domain_xlate(struct irq_domain *d,
return 0;
}
-const struct irq_domain_ops gic_irq_domain_ops = {
+static const struct irq_domain_ops gic_irq_domain_ops = {
.map = gic_irq_domain_map,
.xlate = gic_irq_domain_xlate,
};
--
1.7.4.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] ARM: gic: Fix sparse warning
2012-11-19 10:58 [PATCH] ARM: gic: Fix sparse warning Tushar Behera
@ 2012-11-19 12:42 ` Sergei Shtylyov
2012-11-20 3:26 ` Tushar Behera
0 siblings, 1 reply; 4+ messages in thread
From: Sergei Shtylyov @ 2012-11-19 12:42 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
On 19-11-2012 14:58, Tushar Behera wrote:
> gic_irq_domain_ops is only used in this file, so should be marked as
> static.
> Fixes following compilation warning.
This is sparse's warning, not compiler's, if I don't mistake.
> arch/arm/common/gic.c:638:29: warning: symbol 'gic_irq_domain_ops' was
> not declared. Should it be static?
> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
WBR, Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ARM: gic: Fix sparse warning
2012-11-19 12:42 ` Sergei Shtylyov
@ 2012-11-20 3:26 ` Tushar Behera
2012-11-20 13:00 ` Sergei Shtylyov
0 siblings, 1 reply; 4+ messages in thread
From: Tushar Behera @ 2012-11-20 3:26 UTC (permalink / raw)
To: linux-arm-kernel
On 11/19/2012 06:12 PM, Sergei Shtylyov wrote:
> Hello.
>
> On 19-11-2012 14:58, Tushar Behera wrote:
>
>> gic_irq_domain_ops is only used in this file, so should be marked as
>> static.
>
>> Fixes following compilation warning.
>
> This is sparse's warning, not compiler's, if I don't mistake.
>
My mistake. It is indeed sparse warning.
>> arch/arm/common/gic.c:638:29: warning: symbol 'gic_irq_domain_ops' was
>> not declared. Should it be static?
>
>> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
>
> WBR, Sergei
>
>
--
Tushar Behera
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ARM: gic: Fix sparse warning
2012-11-20 3:26 ` Tushar Behera
@ 2012-11-20 13:00 ` Sergei Shtylyov
0 siblings, 0 replies; 4+ messages in thread
From: Sergei Shtylyov @ 2012-11-20 13:00 UTC (permalink / raw)
To: linux-arm-kernel
On 20-11-2012 7:26, Tushar Behera wrote:
>>> gic_irq_domain_ops is only used in this file, so should be marked as
>>> static.
>>> Fixes following compilation warning.
>> This is sparse's warning, not compiler's, if I don't mistake.
> My mistake. It is indeed sparse warning.
And I didn't read your subject, where it's called correctly. :-)
>>> arch/arm/common/gic.c:638:29: warning: symbol 'gic_irq_domain_ops' was
>>> not declared. Should it be static?
>>> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
WBR, Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-11-20 13:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-19 10:58 [PATCH] ARM: gic: Fix sparse warning Tushar Behera
2012-11-19 12:42 ` Sergei Shtylyov
2012-11-20 3:26 ` Tushar Behera
2012-11-20 13:00 ` Sergei Shtylyov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.