From: Kamezawa Hiroyuki <kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
To: David Rientjes <rientjes-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
Cc: Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
Michal Hocko <mhocko-AlSwsSmVLrQ@public.gmane.org>,
Hugh Dickins <hughd-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org
Subject: Re: [patch] mm, memcg: avoid unnecessary function call when memcg is disabled
Date: Tue, 20 Nov 2012 13:23:16 +0900 [thread overview]
Message-ID: <50AB05B4.4000303@jp.fujitsu.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1211191741060.24618-X6Q0R45D7oAcqpCFd4KODRPsWskHk0ljAL8bYrjMMd8@public.gmane.org>
(2012/11/20 10:44), David Rientjes wrote:
> While profiling numa/core v16 with cgroup_disable=memory on the command
> line, I noticed mem_cgroup_count_vm_event() still showed up as high as
> 0.60% in perftop.
>
> This occurs because the function is called extremely often even when memcg
> is disabled.
>
> To fix this, inline the check for mem_cgroup_disabled() so we avoid the
> unnecessary function call if memcg is disabled.
>
> Signed-off-by: David Rientjes <rientjes-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
Acked-By: KAMEZAWA Hiroyuki <kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
WARNING: multiple messages have this Message-ID (diff)
From: Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: David Rientjes <rientjes@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@suse.cz>, Hugh Dickins <hughd@google.com>,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [patch] mm, memcg: avoid unnecessary function call when memcg is disabled
Date: Tue, 20 Nov 2012 13:23:16 +0900 [thread overview]
Message-ID: <50AB05B4.4000303@jp.fujitsu.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1211191741060.24618@chino.kir.corp.google.com>
(2012/11/20 10:44), David Rientjes wrote:
> While profiling numa/core v16 with cgroup_disable=memory on the command
> line, I noticed mem_cgroup_count_vm_event() still showed up as high as
> 0.60% in perftop.
>
> This occurs because the function is called extremely often even when memcg
> is disabled.
>
> To fix this, inline the check for mem_cgroup_disabled() so we avoid the
> unnecessary function call if memcg is disabled.
>
> Signed-off-by: David Rientjes <rientjes@google.com>
Acked-By: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: David Rientjes <rientjes@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@suse.cz>, Hugh Dickins <hughd@google.com>,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [patch] mm, memcg: avoid unnecessary function call when memcg is disabled
Date: Tue, 20 Nov 2012 13:23:16 +0900 [thread overview]
Message-ID: <50AB05B4.4000303@jp.fujitsu.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1211191741060.24618@chino.kir.corp.google.com>
(2012/11/20 10:44), David Rientjes wrote:
> While profiling numa/core v16 with cgroup_disable=memory on the command
> line, I noticed mem_cgroup_count_vm_event() still showed up as high as
> 0.60% in perftop.
>
> This occurs because the function is called extremely often even when memcg
> is disabled.
>
> To fix this, inline the check for mem_cgroup_disabled() so we avoid the
> unnecessary function call if memcg is disabled.
>
> Signed-off-by: David Rientjes <rientjes@google.com>
Acked-By: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
next prev parent reply other threads:[~2012-11-20 4:23 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-20 1:44 [patch] mm, memcg: avoid unnecessary function call when memcg is disabled David Rientjes
2012-11-20 1:44 ` David Rientjes
2012-11-20 1:44 ` David Rientjes
[not found] ` <alpine.DEB.2.00.1211191741060.24618-X6Q0R45D7oAcqpCFd4KODRPsWskHk0ljAL8bYrjMMd8@public.gmane.org>
2012-11-20 4:23 ` Kamezawa Hiroyuki [this message]
2012-11-20 4:23 ` Kamezawa Hiroyuki
2012-11-20 4:23 ` Kamezawa Hiroyuki
[not found] ` <50AB05B4.4000303-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2012-11-20 8:34 ` Glauber Costa
2012-11-20 8:34 ` Glauber Costa
2012-11-20 8:34 ` Glauber Costa
2012-11-20 17:27 ` Johannes Weiner
2012-11-20 17:27 ` Johannes Weiner
2012-11-20 17:27 ` Johannes Weiner
2012-11-20 21:49 ` Andrew Morton
2012-11-20 21:49 ` Andrew Morton
2012-11-20 21:49 ` Andrew Morton
[not found] ` <20121120134932.055bc192.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2012-11-21 1:02 ` Kamezawa Hiroyuki
2012-11-21 1:02 ` Kamezawa Hiroyuki
2012-11-21 1:02 ` Kamezawa Hiroyuki
2012-11-21 2:48 ` [patch] mm, memcg: avoid unnecessary function call when memcg is disabled fix David Rientjes
2012-11-21 2:48 ` David Rientjes
[not found] ` <alpine.DEB.2.00.1211201847450.2278-X6Q0R45D7oAcqpCFd4KODRPsWskHk0ljAL8bYrjMMd8@public.gmane.org>
2012-11-21 4:11 ` Kamezawa Hiroyuki
2012-11-21 4:11 ` Kamezawa Hiroyuki
2012-11-21 4:11 ` Kamezawa Hiroyuki
2012-11-21 8:35 ` [patch] mm, memcg: avoid unnecessary function call when memcg is disabled Michal Hocko
2012-11-21 8:35 ` Michal Hocko
2012-11-21 8:35 ` Michal Hocko
2012-11-28 23:29 ` Hugh Dickins
2012-11-28 23:29 ` Hugh Dickins
[not found] ` <alpine.LNX.2.00.1211281509560.15410-fupSdm12i1nKWymIFiNcPA@public.gmane.org>
2012-11-29 13:28 ` [PATCH] memcg: do not check for mm in mem_cgroup_count_vm_event disabled Michal Hocko
2012-11-29 13:28 ` Michal Hocko
2012-11-29 13:28 ` Michal Hocko
2012-11-20 7:07 ` [patch] mm, memcg: avoid unnecessary function call when memcg is disabled Michal Hocko
2012-11-20 7:07 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50AB05B4.4000303@jp.fujitsu.com \
--to=kamezawa.hiroyu-+cum20s59erqfuhtdcdx3a@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
--cc=hughd-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
--cc=mhocko-AlSwsSmVLrQ@public.gmane.org \
--cc=rientjes-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.